Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp424457rdg; Thu, 12 Oct 2023 09:23:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFRzROsRsOMgQ+eA/fowI3gLX+VNSbAsqtnhEA5NS/zDmfAQwN6OHeSq7pGSQBZQSU2j4ue X-Received: by 2002:a05:6a00:238d:b0:690:f877:aa1e with SMTP id f13-20020a056a00238d00b00690f877aa1emr37919769pfc.12.1697127823555; Thu, 12 Oct 2023 09:23:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697127823; cv=none; d=google.com; s=arc-20160816; b=ZMpuT755h+foVPiTbHnxClaX5iVLr1O3tb/zti7WK4HWVSXi9jaizCVMESgc8eqq7a uKMG7uaSB7XKn4lRchT3hCzKiPVSbdwJLap3UiwNeFYu8SCEu7brM/wRDM4IhA+EjXSs S9PS8ake1VzzHRfk3y8GeqTugaPm4tRkoQckP1xmfyuozVd3/PvC1Vec80D+5GYKkjuS u2dSjbwEZwrwZSQ8N4N2tmibU6mVk4+HHlNF/LfkCv9WcLsv/XEfO8pkt/LIBm2Q8RDk Dl8z0jbnoYsYVrlZKvLzJcbGeCcyhE/fzkX7ahgP0v3QAmrS+0akkJcY5xij+Koq2HsQ HjLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=h4LH3Sij9XQU79jEPgJn0yMrYODWkACYHDE2obGOHWY=; fh=8Qhsw0dlwLiZK09YM29XQ1C+LpTlkBbKmiZFDTizG84=; b=GFrOhjQqN4v8izhjDN2WQwR/qLpsnSdXjbXb2U3RZM/rydEWg6K/gv0m+dMSNcI85e vlnkRVxt0UMzrRbfUoHrsjVAFEDyYSs7DRkBZghLub324hJgoBLeNYIoYltT/fx+Nllw 4biLr3U1b38GhtVHFrMCKzUtwD2zkuw92VGJEA0eewFMRskpPja1sF3i6iOqiWbKz44l CUn0WbOZknqhZxPAiPj5es0uOClZ4DSDD/tLK4CFCsBJi1kZeyLJ14TnGIYxLDnbZeND AKIT1fNv9Qq6VFcF9NrHbt4o7addzhnFogB63A3dN3YOE5MIq3lnow22BvrIl/zRcniV kVBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=lNkMMStv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id m16-20020a63fd50000000b00573fdbc93c0si2625877pgj.892.2023.10.12.09.23.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Oct 2023 09:23:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=lNkMMStv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id CCF9582D7865; Thu, 12 Oct 2023 09:23:40 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344029AbjJLQX2 (ORCPT + 99 others); Thu, 12 Oct 2023 12:23:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344015AbjJLQX0 (ORCPT ); Thu, 12 Oct 2023 12:23:26 -0400 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF419C6 for ; Thu, 12 Oct 2023 09:23:24 -0700 (PDT) Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2c186ea81c7so14790351fa.1 for ; Thu, 12 Oct 2023 09:23:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1697127803; x=1697732603; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=h4LH3Sij9XQU79jEPgJn0yMrYODWkACYHDE2obGOHWY=; b=lNkMMStv2VG/yLi+jmTLOWikgJ3VJgE+kGr40cGti5QrmEhf6Yp0upLBeqReLj+Da8 H5f/KZR264WVEU5MepKvnOs2JHBxONPNbDzg4Zob5v8jZhCNsg+eeLQ1yU6P3gWOpUjy O1FIL+jgTNVWgUG3LriklIbQs9BPq8MC443NZR14UGrBkM8eCnNRZF3mtdkbHLnPV8Qg 1y5+i9ObU09w62ulsA+VBzNjDLGBQMoriSIChusbtSQThsguzamTVTxpTixpN7KeRiDi QmzKUIuE1+mTWEQlxkSb+3G/ufPVlxWGR/RJNZyCJBoKRQbQh81c8myvFA17nRwKDn8/ /rOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697127803; x=1697732603; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h4LH3Sij9XQU79jEPgJn0yMrYODWkACYHDE2obGOHWY=; b=MCM6jQxYDkDXkGb281Nl3Y3OpCFgjI8adV/67Ne3JHWsvC7dsjQWSCvlxEwfK9UqKw QHIuV/xZJ0NRx4HTOydc3ds6dDm5K24djjcNMYImgRrNGByKK5ZPOyximcvEKfI+W50o 1KsQ2LpJQfsxDXCz3I2VM96KY8XbE4fMDxsCM9hl3Dp8V1VpR3ESSdRZR3Ecth4pFmiu KH3xrQeKVA+0BiBOeaHNorjtIpKeQZ3O/R+LNk+PJu3gsYrqNRP3yS3cjQ096rCeymwf f0UZZtNOLVr0yLLxZHOovg7SsQXTIuD66M/8KO55mhR+w6z2aF5W9Yn9GR44jOKZG/CZ ZV5w== X-Gm-Message-State: AOJu0YysQvXcoV9vcwNunKlUW18Fs46gnKQVZmNY26Rsj2O1Oflry0cU EndmdWHprGndBtk9Gb2lJluQ8kPY7oIKPZRlVJJIpw== X-Received: by 2002:a2e:97d3:0:b0:2bc:c3ad:f418 with SMTP id m19-20020a2e97d3000000b002bcc3adf418mr25123355ljj.20.1697127803015; Thu, 12 Oct 2023 09:23:23 -0700 (PDT) MIME-Version: 1.0 References: <20231010-ad2s1210-mainline-v5-0-35a0f6ffa04a@baylibre.com> <20231010-ad2s1210-mainline-v5-4-35a0f6ffa04a@baylibre.com> <20231012092522.27ef48dd@jic23-huawei> In-Reply-To: <20231012092522.27ef48dd@jic23-huawei> From: David Lechner Date: Thu, 12 Oct 2023 11:23:11 -0500 Message-ID: Subject: Re: [PATCH v5 4/4] iio: resolver: ad2s1210: move out of staging To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, Michael Hennerich , =?UTF-8?B?TnVubyBTw6E=?= , Axel Haslam , Philip Molloy , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 12 Oct 2023 09:23:41 -0700 (PDT) On Thu, Oct 12, 2023 at 3:25=E2=80=AFAM Jonathan Cameron = wrote: > > On Tue, 10 Oct 2023 16:12:36 -0500 > David Lechner wrote: > > > This moves the ad2s1210 resolver driver out of staging. The driver has > > been fixed up and is ready to graduate. > > > > Signed-off-by: David Lechner > > --- > > > > v5 changes: New patch in v5. > > > > Diff was made with file rename detection turned off so we can see the f= ull > > driver code for one last check through. sysfs-bus-iio-resolver-ad2s1210= and > > ad2s1210.c are just moved (no changes). > > Excellent. Great work btw - this looks really nice now. > > I did a final scan through (most of the code was familiar for some reason= :) Thanks for all of the reviews. There were less than 200 lines left (mostly blank lines and boilerplate) that didn't get touched!