Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
MIME-Version: 1.0
Date:   Thu, 12 Oct 2023 16:45:30 +0000
From:   =?UTF-8?Q?Jos=C3=A9_Pekkarinen?= <jose.pekkarinen@foxhound.fi>
To:     Paolo Bonzini <pbonzini@redhat.com>
Cc:     seanjc@google.com, skhan@linuxfoundation.org, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
        x86@kernel.org, hpa@zytor.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] kvm/sev: remove redundant MISC_CG_RES_SEV_ES
In-Reply-To: <9faf1a1a-af49-5f6f-9f33-6cf57f884c44@redhat.com>
References: <20231010174932.29769-1-jose.pekkarinen@foxhound.fi>
 <9faf1a1a-af49-5f6f-9f33-6cf57f884c44@redhat.com>
User-Agent: Roundcube Webmail/1.4.13
Message-ID: <6a777c72a6dc15ad80ecbedd4c6c35d9@foxhound.fi>
Organization: Foxhound Ltd.
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2023-10-12 13:43, Paolo Bonzini wrote:
> On 10/10/23 19:49, José Pekkarinen wrote:
>> SEV-ES is an extra encrypted state that shares common resources
>> with SEV. Using an extra CG for its purpose doesn't seem to
>> provide much value. This patch will clean up the control group
>> along with multiple checks that become redundant with it.
>> 
>> The patch will also remove a redundant logic on sev initialization
>> that produces SEV-ES to be disabled, while supported by the cpu
>> and requested by the user through the sev_es parameter.
> 
> In what sense is it shared?  The SEV ASIDs and the SEV-ES ASIDs are
> separate (and in both cases limited) resources, and therefore they
> have separate cgroups.

     Nevermind this patch, after a painful bios upgrade I got sev-es
available in it, and I was able to launch some test vm on it, so this
may only be breaking things. Sorry for the noise!

     José.