Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp439104rdg; Thu, 12 Oct 2023 09:49:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEWbtF9CLUMKqmstYr4/a/HTFjHhV2wWO+vaobwPhmOz7HQwJOW+0LtCZSrb1xtZXrWYMsf X-Received: by 2002:a05:6a21:3d94:b0:171:947f:464f with SMTP id bj20-20020a056a213d9400b00171947f464fmr8062316pzc.33.1697129341546; Thu, 12 Oct 2023 09:49:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697129341; cv=none; d=google.com; s=arc-20160816; b=Wsl+U/nExgZDYrZ5fz5qXupLNuY2HRboiKjQMC0XfkkBED4x8Gh7KfHmCbXoGhQEoG Z3Fk/TIYXWC/+WU6pQp+Je5rKBVi17zvGRPAM7LrvaI1gHnEgdVDNtSUVsJufu2gOB3c GSbkOIPeEJlxe2jpQkJKGy8/0LQEVbQzJmFC+61/CoYch0yUlhBEUmfovl9NIEdWnWes 6+6tyNL6PEKm9tQTmXdrZ1isCvfo9WdMMd1TsblYRyKWCsqjabq0pBCDXCS/8kogWGaI faqcQ6wQ+8mjy0WVh2L1Vxdrthvs6rTfFhw5LW39Ft3Tcol5jbawBuqdNVae4jYa6sIX hgGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=9zj94NuVMRyygdkOW8mvq9Nen4maWkMgZsmZqNR+8rw=; fh=Q4MKURSAiB9zyytkRBCf7Hh2LriVDbTUnMrjOzyTNIY=; b=ayKcPBt57/ZVKsYcOXvyUK57LEov9lqDkrn6Wlrjt9mzeB+h5zKQkMUw64y9vC6R4F j3xfPfu42f23ruGm0FKzq0Pu6Gl6BxWwNfoT450adKV23JuSl8uGEqTJSCXk60S/0t+4 nXlCi+93kMLSdMfrJjgzqr8OhToKEV6ZCNDvVv9tjnomc0e5ZxUD5QEwHiecs7V/Osa5 WExmQqaevILZ/O0YKEUwdo1u1foA9TVgijXvBIYzrHuzFEkK157S6KjYvaOZ+DBHS7x9 Teejgn2XjBmarnNW+cEcWGWkfW6jltbmBwB3bHpIw3uZmfN8mE4zjNCW4blrncZODJZJ l35Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=bRTOFj4f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id k6-20020a6555c6000000b0056a9b0297cesi2530235pgs.150.2023.10.12.09.49.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Oct 2023 09:49:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=bRTOFj4f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 41C758229089; Thu, 12 Oct 2023 09:48:59 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379565AbjJLQss (ORCPT + 99 others); Thu, 12 Oct 2023 12:48:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379580AbjJLQsq (ORCPT ); Thu, 12 Oct 2023 12:48:46 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72BC7DE for ; Thu, 12 Oct 2023 09:48:44 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1c9d3a21f7aso9983255ad.2 for ; Thu, 12 Oct 2023 09:48:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1697129324; x=1697734124; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9zj94NuVMRyygdkOW8mvq9Nen4maWkMgZsmZqNR+8rw=; b=bRTOFj4fSA056yrQKskox7o7RyuI3GNwUJPIzG55g6Vb1Vj52nUkqQhnJo4fRkVQZp BQdiwdDAotjrg1oO3PqN4zr9BORHv9s5+pLpCKdN+IPZ2CV23Ab/nQujySzvosvML9TL jxeSSVnjvDrn1e+T0a7dc/Ii+mk2RpVKRd34I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697129324; x=1697734124; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9zj94NuVMRyygdkOW8mvq9Nen4maWkMgZsmZqNR+8rw=; b=qFgK93aT4JITorjdBV2kNgE4uRLlrD04Hv7R+5MoJjSNhXAjDGHZbmAUn1ojcpLUti v5zx+LoXwQHtpntuB0gyYA3rCWcxWfgTtqUr2Klc4xfAtmUb2Tuy//qbI1ArlbvRsSlO axt+a3nhpleLvJa9pDldFjrBYRm93magfSueiHkG4ynilnMieeEbv3r08nW3V19WumNi Wy8pfHSXFjv8t+DRbxZ5xXS5354SB9DmhiN3OOZLjOKMJHZoVJkxpb3t44875oW/qONh yRuaBEAv93pmzLg/PeG/oTPA/LZSLj9dlrR59Z4Oq7RhOkTsBQhW7XVeoKINYoTTEIGA EpDw== X-Gm-Message-State: AOJu0YzPYagUQx0J2fghRHBZuqUjvOrGpPur7mWaGSjE0owsF4X14gsL idBe+QFlKGg68iQfudYf0o+EnQ== X-Received: by 2002:a17:903:11d2:b0:1c7:2697:ec0a with SMTP id q18-20020a17090311d200b001c72697ec0amr28084231plh.30.1697129323902; Thu, 12 Oct 2023 09:48:43 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id x4-20020a170902ea8400b001c5076ae6absm2204778plb.126.2023.10.12.09.48.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Oct 2023 09:48:43 -0700 (PDT) From: Kees Cook To: Jiasheng Jiang Cc: Kees Cook , tony.luck@intel.com, gpiccoli@igalia.com, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] pstore/platform: Add check for kstrdup Date: Thu, 12 Oct 2023 09:48:41 -0700 Message-Id: <169712932001.5350.10182418867498473478.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230623022706.32125-1-jiasheng@iscas.ac.cn> References: <20230623022706.32125-1-jiasheng@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 12 Oct 2023 09:48:59 -0700 (PDT) On Fri, 23 Jun 2023 10:27:06 +0800, Jiasheng Jiang wrote: > Add check for the return value of kstrdup() and return the error > if it fails in order to avoid NULL pointer dereference. > > Applied to for-next/pstore, thanks! [1/1] pstore/platform: Add check for kstrdup https://git.kernel.org/kees/c/a19d48f7c5d5 Take care, -- Kees Cook