Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
MIME-Version: 1.0
References: <ZR6+MhXtLnv6ow6E@kernel.org> <CAP-5=fWtX3_bmBHbeEskmM4rzX-r1LAhE8_kaYy8WueUpKCdUw@mail.gmail.com>
In-Reply-To: <CAP-5=fWtX3_bmBHbeEskmM4rzX-r1LAhE8_kaYy8WueUpKCdUw@mail.gmail.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Thu, 12 Oct 2023 10:21:54 -0700
Message-ID: <CAM9d7cjYRbdmEuqob8wC4Ca9DSpg+fCv85jWnuOZQ8grDcJnWQ@mail.gmail.com>
Subject: Re: [PATCH 1/1] perf build: Add missing comment about NO_LIBTRACEEVENT=1
To:     Ian Rogers <irogers@google.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Thu, Oct 5, 2023 at 8:45 AM Ian Rogers <irogers@google.com> wrote:
>
> On Thu, Oct 5, 2023 at 6:46 AM Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> >
> > From: Arnaldo Carvalho de Melo <acme@redhat.com>
> >
> > By default perf will fail the build if the development files for
> > libtraceevent are not available.
> >
> > To build perf without libtraceevent support, disabling several features
> > such as 'perf trace', one needs to add NO_LIBTRACEVENT=1 to the make
> > command line.
> >
> > Add the missing comments about that to the tools/perf/Makefile.perf
> > file, just like all the other such command line toggles.
> >
> > Fixes: 378ef0f5d9d7f465 ("perf build: Use libtraceevent from the system")
> > Cc: Adrian Hunter <adrian.hunter@intel.com>
> > Cc: Ian Rogers <irogers@google.com>
> > Cc: Jiri Olsa <jolsa@kernel.org>
> > Cc: Namhyung Kim <namhyung@kernel.org>
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> Reviewed-by: Ian Rogers <irogers@google.com>

Applied to perf-tools-next, thanks!