Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
MIME-Version: 1.0
References: <20231010234803.5419-1-bwicaksono@nvidia.com>
In-Reply-To: <20231010234803.5419-1-bwicaksono@nvidia.com>
From:   Namhyung Kim <namhyung@gmail.com>
Date:   Thu, 12 Oct 2023 10:24:21 -0700
Message-ID: <CAM9d7cgE6vcB0Pi+585JKaddiRGOFkFFEiDP_FS-x6-2itVtfA@mail.gmail.com>
Subject: Re: [PATCH v3] perf cs-etm: Fix incorrect or missing decoder for raw trace
To:     Besar Wicaksono <bwicaksono@nvidia.com>
Cc:     james.clark@arm.com, mike.leach@linaro.org, suzuki.poulose@arm.com,
        acme@kernel.org, linux-perf-users@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        coresight@lists.linaro.org, linux-tegra@vger.kernel.org,
        treding@nvidia.com, jonathanh@nvidia.com, vsethi@nvidia.com,
        rwiley@nvidia.com, ywan@nvidia.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Oct 10, 2023 at 4:49=E2=80=AFPM Besar Wicaksono <bwicaksono@nvidia.=
com> wrote:
>
> The decoder creation for raw trace uses metadata from the first CPU.
> On per-cpu mode, this metadata is incorrectly used for every decoder.
> On per-process/per-thread traces, the first CPU is CPU0. If CPU0 trace
> is not enabled, its metadata will be marked unused and the decoder is
> not created. Perf report dump skips the decoding part because the
> decoder is missing.
>
> To fix this, use metadata of the CPU associated with sample object.
>
> Signed-off-by: Besar Wicaksono <bwicaksono@nvidia.com>
> Reviewed-by: James Clark <james.clark@arm.com>

Applied to perf-tools-next, thanks!