Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <0bd97aed259d9ec0ff4d8c95f63d5db65550b893.camel@linux.intel.com>
Subject: Re: [PATCH V3 10/16] platform/x86/intel/pmc: Split
 pmc_core_ssram_get_pmc()
From:   "David E. Box" <david.e.box@linux.intel.com>
Reply-To: david.e.box@linux.intel.com
To:     Ilpo =?ISO-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        platform-driver-x86@vger.kernel.org, rajvi.jingar@linux.intel.com
Date:   Thu, 12 Oct 2023 10:28:27 -0700
In-Reply-To: <c66f2061-a7e6-8df7-928-da2a14a3cb49@linux.intel.com>
References: <20231012023840.3845703-1-david.e.box@linux.intel.com>
         <20231012023840.3845703-11-david.e.box@linux.intel.com>
         <c66f2061-a7e6-8df7-928-da2a14a3cb49@linux.intel.com>
Organization: David E. Box
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-10-12 at 18:14 +0300, Ilpo J=C3=A4rvinen wrote:
> On Wed, 11 Oct 2023, David E. Box wrote:
>=20
> > On supported hardware, each PMC may have an associated SSRAM device for
> > accessing additional counters.=C2=A0 However, only the SSRAM of the fir=
st
> > (primary) PMC is discoverable as a PCI device to the OS. The remaining
> > (secondary) devices are hidden but their BARs are still accessible and
> > their addresses are stored in the BAR of the exposed device. Clean up t=
he
> > code handling the SSRAM discovery. Create two separate functions for
> > accessing the primary and secondary SSRAM devices.
> >=20
> > Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> > ---
> > V3 - New patch split from previous PATCH 2
> > =C2=A0=C2=A0 - Update changelog
> > =C2=A0=C2=A0 - Use cleanup.h to cleanup ioremap
> >=20
> > V2 - no change
> >=20
> > =C2=A0drivers/platform/x86/intel/pmc/core_ssram.c | 93 ++++++++++++++--=
-----
> > =C2=A01 file changed, 61 insertions(+), 32 deletions(-)
> >=20
> > diff --git a/drivers/platform/x86/intel/pmc/core_ssram.c
> > b/drivers/platform/x86/intel/pmc/core_ssram.c
> > index 815950713e25..af405d11919f 100644
> > --- a/drivers/platform/x86/intel/pmc/core_ssram.c
> > +++ b/drivers/platform/x86/intel/pmc/core_ssram.c
> > @@ -8,6 +8,7 @@
> > =C2=A0 *
> > =C2=A0 */
> > =C2=A0
> > +#include <linux/cleanup.h>
> > =C2=A0#include <linux/pci.h>
> > =C2=A0#include <linux/io-64-nonatomic-lo-hi.h>
> > =C2=A0
> > @@ -21,6 +22,8 @@
> > =C2=A0#define SSRAM_IOE_OFFSET=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A00x68
> > =C2=A0#define SSRAM_DEVID_OFFSET=C2=A0=C2=A0=C2=A0=C2=A0=C2=A00x70
> > =C2=A0
> > +DEFINE_FREE(pmc_core_iounmap, void __iomem *, iounmap(_T));
> > +
>=20
> Was it that adding
>=20
> DEFINE_FREE(iounmap, void __iomem *, iounmap(_T));
>=20
> into some header did not work for some reason or why this? (Perhaps=20
> because iounmap is also defined?)

No, I didn't think to add it. I'll try and send in the next version.

David

>=20