Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
MIME-Version: 1.0
References: <20230928004431.1926969-1-irogers@google.com> <CAP-5=fW6dBQQ7XnDm+Ye7R2bksNrWWwZJ+X33QnDvcjqjgtU5Q@mail.gmail.com>
In-Reply-To: <CAP-5=fW6dBQQ7XnDm+Ye7R2bksNrWWwZJ+X33QnDvcjqjgtU5Q@mail.gmail.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Thu, 12 Oct 2023 10:23:00 -0700
Message-ID: <CAM9d7cjMraYFyx4v6ahVJ56ys0Kq769yzzNeO+bQ2my0y2=Jsg@mail.gmail.com>
Subject: Re: [PATCH v1] perf parse-events: Fix for term values that are raw events
To:     Ian Rogers <irogers@google.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Kan Liang <kan.liang@linux.intel.com>,
        James Clark <james.clark@arm.com>,
        linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        Adrian Hunter <adrian.hunter@intel.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>, Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Peter Zijlstra <peterz@infradead.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Thu, Oct 5, 2023 at 3:13 PM Ian Rogers <irogers@google.com> wrote:
>
> On Wed, Sep 27, 2023 at 5:44 PM Ian Rogers <irogers@google.com> wrote:
> >
> > Raw events can be strings like 'r0xead' but the 0x is optional so they
> > can also be 'read'. On IcelakeX uncore_imc_free_running has an event
> > called 'read' which may be programmed as:
> > ```
> > $ perf stat -e 'uncore_imc_free_running/event=read/' -a sleep 1
> > ```
> > However, the PE_RAW type isn't allowed on the right of a term, even
> > though in this case we just want to interpret it as a string. This
> > leads to the following error on IcelakeX:
> > ```
> > $ perf stat -e 'uncore_imc_free_running/event=read/' -a sleep 1
> > event syntax error: '..nning/event=read/'
> >                                   \___ parser error
> > Run 'perf list' for a list of valid events
> >
> >  Usage: perf stat [<options>] [<command>]
> >
> >     -e, --event <event> event selector. use 'perf list' to list available events
> > ```
> > Fix this by allowing raw types on the right of terms and treat them as
> > strings, just as is already done for PE_LEGACY_CACHE. Make this
> > consistent by just entirely removing name_or_legacy and always using
> > name_or_raw that covers all three cases.
> >
> > Fixes: 6fd1e5191591 ("perf parse-events: Support PMUs for legacy cache events")
> > Signed-off-by: Ian Rogers <irogers@google.com>

Applied to perf-tools-next, thanks!