Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp467268rdg; Thu, 12 Oct 2023 10:37:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEJtMzfoGFIZ81hoYNU0i6BE3pEDjFh1gjreWGOScaWDfWeEPSI1TaCLY+AVzsBzBHjyXBj X-Received: by 2002:a17:903:32c3:b0:1c9:dc6f:d1d6 with SMTP id i3-20020a17090332c300b001c9dc6fd1d6mr3853874plr.0.1697132248334; Thu, 12 Oct 2023 10:37:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697132248; cv=none; d=google.com; s=arc-20160816; b=Cdkx0XTRHgDsu2J9VsRKlvQgr3r564i/LNnGUhI+hMNqQdpl2ed3d7f+smpg/T5qIY FCWjNUDycCoGjR4MNbwwxpHc3IaerBXKf5biGsJ4C1D4ud0rGba9v+jyGt5QyLY8X3TU OCV+mVV8FFhDaxp6VYJEIadUGySeA/QLNJhuDO2OtL++B6dsth9vLV84wxDvgU0tpmKY qo4SL6vnZ1y7JBWtGPU7m6VsWD1K8aoWU6v1SES1pzF0g7cWIUepJLuVdVcbX72NvIIl 5rg2yvolEQRKrbAZPv59SrVzJCooJuGE9S4kaxg/jlzEPeLiiamS+vKQrVzIduPcErLE ZlRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:organization:references:in-reply-to:date :cc:to:reply-to:from:subject:message-id:dkim-signature; bh=xdt5/Au8+P8aciApF5KRE4r7URgA+4e3oS7ZjhG6eHQ=; fh=7DulYG9o6sxd6VJ2IU+yWFyOHUtNV97sFo9HvvRkfWA=; b=KVcYAf+4zBfO7EXP8YkRBhQUM9zCJ8P6NZHF+tjVQE8+GbzFdYMjet+xaf2OtCI/X3 LOByRRaPEQOY5LL+djSN6OtdR+UKmW2sIzqC8go41C9Kgnsk/EdudNVKvfy5RXZfxY3h 2i1LcVqyUYBmBPvXHLwt0JEgacdvLDX5qdUEmS1s5IO5SWpOHz+E8+xD4EfM9MaF9RQu 3pzjDBX8npYgAIjPoXgFjymNkjuUJzG+O8jkJasV4GoZBi1fOgs14C9K+NTbS160nn92 /lg+drRn/9pCvOJXjQacIC643oihGTpfMpWT5VRtPV+o+mUDbGmhsd3ThY5LuOPNU3k4 12rQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=jsrlDXhA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id p5-20020a170902bd0500b001c589ba4a04si2525502pls.24.2023.10.12.10.37.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Oct 2023 10:37:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=jsrlDXhA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 909F2822C16F; Thu, 12 Oct 2023 10:37:25 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347408AbjJLRhP (ORCPT + 99 others); Thu, 12 Oct 2023 13:37:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347378AbjJLRg4 (ORCPT ); Thu, 12 Oct 2023 13:36:56 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7F92213E; Thu, 12 Oct 2023 10:23:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697131394; x=1728667394; h=message-id:subject:from:reply-to:to:cc:date:in-reply-to: references:content-transfer-encoding:mime-version; bh=xdt5/Au8+P8aciApF5KRE4r7URgA+4e3oS7ZjhG6eHQ=; b=jsrlDXhAGvrxqm1Z2KZnnF75f0L0CK/GNzCpv6s2oReCTU2GDH4/Q+AN 0Wn8H3MdwxSsrh5bFgv/4GS65NqUKQNq7OW63/NPjNuWwljO72ncOlrmp ixHQEm2e7xfM6iUYs6hAot/odE5x0f7Q/6kM3J+4VDbFw81gnBm+BFaFh mHGn+dUEtoVo1H1bIuUVYMj0s5QEpG/NXojuvbcXDQl9qkIkLIH2CbF/c NoGtkhNeI15GQM6AeJ8S/MuVSXYoZVEDxRFhYqOvddhVE35m8radtHnAS ib3/4dePImn1PCOzmLXMvwZBgR8CVxSMHKPRVdGxsSV/QNKf5/BVvVKC8 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10861"; a="365247170" X-IronPort-AV: E=Sophos;i="6.03,219,1694761200"; d="scan'208";a="365247170" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2023 10:23:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10861"; a="870677425" X-IronPort-AV: E=Sophos;i="6.03,219,1694761200"; d="scan'208";a="870677425" Received: from linux.intel.com ([10.54.29.200]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2023 10:23:13 -0700 Received: from [10.54.75.156] (debox1-desk1.jf.intel.com [10.54.75.156]) by linux.intel.com (Postfix) with ESMTP id C355C580919; Thu, 12 Oct 2023 10:23:13 -0700 (PDT) Message-ID: <6ed4cd5ae37a054d4780c8fa519dc83396b15c14.camel@linux.intel.com> Subject: Re: [PATCH V3 03/16] platform/x86/intel/vsec: Use cleanup.h From: "David E. Box" Reply-To: david.e.box@linux.intel.com To: kernel test robot , linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, ilpo.jarvinen@linux.intel.com, rajvi.jingar@linux.intel.com Cc: oe-kbuild-all@lists.linux.dev Date: Thu, 12 Oct 2023 10:23:13 -0700 In-Reply-To: <202310121314.3Xpqom2w-lkp@intel.com> References: <20231012023840.3845703-4-david.e.box@linux.intel.com> <202310121314.3Xpqom2w-lkp@intel.com> Organization: David E. Box Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 12 Oct 2023 10:37:25 -0700 (PDT) On Thu, 2023-10-12 at 13:25 +0800, kernel test robot wrote: > Hi David, >=20 > kernel test robot noticed the following build warnings: >=20 > [auto build test WARNING on acce85a7dd28eac3858d44230f4c65985d0f271c] >=20 > url:=C2=A0=C2=A0=C2=A0 > https://github.com/intel-lab-lkp/linux/commits/David-E-Box/platform-x86-i= ntel-vsec-Move-structures-to-header/20231012-104217 > base:=C2=A0=C2=A0 acce85a7dd28eac3858d44230f4c65985d0f271c > patch link:=C2=A0=C2=A0=C2=A0 > https://lore.kernel.org/r/20231012023840.3845703-4-david.e.box%40linux.in= tel.com > patch subject: [PATCH V3 03/16] platform/x86/intel/vsec: Use cleanup.h > reproduce: > (https://download.01.org/0day-ci/archive/20231012/202310121314.3Xpqom2w-l= kp@in > tel.com/reproduce) >=20 > If you fix the issue in a separate patch/commit (i.e. not just a new vers= ion > of > the same patch/commit), kindly add following tags > > Reported-by: kernel test robot > > Closes: > > https://lore.kernel.org/oe-kbuild-all/202310121314.3Xpqom2w-lkp@intel.c= om/ >=20 > # many are suggestions rather than must-fix >=20 > ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) > #31: FILE: drivers/platform/x86/intel/vsec.c:159: > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0struct intel_vsec_device __fre= e(kfree) *intel_vsec_dev =3D NULL; These looks like false positives. David > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^ >=20