Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp467676rdg; Thu, 12 Oct 2023 10:38:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFK/K8685YbZmk+kJceBs2bBz4SfrwHjU8lMgXKH1I/3giXTl/r/Ey90mT459ppFyWS7uCQ X-Received: by 2002:a05:6870:c092:b0:1d5:f22f:7a00 with SMTP id c18-20020a056870c09200b001d5f22f7a00mr29950107oad.27.1697132300193; Thu, 12 Oct 2023 10:38:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697132300; cv=none; d=google.com; s=arc-20160816; b=N/YL6CWZgpBZGDWmvVXb568ueXC1JFaaH4OMzjj28iCG4fvsaFPDFdN1r1m+QdXbFy zS+MAxH5iJ9qDEsgCKk9FzFM20ksvXe4okR7ntlteuaS0df3aBNnWM587IVbj6UmQaFg 8b3YbY7rb+/xsFI73INbLrmwBH/SEydNTdvhssJCxcyp6RLZ6KiRc9OBpGvDNf990pwY QkaMDs59N+vz7wKVq4SEC4pLUGkZ6vbdjnyipEUz0IHQQsNm++coirVLggxQ+58gSaUs VLuFUjV8ZSC+ownd3MZZR3Os9zAnQJGcknB8GX+n2sfRM5eDHQvWiN5zYDU4JryGP+hI 8yVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=cxXWSmNhCNW/OXK7DP6Jnp8axx3k5VLR/sBU6Vx39zs=; fh=y/P4oWnbxQSD4zINfwr2oELzCbXCmPkmWEJqXs1Yty4=; b=y0JNVwrWA7OlxOHzgzPo2kiTLcCAGbicjHcZFDhwHst0sEWe6cDX2ZrW0nXXV6JsQK N0ddKhn5fXB0bYG3jfV1gFKOIl0dIcS2YOn/NEHazSmHrvrm1W1g4NfNaR79arpp4bQ+ rFzZiWj4/ivW8+BVj6mKpKtw7NsQInIg4vfnCs9feoqrwInGrGq3kNv4tJvFeEf1BdNO AwblGwngDA1xEjR+ht7X3jPMtm30VtMLMMpcgPQMEl1UHKvzm/8m2Rk1n8jM6mD6X3/f bLrkGZoDB/yIjGEAQgtx2zrSAZ4O9Z94Fml8q5W3Wg2ecvY73A/0pZ4FcNTi4GwkyflT oIUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=DgtfU2Sb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id s196-20020a6377cd000000b005702c84e4c2si2645092pgc.508.2023.10.12.10.38.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Oct 2023 10:38:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=DgtfU2Sb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 74B15825CD08; Thu, 12 Oct 2023 10:38:17 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379647AbjJLRhy (ORCPT + 99 others); Thu, 12 Oct 2023 13:37:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347447AbjJLRhi (ORCPT ); Thu, 12 Oct 2023 13:37:38 -0400 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E6AEC6 for ; Thu, 12 Oct 2023 10:34:29 -0700 (PDT) Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-5859b2eaa55so914049a12.1 for ; Thu, 12 Oct 2023 10:34:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697132069; x=1697736869; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=cxXWSmNhCNW/OXK7DP6Jnp8axx3k5VLR/sBU6Vx39zs=; b=DgtfU2SbYgoU7i+9cXMQFl3xqZskhwp9SyC4j9CL7pRhGxwO/hfM3yKxm7g2aheNBc +XnZHP85HatTLGuRm9jWa75G0/NDP17JNRKMtDRz8Wf8l2UBGwuPq9Z3aRwTRW6T7NHh FfErH2Fi+f5yfcgj++hMu833Abw1Ba1ooxm+8yNIB/W+EjQ7NZki3os5Y7d5SIRnmS28 dm08VHh7Fon0ni1A+sRJsFyWEHh4rtDU8CdEWgJLBpLPvAtQDZlyCBI+c1qFY2I+cC8I ZxSwW6PTnORtlTe1a3BB4qfO6i2CqPy9ujrRaGvzngI7pwo/YjL5c3zTnQABwhZQNs1j iZVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697132069; x=1697736869; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cxXWSmNhCNW/OXK7DP6Jnp8axx3k5VLR/sBU6Vx39zs=; b=hb2oy3Lua/RmCvo+YVMSw1LO11ZSDtG19ABvsPYwjAf329ZCR8BIBGjfE/S5iSa0w3 VV1jFeQUOnV5RA1RvY21M18KlC00e0ORd1BDbHmLHWlR5dToFU67yvMZ6wt2JooTFzgp vuGVyo4TeF58ynvcWLPlmtq7v+wLG+Es1Ky6lXj5qiJgm8KPHCnf6T1fz5qPpARDovTy 6WN7YRs6D+vBf5rdiiOHSay9oRblk4O6aM2IS5BS/3LkOvjSbSEovUVzngP5HkQtJk5z yE/ZtVfTAORefJ6zd80RMWpZr4h3UbIvJV89sKGNyTpkgTXcS7kRvjh/Q2ClrtBrIP4L FQkA== X-Gm-Message-State: AOJu0YxBF6wZebqJIHTFJQ7JJBuIn3e5T1jgZgyISjALjcIPAE6/Sd2O +kMlfjLMIA9ICjxw3w86+PWa/HoyA/8OVQ== X-Received: by 2002:a17:902:7248:b0:1bc:10cf:50d8 with SMTP id c8-20020a170902724800b001bc10cf50d8mr21926466pll.23.1697132068645; Thu, 12 Oct 2023 10:34:28 -0700 (PDT) Received: from localhost (dhcp-72-235-13-41.hawaiiantel.net. [72.235.13.41]) by smtp.gmail.com with ESMTPSA id l10-20020a17090270ca00b001c59f23a3fesm2230912plt.251.2023.10.12.10.34.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Oct 2023 10:34:28 -0700 (PDT) Sender: Tejun Heo Date: Thu, 12 Oct 2023 07:34:27 -1000 From: Tejun Heo To: Zqiang Cc: jiangshanlai@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] workqueue: Use the kmem_cache_free() instead of kfree() to release pwq Message-ID: References: <20231011082759.8570-1-qiang.zhang1211@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231011082759.8570-1-qiang.zhang1211@gmail.com> X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 12 Oct 2023 10:38:17 -0700 (PDT) On Wed, Oct 11, 2023 at 04:27:59PM +0800, Zqiang wrote: > Currently, the kfree() be used for pwq objects allocated with > kmem_cache_alloc() in alloc_and_link_pwqs(), this isn't wrong. > but usually, use "trace_kmem_cache_alloc/trace_kmem_cache_free" > to track memory allocation and free. this commit therefore use > kmem_cache_free() instead of kfree() in alloc_and_link_pwqs() > and also consistent with release of the pwq in rcu_free_pwq(). > > Signed-off-by: Zqiang Applied to wq/for-6.6-fixes. Thanks. -- tejun