Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp480115rdg; Thu, 12 Oct 2023 11:01:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFQwGa4wdbMyCx1U3knKVbzKExw9TKAH/u+yvgnLxVts/x3Yjy+ChnIOIXTQWTlN2v0yDNu X-Received: by 2002:a17:902:8694:b0:1c9:c968:4ce with SMTP id g20-20020a170902869400b001c9c96804cemr5288742plo.33.1697133709549; Thu, 12 Oct 2023 11:01:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697133709; cv=none; d=google.com; s=arc-20160816; b=kqo7kMgmz8ldAQefb5Mz05IKyi3IyyM5HuzOlM53YzXG3qg+q/m+5shIwtMDNorq1v ydYu1ikUXf1fNk5nv7FA+kE0klDcK9/+p/kuSicsbaQmnAb/z5RaEKr7yJ/CDyqpUfGo TeiIHnsHBTpB2LjafagvDn6zkK4lIcQSjERbNmYhNMLEC7aF7h+6Fc4erorMiukqz+0u MjHHz3KPcY49PFTo0RTLCN3WosVONpFbTWdSQq7dX4nHb+EV04NkSmLjy6KLOuaHb3OZ ml3elKBZS/6q/njHTalimba5EKWKacOZCybhYZKWxWBs3yihREwyYcz6oKXGi4AqNR6R M7lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=lhDHgOY1Yo3YxjwD33tzfkA7vfJqFm9vhovYUzG8JyI=; fh=1bEoSeKlOGurhvnSi2pzdW2AZoMRq2idIHm15GAQso0=; b=tY6IV5qOO+JmX1UmBoZZF8sodt9ngTp+MD/uZZmMrcI5Szi+9RuWgHqC4Y1CqykqQL z43zfT6yu+IBHaFwIjqZ3Va02IJ+mVBkONNHXl6aT2dAGj1egztbMtxATpcgtOVpSTDt dN0oJzjT5TAWcxYme4m35nWMHHrfzhZdgfANxKGEedaWMJQg7vGwXSzjcJU6iL1xU3zP Zo+8l0qMfiJZq8Mi5fqb+kO0XlhZrfErSjr8y4OPXtFX4NOMRsun3mDht7b+mZrzjtBY 0/QhnpAD+Kw74SvK1baUWlgCa5J2+UH/j/McctHLRjVJzPAoVO+ZDRctQT1xYeGq84+l 6SGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=DMuRQoiK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id u12-20020a170902e5cc00b001c9d690baa4si2978195plf.532.2023.10.12.11.01.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Oct 2023 11:01:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=DMuRQoiK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 353078067B56; Thu, 12 Oct 2023 11:01:47 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442037AbjJLSBR (ORCPT + 99 others); Thu, 12 Oct 2023 14:01:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1442006AbjJLSBP (ORCPT ); Thu, 12 Oct 2023 14:01:15 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 005C9DA; Thu, 12 Oct 2023 11:01:13 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9FF0C433C9; Thu, 12 Oct 2023 18:01:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1697133673; bh=QFecizGKt2XzydnEGdzznTEe7ougz7DAeR8j0nzXygc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DMuRQoiK6bHpZsT8I6pivOrbIDkfr9gWP+8JAK3rIodq8z9/Heo6IiNsWLp9HviUb JMYnED3NQGeDdTnzmnlOoUfZtqC1iql2IIEmRmc81GEB2opteuiSteNxv12YmQK5Ik RBnqKOop9/SeZiW/eNpQyHtLAoeULgKiK7mJEJpw= From: Greg Kroah-Hartman To: stable@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Andrew Donnellan , Alexander Potapenko , Xiaoke Wang , Andrew Morton Subject: [PATCH 6.1 6/6] lib/test_meminit: fix off-by-one error in test_pages() Date: Thu, 12 Oct 2023 20:00:48 +0200 Message-ID: <20231012180030.279678796@linuxfoundation.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231012180030.112560642@linuxfoundation.org> References: <20231012180030.112560642@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 12 Oct 2023 11:01:47 -0700 (PDT) 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Greg Kroah-Hartman commit efb78fa86e95 ("lib/test_meminit: allocate pages up to order MAX_ORDER") works great in kernels 6.4 and newer thanks to commit 23baf831a32c ("mm, treewide: redefine MAX_ORDER sanely"), but for older kernels, the loop is off by one, which causes crashes when the test runs. Fix this up by changing "<= MAX_ORDER" "< MAX_ORDER" to allow the test to work properly for older kernel branches. Fixes: 421855d0d24d ("lib/test_meminit: allocate pages up to order MAX_ORDER") Cc: Andrew Donnellan Cc: Alexander Potapenko Cc: Xiaoke Wang Cc: Cc: Andrew Morton Signed-off-by: Greg Kroah-Hartman --- lib/test_meminit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/lib/test_meminit.c +++ b/lib/test_meminit.c @@ -93,7 +93,7 @@ static int __init test_pages(int *total_ int failures = 0, num_tests = 0; int i; - for (i = 0; i <= MAX_ORDER; i++) + for (i = 0; i < MAX_ORDER; i++) num_tests += do_alloc_pages_order(i, &failures); REPORT_FAILURES_IN_FN();