Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <f7daa9a7-6f74-44ef-80fc-d0ea013902f8@amd.com>
Date:   Thu, 12 Oct 2023 13:28:24 -0500
User-Agent: Mozilla Thunderbird
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v12 04/10] x86/resctrl: Add comments on RFTYPE flags
 hierarchy
Content-Language: en-US
To:     Reinette Chatre <reinette.chatre@intel.com>, corbet@lwn.net,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de
Cc:     fenghua.yu@intel.com, dave.hansen@linux.intel.com, x86@kernel.org,
        hpa@zytor.com, paulmck@kernel.org, akpm@linux-foundation.org,
        quic_neeraju@quicinc.com, rdunlap@infradead.org,
        damien.lemoal@opensource.wdc.com, songmuchun@bytedance.com,
        peterz@infradead.org, jpoimboe@kernel.org, pbonzini@redhat.com,
        chang.seok.bae@intel.com, pawan.kumar.gupta@linux.intel.com,
        jmattson@google.com, daniel.sneddon@linux.intel.com,
        sandipan.das@amd.com, tony.luck@intel.com, james.morse@arm.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        bagasdotme@gmail.com, eranian@google.com,
        christophe.leroy@csgroup.eu, jarkko@kernel.org,
        adrian.hunter@intel.com, quic_jiles@quicinc.com,
        peternewman@google.com
References: <20231010233335.998475-1-babu.moger@amd.com>
 <20231010233335.998475-5-babu.moger@amd.com>
 <71539687-13cf-405d-bf7c-27480e49e872@intel.com>
 <fa03a5ca-fb16-47bb-a2c8-5cc4d96e54a9@amd.com>
 <a02c0f3b-2258-425f-94e4-a76739a24f00@intel.com>
From:   "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <a02c0f3b-2258-425f-94e4-a76739a24f00@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eVE5MXplejhia1JpbENEblZvZGc1ZktxbjhOMFlUQnZoUzdZTjAyVTJWUXZn?=
 =?utf-8?B?WmZQY0xCSzB4SFJ0am1vbWVvRlVQNmhDcDJEbFErRWpFaFU0azdSL2RwS0lW?=
 =?utf-8?B?YVNoMzR2Y3ZzZ0hkc056RTJKVXJrQU1RSndPVnc2RHEvcHZJN01YSGFOYnV5?=
 =?utf-8?B?aHZRa3owcmlydGxvREh4dW1NWDM2bGRuZTM1Rkp1T0gwOTFiT2gvcFZJYkI3?=
 =?utf-8?B?ZGY5L0xQNS9yZ3FLaFdlL205YnBkL0hIb0dZTmRVSEk5bDlQQ2kyM2FjaTAy?=
 =?utf-8?B?WUpMUWFYblBHOWhKWlp6M2cvV0dQTG5sMmRPM280RWpTZHlnT2RkRzF3RkYz?=
 =?utf-8?B?QmkzUlA0N0FycEpaZ2szR3dFS2lneXhaUWkzQlA4c0R5UDQrbWp6Q0E2L2dl?=
 =?utf-8?B?VHhaY1dzYTQyRy9Od0Q4NGZGcEZMM29COTJYVWlZVDN3Z2JCVGxVZXJpVzZR?=
 =?utf-8?B?OUJqQlJFY3laN2dIU3hSbWovbFY4VlVOKzZ1dTdsYVhUMk1SSExQZElFRmNv?=
 =?utf-8?B?V3QyVFFzNS9JclBQQ0Vuc0d3WXpFWWFOZFYya2U0a3AvUGE0Y0VYMldGRWwz?=
 =?utf-8?B?dlNrVUxpS00xNjlMVy9WNDZraUo4RmJ3U1paVk1UZWMweWt0Q1h4UXBWMzRo?=
 =?utf-8?B?a0cyaGw4aGowbitBRFRITlRXZ0krOEJseWg4RnlyaDJEbHdUVm8rYVFmMXYz?=
 =?utf-8?B?bGdFSDRTOEUvV1hsdGNxWksxcWE5YW5wZVhKQ3hteW11S1RsRWZ6bGU2Um5G?=
 =?utf-8?B?VGJmVjhvSTFUWnJyVzdtM2FCR0JDK1h0L0VYUEU1RStwdnNqMmpVNk9KT20w?=
 =?utf-8?B?U2NLOHQ3dzNCbTFSMFVxSzlLd2NsUVVWK25mYXZ1NzVKWFJrR1k2YnYyK29Z?=
 =?utf-8?B?MnRIbTZmRmZkMzc0TnRzWDF1T2YxNDlCaUFrUmptaDRBbk5nUUhNVnE2bHlp?=
 =?utf-8?B?amxjaE54cTh4SnpwQ0lFQ3RHcWhNY0J4eHVWL2VQZllBc0pYRUtETW1FNkho?=
 =?utf-8?B?ck9CbStsemZKWlkrdCtmeFQ3YnNiVzlDRmFNdUJaeUNkelFtYXBZZFpLS2sz?=
 =?utf-8?B?RHd3cUhCdnRFcmp4bStNdWZzbDQ3VWV5T1dxNW5GeVJ3NGlvV01qOGlQZG5D?=
 =?utf-8?B?YUZsVGxZVzVIcXlpT3dvc1A0ZG1ZUStkU2tZRHJRZmNLWGJYbkd1U3JNbHJM?=
 =?utf-8?B?TUk1SW5ZNmQ4aWpVd3Z6SWJoV1NHL2Qzc0d6M05yNVBiVHJjUHVhYXpTQjZo?=
 =?utf-8?B?bFU5d1JEdGMyalc5NDNxTll0VTBIWTMwVWpyNFZEYnZBRHZwSXRzcVIwaGhh?=
 =?utf-8?B?M3N6TER2Y1FJenJmVStuVUE5TXpaMTFzcmt6UktJMy9wVGhMbXhnb05YMmYr?=
 =?utf-8?B?dnp1UldJelFGQm5DRmV3ZHJqOHFNWGZnV3A0bzVXU3pOK1pDVG4wRTRiL1pp?=
 =?utf-8?B?NUs3YkwrdXNpUU5RdGxIN1FqVG9VZUJhdVNJUlVoYVpuUjhTQkpiZzgwbWZs?=
 =?utf-8?B?eVFhK2hYOWJaaDg5ancrOSt3bWc3WXYxSVJ1Mk92ak4xelBaTlZHaE84cmlV?=
 =?utf-8?B?bE5jdWJ1L0JJczlqM0I1eVBQRHhDOGt0UnI0bTBJL0lkbkRzbzROME1nK25T?=
 =?utf-8?B?cFlQdkNCWlJxT0VFYzBJK05hVGdIaEp5MFg5dlMzakZ3MlhoUWR1Qnp2N2pR?=
 =?utf-8?B?WUtuNThUVFBlTWdxOExIT3VxK0puWjFGS1VMeGpxNUdiL0Y5ZlMxTHZ1dWRz?=
 =?utf-8?B?NTM0WU9sOW5hOG8vT04vZlViTUV6M1dlL1JuTnF1bjFmbDlScUlCdmFFekF4?=
 =?utf-8?B?YWNTR1puZCt1U0FHZW9uM3FlUnNzblArZWxydDFuQWUvTlpNdDdRd1E2NUZ0?=
 =?utf-8?B?Q0ZJdXdLdVNCNVBoRjg2R3BuTThHcmFyRWJXeU03NUlia0s4REovWGtRS1Ex?=
 =?utf-8?B?YW5yblQ3eXR5emhMK25UVEowYmNZWTcwYmozT0xIWnB4SzZvTzh3NXdsVGp3?=
 =?utf-8?B?ZkVRUDkrRUsxTVJlQVVaU3NyY2k0dkxKa1BrY1FsM3dYay9BaGtYdFkwQVgr?=
 =?utf-8?B?dDV5NEs5NUFYSGlyZkl0QVo5cnJsQlV2WmViWXk3NXVsa0RNTFB0Y3BvUGJa?=
 =?utf-8?Q?GXjU=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 83c1a5be-cb10-427d-63fa-08dbcb5107c2
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2023 18:28:28.8082
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fzrW1KNFUMYiNRGAcstdBMCeQAjE1fgBXxKSejWythCvt4kDqtcZ0yjIe2iyGJ+T
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8419
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 12 Oct 2023 11:28:57 -0700 (PDT)

Hi Reinette,

On 10/12/23 11:01, Reinette Chatre wrote:
> Hi Babu,
> 
> On 10/11/2023 9:57 AM, Moger, Babu wrote:
>> Sure. Will remove Reviewed-by on this patch. Please let me know about
>> other patches when you get a chance.
> 
> From what I can tell, apart from moving the flags text to Documentation,
> there is only one other code related change and that is just moving the
> RFTYPE_MON_BASE definition to a later patch. That looks good to me.
> 
> The other changes are all in the commit messages and that mostly looks
> good to me ... some issues seemed to have slipped in during this version
> and I will point them out in responses to the individual patches.

Sure. Thanks
Babu Moger