Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <ffd40b3c-8f57-42ab-9fee-7475788f24ec@amd.com>
Date:   Thu, 12 Oct 2023 13:29:12 -0500
User-Agent: Mozilla Thunderbird
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v12 09/10] x86/resctrl: Add support for the files for MON
 groups only
Content-Language: en-US
To:     Reinette Chatre <reinette.chatre@intel.com>, corbet@lwn.net,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de
Cc:     fenghua.yu@intel.com, dave.hansen@linux.intel.com, x86@kernel.org,
        hpa@zytor.com, paulmck@kernel.org, akpm@linux-foundation.org,
        quic_neeraju@quicinc.com, rdunlap@infradead.org,
        damien.lemoal@opensource.wdc.com, songmuchun@bytedance.com,
        peterz@infradead.org, jpoimboe@kernel.org, pbonzini@redhat.com,
        chang.seok.bae@intel.com, pawan.kumar.gupta@linux.intel.com,
        jmattson@google.com, daniel.sneddon@linux.intel.com,
        sandipan.das@amd.com, tony.luck@intel.com, james.morse@arm.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        bagasdotme@gmail.com, eranian@google.com,
        christophe.leroy@csgroup.eu, jarkko@kernel.org,
        adrian.hunter@intel.com, quic_jiles@quicinc.com,
        peternewman@google.com
References: <20231010233335.998475-1-babu.moger@amd.com>
 <20231010233335.998475-10-babu.moger@amd.com>
 <28f089f4-992b-4331-81cb-100a1814fc56@intel.com>
From:   "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <28f089f4-992b-4331-81cb-100a1814fc56@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NkZXeElQVmFZVmVnbjgyclppQkhrb1RqYkFxUGdHZ3VzRVJQbGp2Wk1GNkdM?=
 =?utf-8?B?ZjljL0NWZ1hRSWd0bmdpYjBrTmoyMEtPclQzRGV2L1Bka293cW9DVlgvM1BY?=
 =?utf-8?B?S2l1elJkeTBxK2xXUGNlTXJBaHhRLzlabHo0S1hwdjlYNGN0K1NqaDBPN3Vw?=
 =?utf-8?B?d0ZJZ1VWd09rNGpMWGdON2NraUZST05RUnpObm9lT3Qrd1daM1B0NGlkM0Zn?=
 =?utf-8?B?dS9LaEd4MWdvcVlYYkdkVkVZZzI4TUl3NWFwN2NpemJyekVOdGNUSHg0U1ha?=
 =?utf-8?B?ZFBEVW1rVXhsWFZ5NE1sUUJUd3VXb1diVjJ5SU52bUs3UWNwNVZKWHFaNjlI?=
 =?utf-8?B?cjg1RFFDRSs5QjA1cnhuWkNEK3p3TEt4RW9sanRGT3orV3hKMHJRb0xocFVF?=
 =?utf-8?B?T1VqYi9aK3U3a1VyNEZtck9YK0NUbDBTdSswUW12N1lWR0NsaWtIaDBTcEh5?=
 =?utf-8?B?ZUpDaHNJQTYvU1pCdTdRYVJwVDU0SjNTYlpQUHcwb1diemJabjRlOU80MHJv?=
 =?utf-8?B?bllBbXlPOWpQbGpKSExja1gwczhnWjEwSXl3aUFyYWlLMjFqOFJWMjg3MzY2?=
 =?utf-8?B?dG5wOXpmRWN1M0liUzdWVG45UDNpbmNVTGVVMmZZdjBteW1yZVJGZmZZSTRH?=
 =?utf-8?B?aDFBNnE1L2pRM3RiUnA5YUNVdFhFa0RyNkNjd1RsWWZ4RnJTVEU5RjI1V2Yx?=
 =?utf-8?B?Qy85UXgrRWtEejAzSVM0WUlkWTBodVlEQllzbUgwWmNmN3dpUWlEQjhURUFX?=
 =?utf-8?B?Wjl1Z0xxUGRBa1AraVRMaHN2K0gxREJzcjdNR1c2blVsd3JwTnNDVXZFeVdS?=
 =?utf-8?B?RDVYdGdDaWJONDZDRXIvaDk5NnlmZU9TMVBXdFNQeDhLWmlrUVNRRWNMZi9P?=
 =?utf-8?B?SFJXVzVmT242SmFESElIOTg2cXd6b2wvSTZ5WHJpRDdwaDdIR1d3NitBeVdD?=
 =?utf-8?B?RnFwcGVjYkEya3pKbzViWk56Tk4xUzkxa3pkRjhpelFsV2ZHZFRBd0ZaU2lO?=
 =?utf-8?B?cCs1RHFHZEExOWlLd2FudGNKSjR0SVNlajZhUkU5akR5bTd4eXBFaDd4YlNv?=
 =?utf-8?B?Z2x1TGpxVnZXQUdxRUh4bXJRNktmeEQ4VmYvVlVvMHZwQi91ZXJaNjJJdWts?=
 =?utf-8?B?UG1Za0lSUG9paW81VWFYTFdKN0NkQVRmSmNPQjZJc0N4K2kyV1VOeGRGN084?=
 =?utf-8?B?UGlPaHVhL1g3UzFob2FCTU9wVG80aTdiNkpNbmtHdUE5QXVlazMwVml2NXJ1?=
 =?utf-8?B?RjYvbm5jUUdOc05oeThrdnZSTUIwQkMxV0pYSDd6ZXlXZXhFU3M1VHlrS005?=
 =?utf-8?B?RDh5OEVOOHVMN1NadXpJMTQ5ZE5ncDZlZTRuVW90TXZ1eUhxTXZaR0lLYUlu?=
 =?utf-8?B?Ym43Zno3a0tjN3lzNlVBa092aU1UWGJMbUxrVE96RzhOaHBORXRjME1NK1Yr?=
 =?utf-8?B?c2lwOTNNMlpjSFN6Rm9PR2h2VG1HcStoTnRjZlIrMUhZdk5NeEN3YWZodUxi?=
 =?utf-8?B?eU5HL1g5Q05uV2dBTXlJaTRmdjY2TEZDZVpaSmdlZThqRXBaKzZ0Vk96cTBx?=
 =?utf-8?B?U2MrYmdqSEQ0WFJwZjk1THdlMlYrMVBYNmZ5UFpvRWhaN0ZIamFzL1A4elZR?=
 =?utf-8?B?UnNOMTRPL2wzOFZaOGVxa0RacTdNOE12WFliM2JocFZEN1VPNDNjdjJDcDlu?=
 =?utf-8?B?K1pBakhUM2pSSWRFTU5VdWZ6cWtKaUpjLytpWWZsQUJWWU85SVpiSllJdENp?=
 =?utf-8?B?amRFdzJxZ25RcGtKWnFobHNhclZTbUlVVXdXVlFUeVBtbWRPM05pSHlqeDVs?=
 =?utf-8?B?VFJuYngyM1dkZlF3dmdkTEp1VXAxdXlEcW1IN0xSem5NdnJMZVNxZXFkaXVL?=
 =?utf-8?B?RUd6VVB3eVFraythOVBkM3pkRXQvUFVIdkJjSTJuL3JEK3hiTzNKOGw0cDha?=
 =?utf-8?B?Yy9WRlg1RE9hZEZpMjk3L2QvN1VCM3R4N0V1VEhrWTF6SFRHdnpZRlBsWUNM?=
 =?utf-8?B?aDFyL2JOMmlaaHlLdVdRUWJqRENZcGFCQWNoN0kvVGRtK0tWTXg4U1YydEYr?=
 =?utf-8?B?SHdyK1RackdudmlsWW0vazNVSmd3TDlQQnJJUUtEdWZwWTBrYkRkR0FDTWFT?=
 =?utf-8?Q?07bc=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c20d8527-2029-4608-6c7a-08dbcb512359
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2023 18:29:15.0714
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KO+Wr7AVhUAJucfiuMJlLB4zW3y9Yn2sNxyyiGfSnrd9mJ+TM+1V2/4VAJX0YhIK
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8419
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 12 Oct 2023 11:29:32 -0700 (PDT)

Hi Reinette,

On 10/12/23 11:02, Reinette Chatre wrote:
> Hi Babu,
> 
> On 10/10/2023 4:33 PM, Babu Moger wrote:
>> Files unique to monitoring groups have the RFTYPE_MON flag. When a new
>> monitoring group is created the resctrl files with flags RFTYPE_BASE
>> (files common to all resource groups) and RFTYPE_MON (files unique to
>> monitoring groups) are created to support interacting with the new
>> monitoring group.
>>
>> A resource group can support both monitoring and control, also termed
>> a CTRL_MON resource group. CTRL_MON groups should get both monitoring
>> and control resctrl files but that is not the case. Only the
>> RFTYPE_BASE and RFTYPE_CTRL files are created for CTRL_MON groups.
> 
> There can be an empty line here to make this easier to read since that would
> separate the problem from the solution.

Sure.
> 
>> Ensure that files with the RFTYPE_MON flag are created for CTRL_MON groups.
>>
>> Signed-off-by: Babu Moger <babu.moger@amd.com>
>> Tested-by: Peter Newman <peternewman@google.com>
>> Reviewed-by: Peter Newman <peternewman@google.com>
>> Tested-by: Tan Shaopeng <tan.shaopeng@jp.fujitsu.com>
>> Reviewed-by: Tan Shaopeng <tan.shaopeng@jp.fujitsu.com>
>> Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>
>> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
>> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
>> --
> 
> Missing a "-" that will make the patch description not be as intended.

Sure.
-- 
Thanks
Babu Moger