Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
MIME-Version: 1.0
References: <20231009190538.2488792-1-srinivas.pandruvada@linux.intel.com>
In-Reply-To: <20231009190538.2488792-1-srinivas.pandruvada@linux.intel.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Thu, 12 Oct 2023 21:14:33 +0200
Message-ID: <CAJZ5v0jH9ZYxvK6MxXXb-RggzwtPie9dhpfmUBduyc2P9rczEg@mail.gmail.com>
Subject: Re: [PATCH v2 0/7] thermal: processor_thermal: Power floor status
To:     Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc:     daniel.lezcano@linaro.org, rafael@kernel.org, rui.zhang@intel.com,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Mon, Oct 9, 2023 at 9:06 PM Srinivas Pandruvada
<srinivas.pandruvada@linux.intel.com> wrote:
>
> Support power floor notifications for Meteor Lake processors.
>
> The first three changes is to prepare for power floor status and others
> add support for power floor.
>
> v2
> - Use common define for offset
> - Fix potential race during clearing of interrupt with workload hint
> - Address comment for v1 for
> thermal: int340x: processor_thermal: Support power floor notifications
>
> Srinivas Pandruvada (7):
>   thermal: int340x: processor_thermal: Move interrupt status MMIO offset
>     to common header
>   thermal: int340x: processor_thermal: Common function to clear SOC
>     interrupt
>   thermal: int340x: processor_thermal: Set feature mask before
>     proc_thermal_add
>   thermal: int340x: processor_thermal: Support power floor notifications
>   thermal: int340x: processor_thermal: Handle power floor interrupts
>   thermal: int340x: processor_thermal: Enable power floor support
>   selftests/thermel/intel: Add test to read power floor status
>
>  .../driver-api/thermal/intel_dptf.rst         |   8 ++
>  .../thermal/intel/int340x_thermal/Makefile    |   1 +
>  .../processor_thermal_device.c                |  68 +++++++++-
>  .../processor_thermal_device.h                |  11 ++
>  .../processor_thermal_device_pci.c            |  43 ++++--
>  .../processor_thermal_power_floor.c           | 126 ++++++++++++++++++
>  .../processor_thermal_wt_hint.c               |   3 -
>  tools/testing/selftests/Makefile              |   1 +
>  .../thermal/intel/power_floor/Makefile        |  12 ++
>  .../intel/power_floor/power_floor_test.c      | 108 +++++++++++++++
>  10 files changed, 365 insertions(+), 16 deletions(-)
>  create mode 100644 drivers/thermal/intel/int340x_thermal/processor_thermal_power_floor.c
>  create mode 100644 tools/testing/selftests/thermal/intel/power_floor/Makefile
>  create mode 100644 tools/testing/selftests/thermal/intel/power_floor/power_floor_test.c
>
> --

Whole series queued up as 6.7 material.

I've edited a couple of changelogs to clarify them a bit and changed
the documentation of the new sysfs attributes somewhat, so they don't
talk about RAPL directly, because I think that the key point here is
that if the power floor is signaled, the configuration of the system
needs to be changed in order to reduce power below the current level.