Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
MIME-Version: 1.0
References: <20230930144958.46051-1-wedsonaf@gmail.com> <5122b6b6-12d5-0337-0c04-3e30da1f3898@proton.me>
In-Reply-To: <5122b6b6-12d5-0337-0c04-3e30da1f3898@proton.me>
From:   Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Date:   Thu, 12 Oct 2023 23:00:09 +0200
Message-ID: <CANiq72n=y7GtYEEF3042-JLhcpLMAk2ammh2DGkO+1ELXBc=NA@mail.gmail.com>
Subject: Re: [PATCH] rust: error: fix the description for `ECHILD`
To:     Benno Lossin <benno.lossin@proton.me>
Cc:     Wedson Almeida Filho <wedsonaf@gmail.com>,
        rust-for-linux@vger.kernel.org, Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>,
        =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>,
        Andreas Hindborg <a.hindborg@samsung.com>,
        Alice Ryhl <aliceryhl@google.com>,
        linux-kernel@vger.kernel.org,
        Wedson Almeida Filho <walmeida@microsoft.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Oct 9, 2023 at 4:54=E2=80=AFPM Benno Lossin <benno.lossin@proton.me=
> wrote:
>
> Strictly speaking, `errno-base.h` documents this as "No child
> processes" (note the plural), but I am fine with taking it as-is.

Good catch.

POSIX seems to use both (General Information vs. `<errno.h>`), so
perhaps that is where Wedson picked it from.

Given the kernel uses the plural, and that the commit message says it
mimics `errno-base.h`, I have amended it.

Cheers,
Miguel

1:  77983c791960 ! 1:  17bfcd6a8153 rust: error: fix the description
for `ECHILD`
    @@ Commit message
         Fixes: 266def2a0f5b ("rust: error: add codes from `errno-base.h`")
         Cc: stable@vger.kernel.org
         Link: https://lore.kernel.org/r/20230930144958.46051-1-wedsonaf@gm=
ail.com
    +    [ Use the plural, as noticed by Benno. ]
         Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

      ## rust/kernel/error.rs ##
    @@ rust/kernel/error.rs: macro_rules! declare_err {
          declare_err!(ENOEXEC, "Exec format error.");
          declare_err!(EBADF, "Bad file number.");
     -    declare_err!(ECHILD, "Exec format error.");
    -+    declare_err!(ECHILD, "No child process.");
    ++    declare_err!(ECHILD, "No child processes.");
          declare_err!(EAGAIN, "Try again.");
          declare_err!(ENOMEM, "Out of memory.");
          declare_err!(EACCES, "Permission denied.");