Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Thu, 12 Oct 2023 16:26:05 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
        <linux-efi@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Ard Biesheuvel <ardb@kernel.org>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Ira Weiny" <ira.weiny@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Yazen Ghannam <yazen.ghannam@amd.com>,
        Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
Subject: RE: [PATCH 1/3] efi/cper, cxl: Decode CXL Component Events General
 Media Event Record
Message-ID: <6528808cef2ba_780ef294c5@dwillia2-xfh.jf.intel.com.notmuch>
References: <20231012230301.58500-1-Smita.KoralahalliChannabasappa@amd.com>
 <20231012230301.58500-2-Smita.KoralahalliChannabasappa@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231012230301.58500-2-Smita.KoralahalliChannabasappa@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MSTPaijI5l4KaiuxInNyb/0zSFoBJthBK7orMHof2NK6Mvh61l84N/k7oaYH?=
 =?us-ascii?Q?4gIGtxziSNV7HOT7R/y4xlWlFn/Ulx0fz7o6J46LxM1dot53PA3DsTaFFpKK?=
 =?us-ascii?Q?bpuhlkLCKw608hsozwegmp4puDIAC9xpC2AzfuSdMYSk0/+b/8Snk7OC/ntS?=
 =?us-ascii?Q?kSs03I3jUNw8Gdi02PQPA4JyF4f5hmHNzZzELCPskHq8XpzJ1cmVAE0NwXxZ?=
 =?us-ascii?Q?nz5S+5iqzG/nqGXnCcNeJ+3KxLEzksmD+3+o0XKklP0ALiz7EXALgxRguHEP?=
 =?us-ascii?Q?+nROqV/N8dOcrd6Cqsm0RUQY7QO1JtAF4b01UpzZ/04ZR0GfE+80kOQC2/nv?=
 =?us-ascii?Q?aavAcV3Fr3SNtREDE29eo2rf3pqN399J9/+tnW+CMOypRTgRCWx+YFxSrD2x?=
 =?us-ascii?Q?76/z8j6q7xGiJPotqQTPci+LfR7/CyDBRxTjz/FsLl2GwxIEPBR6QTA5xi09?=
 =?us-ascii?Q?5av0L1UDj5RZ/onQTCyrS0V1iemIQopisjV9cVRpBH5DbZmxhslUBRarK1GD?=
 =?us-ascii?Q?QWAx8Rj53GV1AJfmFXHJPdK24xpJY/O8w3jZyaKhfb+haVowJg2recj2CmJQ?=
 =?us-ascii?Q?oL2iY0ZWYAj/vF5/TyGpxh+Fi5iyYsAETEnip3940x7tFDtYtKSbEh4cdJnQ?=
 =?us-ascii?Q?oha/WUr4oK7jLmjHt9p7aIq5XdBrA5fkcqQ7zngVnRhdtGrIaMIG+OeQs5t0?=
 =?us-ascii?Q?hK9uh2raKBAl2Y1OfXDcjDkf1tcgfZjucD5/Wu/Ed2IUFTSqxyzqWRxRU52F?=
 =?us-ascii?Q?ONDr4+MTERx8wze9PkmO0LSm/Fj+80Za0JRnFttR0gMXzhCxqe9AiwNfU8dQ?=
 =?us-ascii?Q?AlJfVXTNZQxvaCVIpiUeoLDSyP7ht9/WTBwGOz9Qhcx9GazQzGISe53uFbFv?=
 =?us-ascii?Q?ODivLnD8Nb2zQ7p3vudhxCzxb2AJXXM3IwgGdFAU7mm8VOVNBaD9+cM1xt34?=
 =?us-ascii?Q?KA9lq86nA860CmHOb0H1daiL8WBbOF4bo97g6mABH26/3HOSSBDGk/RJk2zp?=
 =?us-ascii?Q?54786+yaiXttitB6jqed8Spuxhwp1wtSmiPMqxAI6RewmZMeWB+7Pfk5DSZY?=
 =?us-ascii?Q?m9HcdOEv4nISePFmzWCCHTVdkXcp1GkL2+9BPwBVeV/Ko3VF5YRnbowCD/aL?=
 =?us-ascii?Q?wb1FFYB3qUILKtBHOudbfZc2DL5p32xUjrl7JjsYSgFzTMoeAzi+W5Rs3pYs?=
 =?us-ascii?Q?5oyWJknWqnxss6qntxXZIOjdC4788Ua/WvYA7gGFjF36QZetDrfT8RnTDjwQ?=
 =?us-ascii?Q?cDLuS6m1aWUm9PrDERgA0ecV+dQ0Al0DDIFHqzsHRfr/JZs0Z9McNOtFwGKd?=
 =?us-ascii?Q?coscsAebx0xm9JI7U88aoR4Y1zyYW07vbs7T34MXgWYzLJ9OElnGA8v2/wr/?=
 =?us-ascii?Q?0zMi8N4qCuoou/8Kao4DobPajTpc+tJs3ApnU3yFdxPzpp5WisljZzJyuwlP?=
 =?us-ascii?Q?HNFKRo1e0lIMZvjS6nPkHOYMYfzL+hrxMNADoo1cIlSS/vEB6hsDbZIpUlZ/?=
 =?us-ascii?Q?o4ZYeF8pBtDaT5tNozcobojZBqD0CnzFowoq5mOgDCPXAkNTk5rTBUmGYvkG?=
 =?us-ascii?Q?K3XM2k1+BJtpwZhFpJbB7TXd51zTqAzVXDsxQhTa5ZjzgyOLC/0fn6WMLmgR?=
 =?us-ascii?Q?ug=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 505b3a88-80c2-4589-fe76-08dbcb7a9d0e
X-MS-Exchange-CrossTenant-AuthSource: SA3PR11MB8118.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2023 23:26:08.5844
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: N8cUeGJloYph9GLEDe2lD3ikMVWcwISWq1JJT5OfUBacPLtieYpZz3ybmSYWdAjoBNiy1xkDDqCrFKnK4OICfYm054vwPZJgJgDA195mvEY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5893
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 12 Oct 2023 16:26:38 -0700 (PDT)

Smita Koralahalli wrote:
> Add support for decoding CXL Component Events General Media Event Record
> as defined in CXL rev 3.0 section 8.2.9.2.1.1.
> 
> All the event records as defined in Event Record Identifier field of the
> Common Event Record Format in CXL rev 3.0 section 8.2.9.2.1 follow the
> CPER format for representing the hardware errors if reported by a
> platform.
> 
> According to the CPER format, each event record including the General
> Media is logged as a CXL Component Event as defined in UEFI 2.10
> Section N.2.14 and is identified by a UUID as defined by Event Record
> Identifier field in Common Event Record Format of CXL rev 3.0 section
> 8.2.9.2.1. CXL Component Event Log field in Component Events Section
> corresponds to the component/event specified by the section type UUID.
> 
> Add support for decoding CXL Component Events as defined in UEFI 2.10
> Section N.2.14 and decoding Common Event Record as defined in CXL rev 3.0
> section 8.2.9.2.1.

So I think this is missing the rationale for the code duplication.

Specifically, who is the consumer of this parsing relative to who is the
consumer of the event records emitted by the CXL subsystem. Given the
CXL subsystem event parsing already exists, and unlike this
implementation can support DPA-to-HPA translation, why should Linux
carry 2 emitters for what is effectively the same data?

What I would like to see is the CPER code post these record payloads on
a notifier chain for the CXL subsystem to parse, annotate with extra CXL
subsystem information, and emit from one control point.

Otherwise if folks would like to see this printk() version of the error
records then they also need to answer why the CXL subsystem should not
also emit decoder error logs to printk?