Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp637988rdg; Thu, 12 Oct 2023 17:02:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGsXVYhr/JtAMkx91VPb6XV3+fn2MWSrotW+Klj8ZeY4iRRitl0kkaROLMxwoLtYH+2ZKiA X-Received: by 2002:a92:c7d1:0:b0:357:47a3:adb8 with SMTP id g17-20020a92c7d1000000b0035747a3adb8mr7344233ilk.29.1697155328273; Thu, 12 Oct 2023 17:02:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697155328; cv=none; d=google.com; s=arc-20160816; b=cclWW0Gv7giUARTpJY3potz9Jt/z0eNqS87WoSaIQpZ9X2S61FC0pWdjsKp0fPXvur 72vU0eLd6iP2S1b/XvZ+OdJckTvtQOy5E4lD6J7IVFgaG202s4mqgB1sfb7R4ZdXZTOE UemDcgT5DhUADTgCTfgEdrqfAC7WPIepCLRff4C6nlpxYkYoh/sCfZ1VYDPmSrnq+J7I jctU7fe+Jf1pStJlAy8m//AjcAtd7+yRu3h18kiJli8RAjRhDhLRyyvlIXNOk7u6yT2P spFv4+dYuiHOHb6GcUIUhxws9TfR15qMA+fAZv+x2YRfEyeol7QXRfXfXpTY9C4vblbq pDYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=Ha5S911H5ryYsiwYz0UJplTypjEmV4oV7kNBO0ZqmXA=; fh=CWspvewZlAmXeAeLchwibq2eS4Le4I0vkHzBig4bdc0=; b=kJtGBFbfE+4LtJgDEcA2YLfofvZszxjXatElNC/0S+Nqhqb2FXUQLa231LezArGhtB HAgj0sY4Go/aZvC+nDI/vvDZiW5BzqKi5e0PhH1zqLrVX4e1PXGV2WK6Zcmf/F5oJJh5 N6Ly4VOk3dT5cxjBZdXBJGYjOI5v3Ky3lAylpgRDf3KgJYviEv+ioj1Sc+RlIHi1b1XJ sy/2McCL23H8sGdDv7d3aEJ98PBCd+4ZvVqOo46xE3k/6Okl/ahJ6MzHHXrLPqt+UNMH rC+DIu84X3XG/Tute5+vxICMXQ4QnObUEjcR+0W+phnDAaS+3f8JQUcH1SGh3gZnt36X 2rlg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="iekErt/E"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id fc6-20020a056a002e0600b0068fcca7b3f7si643038pfb.2.2023.10.12.17.02.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Oct 2023 17:02:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="iekErt/E"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id A195F81EE38F; Thu, 12 Oct 2023 17:02:05 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231468AbjJMABu (ORCPT + 99 others); Thu, 12 Oct 2023 20:01:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbjJMABt (ORCPT ); Thu, 12 Oct 2023 20:01:49 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB016C0 for ; Thu, 12 Oct 2023 17:01:48 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4E53C433C7; Fri, 13 Oct 2023 00:01:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697155308; bh=Ha5S911H5ryYsiwYz0UJplTypjEmV4oV7kNBO0ZqmXA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iekErt/EtcnZMdtnt6ARmkStMpS+OHACro/dgSHLXxtVq+JUIJUwAgAZ2zxvaO8qa PAIuDp8eSG2pco4dZGwna6XKWb6aSOg0TdEUt6b9C4UcS1LRPuaY7riQxiQO61v6Nw VS41ScmoZNVfcNLlmlUCqthMumlGq4X7akbFujjJ7N3hmTSngD/xWMcM8X8BICJyUo /Ft8/Kmwq8HPPj2aKJdnTvscOSfWT6/Yg2eDTj0B4L5xPk+/PPop+IKh4SctkJHZHZ Ae9UeuSwwQ6Qc3FGPc29VULp1XC0PanRWcaKAuaaoM4KkDgwDgOwdNB4hvaJY1v14R 2DqQgCDqCrSZg== Date: Thu, 12 Oct 2023 17:01:47 -0700 From: Jakub Kicinski To: Shinas Rasheed Cc: , , , , , , , , , , Subject: Re: [net PATCH v2] octeon_ep: update BQL sent bytes before ringing doorbell Message-ID: <20231012170147.5c0e8148@kernel.org> In-Reply-To: <20231012101706.2291551-1-srasheed@marvell.com> References: <20231012101706.2291551-1-srasheed@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 12 Oct 2023 17:02:05 -0700 (PDT) On Thu, 12 Oct 2023 03:17:06 -0700 Shinas Rasheed wrote: > Sometimes Tx is completed immediately after doorbell is updated, which > causes Tx completion routing to update completion bytes before the > same packet bytes are updated in sent bytes in transmit function, hence > hitting BUG_ON() in dql_completed(). To avoid this, update BQL > sent bytes before ringing doorbell. Please read this: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#resending-after-review And also when you reply to people please use sane quoting. This: >>> is used to indicate three levels of quoting.