Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
MIME-Version: 1.0
References: <20231002221909.2958708-1-irogers@google.com> <CAP-5=fX-VOeCkOJY5xeW67x0+A0tGAHM4VYBBz46L-g2eRCR+w@mail.gmail.com>
 <93afcf44-5f8b-49c1-abc5-5304cba5f991@intel.com> <CAP-5=fXzcR6QKKhFG5PS1pFYi5JsO4AOUoH_-Bv0O+11YzEkkw@mail.gmail.com>
 <CAM9d7cjQZvZm+Vyrx9PTUYMFN5RjE+i-Kq1kbffyVp2hGKF6sg@mail.gmail.com>
 <CAP-5=fUo-vuLofC4jgHC9z=BTe80OEiY_PoQWqQtyVdvHcf+KQ@mail.gmail.com>
 <CAM9d7cjdb5WE-xdSdKD=p_EtsS7OSVEWL+GL3RVwczu-+1JvFQ@mail.gmail.com>
 <CAP-5=fVe9v=KOxJE5TfmivBQCD=7SRFpnqkob7e05U76d_bSPQ@mail.gmail.com> <6452eca3-e8de-40b5-8e04-2e37892880f7@intel.com>
In-Reply-To: <6452eca3-e8de-40b5-8e04-2e37892880f7@intel.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Thu, 12 Oct 2023 21:23:57 -0700
Message-ID: <CAM9d7cgmDh_39jvYdKdm-jhcLpB6+NmY8nPhdMDLtGNLzKX3JA@mail.gmail.com>
Subject: Re: [PATCH v1] perf intel-pt: pkt-decoder: Fix alignment issues
To:     Adrian Hunter <adrian.hunter@intel.com>
Cc:     Ian Rogers <irogers@google.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Jiri Olsa <jolsa@kernel.org>, Miguel Ojeda <ojeda@kernel.org>,
        Liam Howlett <liam.howlett@oracle.com>,
        linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Thu, Oct 12, 2023 at 5:27 AM Adrian Hunter <adrian.hunter@intel.com> wrote:
>
> On 11/10/23 09:50, Ian Rogers wrote:
> > On Tue, Oct 10, 2023 at 10:56 PM Namhyung Kim <namhyung@kernel.org> wrote:
> >>
> >> On Mon, Oct 9, 2023 at 8:31 AM Ian Rogers <irogers@google.com> wrote:
> >>>
> >>> On Sun, Oct 8, 2023 at 10:29 PM Namhyung Kim <namhyung@kernel.org> wrote:
> >>>>
> >>>> On Thu, Oct 5, 2023 at 2:24 PM Ian Rogers <irogers@google.com> wrote:
> >>>>>
> >>>>> On Thu, Oct 5, 2023 at 12:06 PM Adrian Hunter <adrian.hunter@intel.com> wrote:
> >>>>>>
> >>>>>> On 5/10/23 18:48, Ian Rogers wrote:
> >>>>>>> On Mon, Oct 2, 2023 at 3:19 PM Ian Rogers <irogers@google.com> wrote:
> >>>>>>>>
> >>>>>>>> The byte aligned buffer is cast to large types and dereferenced
> >>>>>>>> causing misaligned pointer warnings from undefined behavior sanitizer.
> >>>>>>>> Fix the alignment issues with memcpy which may require the
> >>>>>>>> introduction of temporaries.
> >>>>>>>>
> >>>>>>>> Signed-off-by: Ian Rogers <irogers@google.com>
> >>>>>>>> ---
> >>>>>>>
> >>>>>>> This is a relatively small change that fixes building with
> >>>>>>> -fsanitize=alignment -fsanitize-undefined-trap-on-error. Adrian, as
> >>>>>>> this is Intel-PT could you take a look?
> >>>>>>
> >>>>>> Thanks! This has been down my list of things to do for ages,
> >>>>>> but using get_unaligned_le16() etc seems nicer.  I sent a patch
> >>>>>> set for that.
> >>>>>
> >>>>> Thanks Adrian! Your patch set looks good and I think after Arnaldo's
> >>>>> comment is addressed we should go with it.
> >>>>
> >>>> I think it can be done as a later step as long as the interface is the
> >>>> same.  Can I add your Ack's to the Adrian's patchset?
> >>>
> >>> I think addressing Arnaldo's comment:
> >>> https://lore.kernel.org/lkml/ZR8QnasisGEsaaDR@kernel.org/
> >>> will need some changes to the patch series, and so I was waiting to
> >>> see the outcome of that.
> >>
> >> It seems it's done without further changes.  Can I get your Ack's now?
> >
> > With the unaligned.h patch on its own, I think patch 1 of 5 needs
> > dropping. For the rest I'm happy to acked-by.
>
> The new patch is on top of the others, so patch 1 is still needed.

I think I can squash it to the patch 1 if needed.

Thanks,
Namhyung