Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <5baa8c11-806c-4937-819d-a3b99a07c690@linux.intel.com>
Date:   Fri, 13 Oct 2023 12:23:00 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Cc:     baolu.lu@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATH v4 0/3] iommu/vt-d: debugfs: Enhancements to IOMMU debugfs
Content-Language: en-US
To:     Jingqi Liu <Jingqi.liu@intel.com>, iommu@lists.linux.dev,
        Tian Kevin <kevin.tian@intel.com>,
        David Woodhouse <dwmw2@infradead.org>,
        Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>
References: <20231011083915.36706-1-Jingqi.liu@intel.com>
From:   Baolu Lu <baolu.lu@linux.intel.com>
In-Reply-To: <20231011083915.36706-1-Jingqi.liu@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/11/23 4:39 PM, Jingqi Liu wrote:
> The original debugfs only dumps all IOMMU page tables without pasid 
> supported. It traverses all devices on the pci bus, then dumps all page 
> tables based on device domains. This traversal is from software 
> perspective. This series dumps page tables whose mappings are created 
> and destroyed by the iommu_map/unmap() interfaces, by traversing root 
> tables, context tables, pasid directories and pasid tables from hardware 
> perspective. It supports dumping a specified page table in legacy mode 
> or scalable mode with or without a specified pasid. It adds a debugfs 
> directory per pair of {device, pasid} when attaching device with pasid, 
> i.e. /sys/kernel/debug/iommu/intel/<device source id>/<pasid>. And 
> create a debugfs file in the directory for users to dump the page table 
> corresponding to {device, pasid}. e.g. 
> /sys/kernel/debug/iommu/intel/0000:00:02.0/1/domain_translation_struct. 
> For the default domain without pasid, it creates a debugfs file in the 
> debugfs device directory for users to dump its page table. e.g. 
> /sys/kernel/debug/iommu/intel/0000:00:02.0/domain_translation_struct. 
> Remove the corresponding debugfs directory and file when detaching or 
> releasing a device. For legacy mode, according to bus number and DEVFN, 
> traverse the root table and context table to get the pointer of page 
> table in the context table entry, then dump the specified page table. 
> For scalable mode, according to bus number, DEVFN and pasid, traverse 
> the root table, context table, pasid directory and pasid table to get 
> the pointer of page table in the pasid table entry, then dump the 
> specified page table. Examples are as follows: 1) Dump the page table of 
> device "0000:00:01.0" that only supports legacy mode. $ sudo cat 
> /sys/kernel/debug/iommu/intel/0000:00:01.0/domain_translation_struct 2) 
> Dump the page table of device "0000:00:02.0" with PASID "1" that 
> supports scalable mode. $ sudo cat 
> /sys/kernel/debug/iommu/intel/0000:00:0a.0/1/domain_translation_struct

This series doesn't apply to v6.6-rc5. Can you please rebase and send a
new version?

Best regards,
baolu