Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp741696rdg; Thu, 12 Oct 2023 22:21:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHuXnQ0M86emuh6QcNZp0AisXQRhHEL7BavbEeUZ9vArC1sVo7HkzC7ANXYEh3SydugLRWa X-Received: by 2002:a05:6a00:39a0:b0:68f:c4a2:fb1f with SMTP id fi32-20020a056a0039a000b0068fc4a2fb1fmr33967992pfb.8.1697174493625; Thu, 12 Oct 2023 22:21:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697174493; cv=none; d=google.com; s=arc-20160816; b=PMYd4x+StG69ZiuGobg+2ElAePKjkouLOE5h2lcCCo59fpgE1MCUrxyXWp+U8qflQ4 xLZoYaDcpqoiUQq7kSW55zLQ/TDKuQ+rx6zU9oowbL7Z6J1saPvCPV9bq1zS6zNLvMNe yTiQK6d4U9UXC5/LNzAwd0L53tTmbYCdsmcqc3eUVmkx8M9rSP/CKUwBKScgKwuRy8dc iGeteUVgTG5CeyQV1l8tT8eIuGRIgeQoDpPRTH5r3yZMaK8LllabEKQsD7dRfeO3tqtd drH/rqmB3vrTwrNpAZsy+at2x1FyFt+sMvjYXHhknFEZQ04Ote4kyZRoeLhcbH6nWCqW lTPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=6QGfj2S9zbKi77d+/HQwTmX4NBs+5xRSZN1jv25g9q4=; fh=xQgX6KkMp8WkTMp0qBQXrWaiz52Wjge9OsxTEQ4M2sM=; b=TyXV5fP2G+GffJKHh1rIHF5DeNyz14SHUuYfF0WUsdQkf5lMXN1vi17ulGjjuCHcNf 1y4EecjFinbcJc3A0NchcoCj0ndIbMgS4G93tChcvjxJ75x6enxh0ayRlMH6x4I6DH9D TArrlt0uhgknSjikKWwy5eBQ4LDxuOsA1C87DLLbJzjhSnCxoeRolVQI0aa+qKE94L7X UpdINbb5CxgX22E4jxOcC4y8XGmMuNUTsHnzE8USMrUlZi2lW3PGXfE1CQjxut163uJp 8j9eOFQfE0a3otY7pZk4g2EAwy6N4K4Q7exWXkfHzP6bU/llqI/iDnKVGsE3FSHVV4cL /m2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@inria.fr header.s=dc header.b=kRKFs9tB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=inria.fr Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id i75-20020a636d4e000000b005740ab95917si3928273pgc.45.2023.10.12.22.21.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Oct 2023 22:21:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@inria.fr header.s=dc header.b=kRKFs9tB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=inria.fr Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id A86E38065EFF; Thu, 12 Oct 2023 22:20:29 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229532AbjJMFUP (ORCPT + 99 others); Fri, 13 Oct 2023 01:20:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbjJMFUO (ORCPT ); Fri, 13 Oct 2023 01:20:14 -0400 Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89434B8 for ; Thu, 12 Oct 2023 22:20:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=6QGfj2S9zbKi77d+/HQwTmX4NBs+5xRSZN1jv25g9q4=; b=kRKFs9tBS1G7ewDnh4cMC9udGLWK1GsGjetMZiYupRG6yHrgMJpaMd+L ZBfQaGtFsPJs4McR3Yj9c4PdBkm3xUzY6F9ESLhfrJY4QxlMf70lyM0SR rBccl5q6OCGTsYu25Xhj56D18GFGn2U/0Wxt6yyhYnhoagWBrHqKPt14q o=; Authentication-Results: mail3-relais-sop.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="6.03,221,1694728800"; d="scan'208";a="68587634" Received: from 231.85.89.92.rev.sfr.net (HELO hadrien) ([92.89.85.231]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2023 07:20:10 +0200 Date: Fri, 13 Oct 2023 07:20:08 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Soumya Negi cc: Jonathan Kim , Dean ahn , Greg Kroah-Hartman , outreachy@lists.linux.dev, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tty: gdm724x: Fix coding style checkpatch warnings In-Reply-To: <20231013051502.9578-1-soumya.negi97@gmail.com> Message-ID: References: <20231013051502.9578-1-soumya.negi97@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 12 Oct 2023 22:20:30 -0700 (PDT) On Thu, 12 Oct 2023, Soumya Negi wrote: > Add blank line after declaration & match alignment with open parenthesis. > Issue found by checkpatch.pl This seems like two completely unrelated issues. julia > > Signed-off-by: Soumya Negi > --- > drivers/staging/gdm724x/gdm_tty.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c > index 32b2e817ff04..0c61eaff6122 100644 > --- a/drivers/staging/gdm724x/gdm_tty.c > +++ b/drivers/staging/gdm724x/gdm_tty.c > @@ -160,6 +160,7 @@ static ssize_t gdm_tty_write(struct tty_struct *tty, const u8 *buf, size_t len) > > while (remain) { > size_t sending_len = min_t(size_t, MUX_TX_MAX_SIZE, remain); > + > gdm->tty_dev->send_func(gdm->tty_dev->priv_dev, > (void *)(buf + sent_len), > sending_len, > @@ -271,8 +272,8 @@ int register_lte_tty_driver(void) > int ret; > > for (i = 0; i < TTY_MAX_COUNT; i++) { > - tty_driver = tty_alloc_driver(GDM_TTY_MINOR, > - TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV); > + tty_driver = tty_alloc_driver(GDM_TTY_MINOR, TTY_DRIVER_REAL_RAW | > + TTY_DRIVER_DYNAMIC_DEV); > if (IS_ERR(tty_driver)) > return PTR_ERR(tty_driver); > > -- > 2.42.0 > > >