Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <80a6a56b-4a12-99bb-acb3-94a5753b2de4@nxp.com>
Date:   Fri, 13 Oct 2023 11:35:17 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v3 2/2] arm64: dts: imx8mp: add reserve-memory nodes for
 DSP
To:     Alexander Stein <alexander.stein@ew.tq-group.com>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        conor+dt@kernel.org, Shawn Guo <shawnguo@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        "S.J. Wang" <shengjiu.wang@nxp.com>,
        Fabio Estevam <festevam@gmail.com>, devicetree@vger.kernel.org,
        Daniel Baluta <daniel.baluta@nxp.com>,
        Mpuaudiosw <Mpuaudiosw@nxp.com>,
        linux-arm-kernel@lists.infradead.org
Cc:     linux-imx <linux-imx@nxp.com>, linux-remoteproc@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        LnxRevLi <LnxRevLi@nxp.com>,
        "Iuliana Prodan (OSS)" <iuliana.prodan@oss.nxp.com>
References: <20231010090929.4371-1-iuliana.prodan@oss.nxp.com>
 <20231010090929.4371-3-iuliana.prodan@oss.nxp.com>
 <2301291.ElGaqSPkdT@steina-w>
Content-Language: en-US
From:   Iuliana Prodan <iuliana.prodan@nxp.com>
In-Reply-To: <2301291.ElGaqSPkdT@steina-w>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OTk4aXBIeWdFVnluU0JFSGdPQW5wNWk3aHVDOWZ2SVF4eEhNbmhtbnlRQko4?=
 =?utf-8?B?ZTVBZTNrMkllbjNMV3BKYzAyNGtWY1JxaEczMUw0QjJMNjcwaHdVUzdHcG0r?=
 =?utf-8?B?ekFDbG90R2h1eGZSbnIyekNRb01MSnhScFNmN2ljRnNOQ0ZRZlQvRTlVWHBj?=
 =?utf-8?B?QldPeXhNcTlBbnltL2k4OU0rcUlzckUwY2V2YmpER080M1FFQzFjZU1kUnFB?=
 =?utf-8?B?VndWZDhiTWlNb3J2SFVBRVRPVVo5RlFXNWhqTUFFbG9FOVhvQ3FtWncvMFl5?=
 =?utf-8?B?OUpDMnFvREtwaU5zdXRXNDQvM0xINk8wSEtCQmUvc3Z2bWVjMjRoRFBwUEND?=
 =?utf-8?B?UGpIVU1WYk9Cdmo0Wjd6ZXdGNkpsR0hvUW9DTlJyaHIxNGg5WDR5K05XazdX?=
 =?utf-8?B?M3JhZXcrSlBlM1JTUFoxN2ZUaVRJbVBadjlPczZFMkRFVU14RStwWWJJTitH?=
 =?utf-8?B?eXEzUm0yQmNJb2MyVmxwbis2VzhDNTVSMEx4U1RqaURiSWFzbEFkdWd4QmJJ?=
 =?utf-8?B?aEs4bnJaaWN4V0lBaHFQdFhTa0ExejVYLzVFalNWMEF4Y3VleUUvWkRBWlhv?=
 =?utf-8?B?NDJYOVVYMWZIeGtOUTVWK0tpU2MxMitmbG81VTN4VEJSclNGQmE2SVBXektQ?=
 =?utf-8?B?U0NqblhmUVBvc0FrT0NWSWhhRzQvdU1mT3FHK1ZjUnROcU5mdncrU2oxTXlz?=
 =?utf-8?B?NWxKZGJpRmx3d1k3ZWIzQi9BTWh1NytwVXRZNnRCRXk0ZXUwb21PUkVVWkZ3?=
 =?utf-8?B?bHMyOXJxdnV1b2M3Q2pDY0VtRjhzeXJTbmg3TkNRZ1VkSk5OODhzSXdNT3dl?=
 =?utf-8?B?dElZTXcySW9la0t5azZrMFlkZFJuWEtnRk5hS1ZVMjZCZ1V0N0tiUUk1bmhW?=
 =?utf-8?B?ZHgzRTFaRlpPUUVaQ280MjVvUWQ5UlcyREZQVE4rSHFNVVI3YUF5NXF2bWZV?=
 =?utf-8?B?bXpRK2FYMTJiS2JBZmNWTEtCeGNFOEg2RFk3TVBlOXJ3L1BsMTZycVQwWThC?=
 =?utf-8?B?UnFFT0RoK0ZRSE0zdCsxRDIyK09ySGpxN0RPb0xLeGVJTGdOMHhmdzFlUGdu?=
 =?utf-8?B?RGkwTUN2UnlyemI4SDJ1d21wYTJSNzNNVGl3MXlhc3lKUkpocFdxTUIxZjkv?=
 =?utf-8?B?TXc0QVIyeDdXdUF0RGhUUThnUTE3Uk9UZEdjUHVWTnVFdm9qTWZ3dHpkYXUy?=
 =?utf-8?B?Q3NwZDZMcS9KeEt1ZVJrT05BSDVVaXRYMFB1OG9MMmtJcTVtNzdxL2xQNVlk?=
 =?utf-8?B?bFFlMU8rWDJBN3ZFM3JoR01mK1JaWkhTNDU4OGVoSk56eGQrUFJNUGJxVnFm?=
 =?utf-8?B?M3FKaDJXMWlqN2RHcnpUWDV6TmFzcmVTTEw1SW80emtrQVJvclo3VHgycUFn?=
 =?utf-8?B?aEl4UFlHMzRsS2JhcVgwMlI2VDBldEtpNDZaazdRQTlvM0xlVHgrZW5ySjZh?=
 =?utf-8?B?clcvUWdpWWJueWV1cUxoMWdyWnM0Mk16ZGQ0Qm94dmNsN2ovb2xzVkRuRWlw?=
 =?utf-8?B?Vm5Ea3lWM0lIYjN1THFOSnRoWFBKeFFyYXc5OERsSVlRd2VUOWRqWHRSams5?=
 =?utf-8?B?eFI4dGxOSlNDZHowa0wwQTR0WWMyc2lvLy9sZmRRcmhuSnhhZWVBdkVrVDJv?=
 =?utf-8?B?NHQzWWtKUDZCbVIxRXFkdDg0Tms5c2hhcmZ5MDVZc0ZNS3dSOW9LdVRXZ2RL?=
 =?utf-8?B?ekE2ZEd3OTcxclFhLzF5YkZaNktHc25BN3FCUU9YcVd5b1k4Wmw0ZWQ3N2xw?=
 =?utf-8?B?a3ZkQ3hIQ05qakJaMnhQdFdVdFdKbWswZlZ6QW0rWDBFcXRMOXlZMStSZ29v?=
 =?utf-8?B?c2xOK0NXOFhoVzc3alA0RXdZb015RnFabi9kanV5L3VTb3pJZ0RyRjRBTllr?=
 =?utf-8?B?TW9SdzBPUkpUNFRJS3p5S3lCbjZmSWg2YUJxdEdDN25RemgrY1k4VmJTcCtM?=
 =?utf-8?B?cGd0a2tjMk92UTlLNkRVR05GUDBTcGJtY2NQY2U2dzExY21FTW1vZWpDZTIv?=
 =?utf-8?B?MXZxM3ZmMGhBSFc5VUEwNTUrYU5yQ2tYTFdaZFRKbmZLazJNZWRrSTFnUC9o?=
 =?utf-8?B?Zm9ITXVLdDZRYnovYWdTd1NMTEUrRi93WUQyQVBsaGJZTFQzT01HTWd3OUhJ?=
 =?utf-8?Q?p/F2njr6FGVcgp8ZcRxVDivoi?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cc7fc941-82c6-498c-ea75-08dbcbc7566e
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8774.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2023 08:35:21.4729
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uNzCT8cgQiARErIrwnVbaMqtPRW9ptGJyb/TJdmKswpEyAl2MNzq6foWR9nLHNfW31IHGhMMJ+UpzALVkm2Xzw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9496
X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 13 Oct 2023 01:35:59 -0700 (PDT)

Hi Alexander,

On 10/11/2023 8:37 AM, Alexander Stein wrote:
> Hi Iuliana,
>
> Am Dienstag, 10. Oktober 2023, 11:09:29 CEST schrieb Iuliana Prodan (OSS):
>> From: Iuliana Prodan <iuliana.prodan@nxp.com>
>>
>> Add the reserve-memory nodes used by DSP when the rpmsg
>> feature is enabled.
>>
>> Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com>
>> ---
>>   arch/arm64/boot/dts/freescale/imx8mp.dtsi | 16 ++++++++++++++++
>>   1 file changed, 16 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>> b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index
>> cc406bb338fe..22815b3ea890 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>> @@ -211,6 +211,22 @@
>>   			reg = <0 0x92400000 0 0x2000000>;
>>   			no-map;
>>   		};
>> +
>> +		dsp_vdev0vring0: vdev0vring0@942f0000 {
>> +			reg = <0 0x942f0000 0 0x8000>;
>> +			no-map;
>> +		};
>> +
>> +		dsp_vdev0vring1: vdev0vring1@942f8000 {
>> +			reg = <0 0x942f8000 0 0x8000>;
>> +			no-map;
>> +		};
>> +
>> +		dsp_vdev0buffer: vdev0buffer@94300000 {
>> +			compatible = "shared-dma-pool";
>> +			reg = <0 0x94300000 0 0x100000>;
>> +			no-map;
>> +		};
> Please configure these reserved memories on board level. Not every i.MX8MP
> based board uses this DSP or has these memory addresses available.

Will it be ok in imx8mp-evk.dts?

Thanks,
Iulia

> Best regards,
> Alexander
>
>>   	};
>>
>>   	pmu {
>