Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <ba8d31bf-28f5-d8a1-adff-1b9ea7c3a578@axentia.se>
Date:   Fri, 13 Oct 2023 10:36:19 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH] mux: Make it possible to select MULTIPLEXER if EXPERT
Content-Language: sv-SE, en-US
To:     William Kennington <william@wkennington.com>
Cc:     linux-kernel@vger.kernel.org
References: <20230926230712.516709-1-william@wkennington.com>
 <aa4591dd-b558-3401-4a19-362780ec321f@axentia.se>
 <CAD_4BXhWbUxuidM47poTKFYYruL5jdJyPUfoZvXnqwDNNLd98w@mail.gmail.com>
From:   Peter Rosin <peda@axentia.se>
In-Reply-To: <CAD_4BXhWbUxuidM47poTKFYYruL5jdJyPUfoZvXnqwDNNLd98w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VkRpSkZmNjJtamlOMUFjTzlMdk85Nml0aTRCYzlVczRtbU9YWHloOXpCN3g0?=
 =?utf-8?B?NFhCRnFhUXV5OTdHN21WZklwNWlhaFhoNHg5YzRVR2Z4R2s5MElrSTBtbVQ3?=
 =?utf-8?B?RDFMSzF1ck93ZVp0WEFidFhUblJEaDliZTVNTHkwWnpueU12S0ZzbWlGV3U2?=
 =?utf-8?B?YVY3aW1JUm9pcWpIMXhkRlpvVklSRlJxYkNWdXh2c250QnVIbllJQTgxb053?=
 =?utf-8?B?eW44TmxoMEpRQ0ZhNWJCYzFwdDBITHMvcXFxWHErbVdrdFNkcG9GS0huR1Vh?=
 =?utf-8?B?R00rUlQyeVhENCt0VU1qNlF5andNbGJaTXVWWmMzRTV5T2tFb1dOeTZVMTZO?=
 =?utf-8?B?UlQrdnN0WDFjcWFURGRCTjg4REFmcndYUTRwWFdoeWs5OU9JTW9yMUpXejJz?=
 =?utf-8?B?RUxsSWFCRVdJbGFwODNkRGdFU2M3QUxTdnR5SHNuRVl1cVo1ZnVZa0FwUG5B?=
 =?utf-8?B?bU5uSnRoMzgwRDVPRytxREhlWHdLSldiaVVPcFppMWJoSHB3Z292ZWU0RzNT?=
 =?utf-8?B?b3hqdWg5cDN0NzRMcmp1RTcweEs0cFFUbmFsaTdzWFFzRTRtcWdRdFl6bitF?=
 =?utf-8?B?RThndC82ZlV0dXROYWEvaW1WNG0rS1dnc0JWSEsvQ3JsdnFiSkE5UGRBU21J?=
 =?utf-8?B?L2xEN21QamNwMnRjY21zcGJlSHNoUmlyaWlldUE0TEwwV2hNaW9Mc0dtSitr?=
 =?utf-8?B?K3BpVlEzV3FSZzMwMXNiZXRNNGVKMjRrZ2JyY3R0dkpIUDlkRDZYZXMwbFgy?=
 =?utf-8?B?OENJOWlRN3ozN1hQN2NsdXZJNFVBMERydDJPbWxjMCtsdndGMm4zNFZleXhL?=
 =?utf-8?B?R0xyTWpSMWNOL1IzcUIxZ0FvelJJRENra3lGMENMelhWNXBMZVpvYXcyZWpz?=
 =?utf-8?B?U296Z0ltYW1TbW5odStWWVQ1VWl3K3Q2R3NWU3dnMEZaWHRza2dpc2JRRkto?=
 =?utf-8?B?b3ZWTUM1VHZrdmpRUWdiMWREbW11Y081bk52Ujl5UTIvOUZ6WENxWEF4TzZ2?=
 =?utf-8?B?UExMMVdWT3VSbU5sSlRESlVibm8rSGJPWEZ1a3NSck93SkRUYmpJNEJOQmFk?=
 =?utf-8?B?Y0ZsMGl6UnRUdG1nTUF1YnJuRHgvbktiSGFyWU5Cc2plNlUxNGgzOHVVS014?=
 =?utf-8?B?dTgvWnQ5VDdGTDdmNnVZSURVNXVXRlNYeHJvcDJDN043Rm40ZzF3ZVBMV2lB?=
 =?utf-8?B?VDZFREl5R1FJdXVJakNEY1RValVoY0Y4QjRmU1pnWmpZdFhIKzl5Mmh5MmdF?=
 =?utf-8?B?RE5WQ01DcnAxZ2tJS3pESnVRUTIweU1lNzFlT1Iwak82Um84bHdBRDFCaTUx?=
 =?utf-8?B?UG9lcGlMWktmQklPR2t0azBRSHVudW9hNTc0ai9DN0NPZmdxSmk0NWNqM1p1?=
 =?utf-8?B?U0lZNkRXc2pnVmVHQmU4c2MrNTVvTElBUVh6YXhXSzZBS1dZYi9nVld4bGJs?=
 =?utf-8?B?QzZUTlQvdEJKN0M2RThUSHB0RlpQSVlDdkpMSVd5a3h0cXpjaTRFcVpRbFE3?=
 =?utf-8?B?enpRcmRhZ0hYcG1yTFR3bVhSNnZXOEZ3dE1ZdFBTVWloQXBQSVpjRmkrbHZP?=
 =?utf-8?B?dDVUZjZ4QWxjUVhZQmxtYWp5RnRjcXZRU2FjUTNNNkRTSG9WRkwwWVEzNDhk?=
 =?utf-8?B?T2F6aG9qZG9IQzlDc2xiL25jTlZTSTZncFd5bWszaWczY2l6emN1RHpIOGxK?=
 =?utf-8?B?T2dsSDQ4akdUSmZVdmc5YW9JdEwrWFV5NE1ieFAzUFAzVzY2NkZpc2VBTG9Q?=
 =?utf-8?B?VDdzU0M3Q1hrK2VnWW1CNStKQUt2UDVnbUZOMk53VGp5NG9vN1FMQVBkb0tH?=
 =?utf-8?B?UEZzT3E0eGM0K0NmcithTll1VmViaG14K2twclZacFNhZjkrN1RSczdRK0Iz?=
 =?utf-8?B?eFAvK1pXMW5EY2gzSmNxcVRBMURFeEpkYTViZ0JITmVwZWxhNkxzeWpUQjZ3?=
 =?utf-8?B?K3B1c2hJL2pWYlEwVnA5djVNOG9hZWxyWHYrbG5NbWFUeUFldmpVUmNyWUhl?=
 =?utf-8?B?WFdKZ1E5TjZmS3hkbkpDRU5SSlpIbDNGQW9rODhONEJ1WWtJY2pjSm9qbHpK?=
 =?utf-8?B?dGRSZFgxWTJWcXRaVENndHI4UmVFVmxvNkRvbGRLRGFTQ2R4Q0tGclkrQ1Bz?=
 =?utf-8?Q?qVndz1c3Igly8R2pkmlugjA4s?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: 43916d77-7492-4321-09c8-08dbcbc77a07
X-MS-Exchange-CrossTenant-AuthSource: AM0PR02MB4436.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2023 08:36:21.1102
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +e45zfCMvfiBPaJEeubotC4UX7oUxk7PfWpt0fzWbVJm+s504X9epzZ72vnZ2dup
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR02MB6858
X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 13 Oct 2023 01:36:43 -0700 (PDT)

Hi!

2023-10-12 at 23:52, William Kennington wrote:
> On Wed, Sep 27, 2023 at 16:08 Peter Rosin <peda@axentia.se <mailto:peda@axentia.se>> wrote:
> 
>     Hi!
> 
>     2023-09-27 at 01:07, William A. Kennington III wrote:
>     > Right now, there is no way to enable multiplexer support unless another
>     > config option selects it. When using `allnoconfig` with CONFIG_EXPERT,
>     > this is deselected with no way to enable it.
> 
>     I fail to see how that would be useful? Why would you want the mux
>     core if there are no users?
> 
> 
> In this case the user is a custom configuration that is added per board following 
> Documentation/devicetree/bindings/arm/npcm/nuvoton,gcr.yaml

(That binding has recently been moved:
Documentation/devicetree/bindings/soc/nuvoton/nuvoton,npcm-gcr.yaml)

> 
> I suppose the problem is that ARCH_NPCM7XX doesn’t select MULTIPLEXER and MUX_MMIO. Maybe that’s the patch you are looking for? Nothing else that we use has a dt compatible string with mmio-mux or uses the functionality under the covers. This leads to our board config selecting it manually.

Perhaps? I think that's one way to do it.

I'm not sure about what exactly should select MULTIPLEXER in your case,
but the thinking is that whatever driver wants to use a mux controller
should be responsible for selecting the mux core.

Maybe that thinking needs revisiting?

When digging I'm finding nodes that wants to add mux controllers to the
npcm "gcr" syscon node in:

arch/arm/boot/dts/nuvoton/nuvoton-npcm730-gbs.dts
arch/arm/boot/dts/nuvoton/nuvoton-npcm730-kudo.dts
arch/arm/boot/dts/nuvoton/nuvoton-npcm750-runbmc-olympus.dts

But I then find no mention of any nodes wanting make use of those mux
controllers. My thinking is that whomever comes up with a dts that
actually has such nodes will also want to select drivers for those nodes.
And those drivers in turn should select MULTIPLEXER.

(The above olympus case is a bit suspect since the mux controller has no
label, and it is therefore needlessly difficult to reference the node
from a node that needs a mux controller)

Cheers,
Peter