Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp813659rdg; Fri, 13 Oct 2023 01:41:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE/0gSwejK6i1RnMtRxH2BiJJhCp/jH4hOWxpTD2/rw5sE8YoVaThVN8/ysOxJwUVWDnKYJ X-Received: by 2002:a17:903:487:b0:1c9:d25c:17c6 with SMTP id jj7-20020a170903048700b001c9d25c17c6mr5772239plb.1.1697186497613; Fri, 13 Oct 2023 01:41:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697186497; cv=none; d=google.com; s=arc-20160816; b=Ebc8yLZZiW7aPXFOt0ZB3bedvt6IoGe6SKkt5qu292oupYJOleCKGnris5lBX3d9uW vVrQQpMmQZkzvjnxIDahocZX1Mcqgaafzy6LkXPAorZWEKkHwPK17NT5fYXTQXbbqV22 CiWMqZJgSqXjJhda2dGIME22omOJm1qbOqRvuoec7o5cTe6fegka79gSlW9lBDga3WCj 44d94XmYqttLY558s/Q+CgI0W9KtxvKHjEG5FIHvnHGdd6zgnKIrH3HuG9lNoaod8D7j 3LnOUtkzZgIXKh+AV5X3RMLCGE04aryd3jj55fFka1x92IGK5AT9x0+tG1QJcCULshEl 6XGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=ELi2p/k1BLhabv3MERzK5t5wQ565Qxo4YtSVt+w+5cM=; fh=bs78tPdaRcVEi0FN1r7UsAqd3xmsq8MTAlc6AJHXfL0=; b=ZXA+YEu9AF8ItFOcEkjMuey8c4se7nWYDFwpRY/wmh50MS4YLg5BVp5d+1O4FxLXSt VK3yiadcH26VLXCKoNp6o6m4Bm6Da+2J5c4vyXyv0rg97xu+Ib8pbDVoX/S+NfQ+nikT BT0nJKUgFauPuuFtyUCEaHFkt7gCniZB+Yd6tEvyz1jR83vDhbIyNOS2tetFkEcKk0gE YwVJcRDWGe8f5PMBa4Kol8RUlMQJbnGrCmeNY+0ikgntQ1CS8ZHYAh3tCX8wVRY4ybe2 ozKUB4AkLWRwtPLuRe62fIrdOmg2MV3QtXxxsWw+OI/GgCYPajDPArASTspELLEhSw+s gzgA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id u14-20020a170902e5ce00b001c9af9ace1dsi4403005plf.347.2023.10.13.01.41.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 01:41:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id ABA3C8266594; Fri, 13 Oct 2023 01:41:32 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230103AbjJMIlV (ORCPT + 99 others); Fri, 13 Oct 2023 04:41:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230011AbjJMIlT (ORCPT ); Fri, 13 Oct 2023 04:41:19 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31B50B8; Fri, 13 Oct 2023 01:41:17 -0700 (PDT) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4S6Kg01Yz1z6H6pg; Fri, 13 Oct 2023 16:39:08 +0800 (CST) Received: from localhost (10.126.172.163) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Fri, 13 Oct 2023 09:41:14 +0100 Date: Fri, 13 Oct 2023 09:41:13 +0100 From: Jonathan Cameron To: Shuai Xue CC: Bjorn Helgaas , , , , , , , , , , , , , Subject: Re: [PATCH v7 3/4] drivers/perf: add DesignWare PCIe PMU driver Message-ID: <20231013094113.00003d72@Huawei.com> In-Reply-To: References: <20231012162512.GA1069387@bhelgaas> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.126.172.163] X-ClientProxiedBy: lhrpeml100001.china.huawei.com (7.191.160.183) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 13 Oct 2023 01:41:33 -0700 (PDT) > > > >> + depends on (ARM64 && PCI) > > > > I don't see any actual ARM64 dependency in the code, so maybe omit > > ARM64 (as PCIE_DW_PLAT_HOST does) or add "|| COMPILE_TEST"? > > I will remove the ARM64 dependency and add COMPILE_TEST. don't do both. That makes no sense. either depends on PCI && (ARM64 || COMPILE_TEST) or depends on PCI