Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp818109rdg; Fri, 13 Oct 2023 01:53:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFyRLGnvKUnQ2IIJ4bxJJHtZNDRJJ+RLHoItRerGI8O1SjPPSl9Zs+ymrM/NDrdzjr/Jr+R X-Received: by 2002:a05:6a20:6a2c:b0:16b:f586:3c4 with SMTP id p44-20020a056a206a2c00b0016bf58603c4mr22324246pzk.58.1697187228410; Fri, 13 Oct 2023 01:53:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697187228; cv=none; d=google.com; s=arc-20160816; b=zrN47yLl45vLb6xVvFSn6atW0ZJ5TD75+cecogx1/3kJuQYmejlTq8Kzjj6D+csu4C vpVbbh8+yt2IoeDiHB33lIw3ZnSCRGSrq8ONO/K/0JciPo1mlSUJurZV0zwDv6FvkIj1 BIHcQoZtSolORKbUG/XN+OMDW3SSBelOr7tVblRgM/NEGDoIu8x3Zo89ioNzHMWGz2+g GU1r1mJgRiBwP7QVQClkwkimgUSJSsPt58haHb2Cwi+ZQfkS/XMXub2gwC3wyS6O9MlJ oLhc/HId9gkAR8dcJ/3sHOXaF1xniUCQVN6NhUhXTm/KAUIRJ+9ESm3HThJ1myqkV231 r8ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=9ei3TFmaOXq0JADSQLlmEKSbGLvw708qlaZ+x/9kH7o=; fh=xQgX6KkMp8WkTMp0qBQXrWaiz52Wjge9OsxTEQ4M2sM=; b=o0e2kIs8jfc1Snl7SVXTPJ/212zNGfw7ARD6AylT4+P06U3l2+bBnHG6JILESdrYJG hhdm0Edp4sUdHTD5cciPjR25DmHhZcwuB+JUlPpcLsJzqqKgoSCJWRsi3clzAlmSg663 3kOgNV8kncKcbtsq0xzwxSRscS1Ugm1qdduIJiJvRnjWkKrImBqyAlbBPSt9Tx7oakwS x/07p7OiWMsIdy4R3uPrsR/peTOoFsPIFDo+P8v2aJgrRzJ1qPUaM5h1bJQOkKB+7l/M k4v+8m2N9v0GHEwcXkghxV6XGHdVJ6b+VPcXetenCudh/qZqhhOllOZV9xNVNJOyqy5R cvmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NizVOLAP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id bi4-20020a170902bf0400b001c9c3212c88si3894916plb.253.2023.10.13.01.53.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 01:53:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NizVOLAP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 962718218E70; Fri, 13 Oct 2023 01:53:47 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230230AbjJMIxn (ORCPT + 99 others); Fri, 13 Oct 2023 04:53:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230125AbjJMIxm (ORCPT ); Fri, 13 Oct 2023 04:53:42 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B99CDB7 for ; Fri, 13 Oct 2023 01:53:40 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4066692ad35so19391245e9.1 for ; Fri, 13 Oct 2023 01:53:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697187219; x=1697792019; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9ei3TFmaOXq0JADSQLlmEKSbGLvw708qlaZ+x/9kH7o=; b=NizVOLAPXroEvmC4Z5dos9IDMYeHc0pV9F9J4foWsB5B7YhtN+s5WNXJmJzeoW43rK ntND51Ey2bREBeM4L3ZSLHr45JRTcS0uLIm9NLJsScVn0nP6z91d7/v8PxM52+uKeead OlERpZR/aNzVk30BPNrbiTQgsQ6ZRWc8ntLCi4zExhn4uHVDOiXI+RtzqMmhRkiLJByt YoCUrb3iNSHsSz8fQlLSEd9FF0+TxINJSoPv3an2D0eIpU3e/A6lPUqQeGmcsav3JJ7H OVD3g//cpWKXrcl9o/JXWpd4nx5oQJrr6GuHw2V8f5Tz178DQBkaADOgW6020FFWRDMM 3YOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697187219; x=1697792019; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9ei3TFmaOXq0JADSQLlmEKSbGLvw708qlaZ+x/9kH7o=; b=I7uu4gBE8ELi8w2N4WeJbtHgN8l6d/B9FIBhSJUJzjMMEpfJnLyNHQoMmnZFfLN/lD UtHL1AuvOnDkLFaBFlvjB6HMe4sNorTADYnhOQ6RRrUBQaQBqmXzgDvmbBt2Z6qJrG7c yahaAsRu3cm14bwR45veMJtRRRHmiyZdqQDMcruUSwm9DCjNbw8usT4jfIuDlwZwhoYf 5WD92hmaC4zIl2fwDH1a0R1jWRoiSecRhKWn7A9wTxMtEA5GnKFxg/A71rYWXh/zuYfz aPWOInuH0bgnbfg0F3xlZeiOib6h+Bb4o1arg0c4uHbNIryECfZbKfXCaMlF4kIAYNj2 BGrg== X-Gm-Message-State: AOJu0YwkUmJq4ipIZ7iMhkrb0+NCGj3NQlY3O0m+8oyt4+JdGaLpAhAN xyUN9/9CThkMJUNSzR2lLK0PHg== X-Received: by 2002:a1c:4c10:0:b0:402:f8eb:28d8 with SMTP id z16-20020a1c4c10000000b00402f8eb28d8mr22460284wmf.6.1697187219235; Fri, 13 Oct 2023 01:53:39 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id n14-20020adfe78e000000b0032196c508e3sm20215454wrm.53.2023.10.13.01.53.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 01:53:38 -0700 (PDT) Date: Fri, 13 Oct 2023 11:53:36 +0300 From: Dan Carpenter To: Soumya Negi Cc: Jonathan Kim , Dean ahn , Greg Kroah-Hartman , outreachy@lists.linux.dev, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tty: gdm724x: Fix coding style checkpatch warnings Message-ID: <663c85bb-90c3-4ae1-ab0b-5ab1a8abd2a7@kadam.mountain> References: <20231013051502.9578-1-soumya.negi97@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231013051502.9578-1-soumya.negi97@gmail.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 13 Oct 2023 01:53:47 -0700 (PDT) On Thu, Oct 12, 2023 at 10:14:58PM -0700, Soumya Negi wrote: > @@ -271,8 +272,8 @@ int register_lte_tty_driver(void) > int ret; > > for (i = 0; i < TTY_MAX_COUNT; i++) { > - tty_driver = tty_alloc_driver(GDM_TTY_MINOR, > - TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV); > + tty_driver = tty_alloc_driver(GDM_TTY_MINOR, TTY_DRIVER_REAL_RAW | > + TTY_DRIVER_DYNAMIC_DEV); Don't do this. The code was better before. The parameter "TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV" is one thing and splitting it up like that makes the code less readable. And I bet they had to indent it like that to get under the 80 character limit. This is an example of checkpatch giving bad advice. regards, dan carpenter