Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp852859rdg; Fri, 13 Oct 2023 03:15:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFnRs11DvomIkZUTcKYIoC8ppHVoIwXBDUXEEOgIvxM3PrDVNhhukAHusw4m6LViohB1p2m X-Received: by 2002:a17:903:2103:b0:1c9:e774:58d0 with SMTP id o3-20020a170903210300b001c9e77458d0mr2577112ple.34.1697192130735; Fri, 13 Oct 2023 03:15:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697192130; cv=none; d=google.com; s=arc-20160816; b=VBOFTiX9ou5id2N6yMa81OtAJ/5yNKyML/iJQxls4ZCCvCqiUdbGT/VHkRb5CwzhaL vF0uMRGAsaVQEO/6jBE046iTSoMHPYsWAsK2QnIkMADLn7woPlDmP/nPDy8VThHLF71n vlhAEd3wfj6lz5lPw1U/7t+K81A2mDZ15Ja4Hvx/ZO724yQgzASNyOxZ9g8/Z4QcrmiI rPgZvvTfy8AFNWotLOqt/zvbYRsLK+skQ79HgdIZQwgkaxmyOT+GXWabqFLI3oCq2U66 d6FCaeWB8AWeOiSUwdPGBg9szhy7IS8/c50xWsklfEVAg/jDwbUR1N20p6wJ/wTBYb42 hmhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=R11BA3bQ+vSaZ8XZ2nUbu8LgouEdUo5Fe/w4MPrQlU8=; fh=XjVQimzxf3Eu+VVRP2bl63XOvJDpML02aawTvJzK9JY=; b=oAIRZ0imxs9fSLaprGNDRxbQr2a2L2pzOjLYczCMJ2q/uq4hYZKRIkaqco0fnIBDrX lYPDGr3YAo9SEDbbb8FK3/p+pWbnsMQJFQTSck33kFW8admvj+ZfjwfAfW7i28QSF3as WfZ0TMU0XISUKQwSgLKLY9KQ7NMiLKD4h95ApNl/DQ0H/MnoCqQu6QIheSfWIJmZ4Qe1 jclx/vRLHHT34Uc2VyjProusnTnHl9oG86tvW92Q67Q0xayiTi1lCApMh+Sr3Cu5nFgj LNNAJwecZsSTrZZofr3Ha7xwpKQLePQ6Qr0bj7QYQp8v6jMs1KMIkuwziWpWE2tcQFSl Wxmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fLNNYRZd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id bd10-20020a170902830a00b001c5fca2e1besi3919502plb.15.2023.10.13.03.15.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 03:15:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fLNNYRZd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 8AFF383033BC; Fri, 13 Oct 2023 03:15:27 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229940AbjJMKPP (ORCPT + 99 others); Fri, 13 Oct 2023 06:15:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229744AbjJMKPN (ORCPT ); Fri, 13 Oct 2023 06:15:13 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6EBEA9; Fri, 13 Oct 2023 03:15:12 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 550C2C433C8; Fri, 13 Oct 2023 10:15:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697192112; bh=aGHVQsxuj9G9JKltllMhMOa3dCvnQ4pMTigq/zF8NLM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fLNNYRZdN7XfMueMEXlJR0cAn29QSfIqdxZNvFkEccpLvWfiNc85dmbjTyC5SlPGm WfRzRhbw0vcLCnj1w1EYrUv9og8yKuHG4IkaeUrAFLGTRsJs7eyDCcStliYuRvf7+X 0yvwbE9Jx5QD0as+ThO/1xx+XpgKwGrj9Grhp+G7xoyAcvjsgSOYT1aBXNK/GyuZfs nXW7efCQJdHgydkQo2vFw4O4vjqGZQJu4JZshV1loWlwBxK9WEMcomWPAB54ld6AC+ 6Ar/esIUpp9h+kOaqc0Ia9aXJUPGq8Pe2nKJMYHYVBF1Gde4bLOdreGeE4uRVMOXVB UBcwJOclTtlHQ== Date: Fri, 13 Oct 2023 11:15:07 +0100 From: Lee Jones To: Johan Hovold Cc: Stephen Boyd , Johan Hovold , Andy Gross , Bjorn Andersson , Konrad Dybcio , Caleb Connolly , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: (subset) [PATCH 0/5] mfd: qcom-spmi-pmic: fix revid implementation Message-ID: <20231013101507.GI8314@google.com> References: <20231003152927.15000-1-johan+linaro@kernel.org> <169710605745.1174112.5043840678154728515.b4-ty@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 13 Oct 2023 03:15:27 -0700 (PDT) On Fri, 13 Oct 2023, Johan Hovold wrote: > On Thu, Oct 12, 2023 at 11:20:57AM +0100, Lee Jones wrote: > > On Tue, 03 Oct 2023 17:29:22 +0200, Johan Hovold wrote: > > > The Qualcomm SPMI PMIC revid implementation is broken in multiple ways > > > that can lead to resource leaks and crashes. This series reworks the > > > implementation so that can be used safely. > > > > > > Included is also a rename of the SPMI device lookup helper which can > > > hopefully help prevent similar leaks from being reintroduced. > > > > > > [...] > > > > Applied, thanks! > > > > [1/5] mfd: qcom-spmi-pmic: fix reference leaks in revid helper > > commit: 365cf70ff33fe20e749227346d7245f7f0dccb58 > > [2/5] mfd: qcom-spmi-pmic: fix revid implementation > > commit: 7370f9de463b1d21dcdf9480a0a15babecd14ac7 > > [3/5] mfd: qcom-spmi-pmic: switch to EXPORT_SYMBOL_GPL() > > commit: b5cd5e72a71e9d368e20271d3a772dd045ae220e > > Thanks for picking these up, Lee. You don't seem to have pushed these > out yet so I'm not sure if you intend to send them on for 6.6-rc or > 6.7-rc1 yet. Just pushed. Should be in -next tomorrow. These do not fix commits from this release and I'm not planning on sending another PR for the current rcs, so these are due for v6.7-rc1. > Either way, would it be possible to include also the related and > dependant spmi cleanups? With Acks, sure. > Stephen, could you ack those changes so Lee can take them as well? -- Lee Jones [李琼斯]