Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-1019-ged83ad8595-fm-20231002.001-ged83ad85
MIME-Version: 1.0
Message-Id: <4a53722d-e31d-4598-a4a9-cf374c84bc44@app.fastmail.com>
In-Reply-To: <20231013100549.3198564-1-danishanwar@ti.com>
References: <20231013100549.3198564-1-danishanwar@ti.com>
Date:   Fri, 13 Oct 2023 12:38:17 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "MD Danish Anwar" <danishanwar@ti.com>,
        "Andrew Lunn" <andrew@lunn.ch>,
        "Wolfram Sang" <wsa+renesas@sang-engineering.com>,
        "Simon Horman" <horms@kernel.org>, "Roger Quadros" <rogerq@ti.com>,
        "Vignesh Raghavendra" <vigneshr@ti.com>,
        "Paolo Abeni" <pabeni@redhat.com>,
        "Jakub Kicinski" <kuba@kernel.org>,
        "Eric Dumazet" <edumazet@google.com>,
        "David S . Miller" <davem@davemloft.net>
Cc:     linux-kernel@vger.kernel.org, Netdev <netdev@vger.kernel.org>,
        srk@ti.com, r-gunasekaran@ti.com,
        "Roger Quadros" <rogerq@kernel.org>
Subject: Re: [PATCH net] net: ethernet: ti: Fix mixed module-builtin object
Content-Type: text/plain
Precedence: bulk

On Fri, Oct 13, 2023, at 12:05, MD Danish Anwar wrote:
> With CONFIG_TI_K3_AM65_CPSW_NUSS=y and CONFIG_TI_ICSSG_PRUETH=m,
> k3-cppi-desc-pool.o is linked to a module and also to vmlinux even though
> the expected CFLAGS are different between builtins and modules.
>
> The build system is complaining about the following:
>
> k3-cppi-desc-pool.o is added to multiple modules: icssg-prueth
> ti-am65-cpsw-nuss
>
> Introduce the new module, k3-cppi-desc-pool, to provide the common
> functions to ti-am65-cpsw-nuss and icssg-prueth.
>
> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>

I submitted a different patch for this a while ago:
https://lore.kernel.org/lkml/20230612124024.520720-3-arnd@kernel.org/

I think I never sent a v2 of that, but I still have a
working version in my local tree. I've replaced my version
with yours for testing now, to see if you still need something
beyond that.

    Arnd