Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp866197rdg; Fri, 13 Oct 2023 03:45:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHNz97m0apTPRchc5qlnSdZU6uBtxe44dx+tTTZ2nyRaBxm/gRH3clEm77n6XsfD7EYuoNk X-Received: by 2002:a54:4812:0:b0:3ad:c497:1336 with SMTP id j18-20020a544812000000b003adc4971336mr28584535oij.16.1697193947773; Fri, 13 Oct 2023 03:45:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697193947; cv=none; d=google.com; s=arc-20160816; b=AlWMXo5ulIDm9H/b3ndNMJC3GRvMd7DQiXDKQdTuIyIGUpTPwQG+Ez98KMAefMr7zS XOZWnFVg2rQMER+x/AmD2fRM+lta2duE8aQROrS0iCLHbYjudkrU4B/C4h7i7i7Y3tB+ Haia2mdEUbIDa9ybcE9JVuHltB4eHWKb1HbIj3Bgzjd6wZL015S+0rJVT8I0xM1i9zEX m4xPxkYIcgwwHLZbTkZXyNR5In6fJvPr31Ngn3HKyjh9IiW3OVfWCspR0rWu8oAvqZX4 fojowh1VxfvfkarCGLjrhtjAsvck8ghP6yyKZvQlLN81zQVl/S93+LMGQEcATRRv68bi mzdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=KnWJJC9xuHCBUi4iGN5hgTildyZdH+F8HRY+WxIVrPs=; fh=WzoYLxqoa8lWyl/oCXUw2Fn663LArCSyz9H2OCGp57Q=; b=LLmH2NzG4o2+3Jfq7TK8l3Y8OJh7H6rGV+51XrlL/MLmtGaIuspvfGOXM9FrbQvUDf SBCrR19WQJ2+VUp2KCDSgw23IUsSOa3ceNkKhIFyDZLZMjZKJjE+bH6N3dJbnyitYKA9 I2oqd2u9lTLSxO7EUsDWhcU16BWK9ObOcf30Eimca53I5294C+kJH9pn6NwiRiQ7ewql YtEGWFSzrMHvq4QNy9UUUnmIzYpGHAJUyBq7sRsQZ/yv4NcK69dWur/R/4/3sZgAcBPy gM0oK23awc7Wsw0hehO4+H77732AqRKyjtMzLEbmCCDf+yJxrSX2+R8A4tSQkmyZvpGp TV7w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id d1-20020a654241000000b0057c2f614756si4203550pgq.212.2023.10.13.03.45.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 03:45:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id EA18F8112460; Fri, 13 Oct 2023 03:45:43 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230453AbjJMKpV (ORCPT + 99 others); Fri, 13 Oct 2023 06:45:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230349AbjJMKpT (ORCPT ); Fri, 13 Oct 2023 06:45:19 -0400 Received: from out30-101.freemail.mail.aliyun.com (out30-101.freemail.mail.aliyun.com [115.124.30.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49247C2; Fri, 13 Oct 2023 03:45:13 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=xueshuai@linux.alibaba.com;NM=1;PH=DS;RN=15;SR=0;TI=SMTPD_---0Vu2-b8h_1697193908; Received: from 30.240.114.194(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0Vu2-b8h_1697193908) by smtp.aliyun-inc.com; Fri, 13 Oct 2023 18:45:09 +0800 Message-ID: <8e373bfc-3fa4-6de3-4994-b93f78699e2f@linux.alibaba.com> Date: Fri, 13 Oct 2023 18:45:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v7 3/4] drivers/perf: add DesignWare PCIe PMU driver Content-Language: en-US To: Jonathan Cameron Cc: Bjorn Helgaas , chengyou@linux.alibaba.com, kaishen@linux.alibaba.com, yangyicong@huawei.com, will@kernel.org, baolin.wang@linux.alibaba.com, robin.murphy@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, rdunlap@infradead.org, mark.rutland@arm.com, zhuo.song@linux.alibaba.com, renyu.zj@linux.alibaba.com References: <20231012162512.GA1069387@bhelgaas> <20231013094113.00003d72@Huawei.com> From: Shuai Xue In-Reply-To: <20231013094113.00003d72@Huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.1 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 13 Oct 2023 03:45:44 -0700 (PDT) On 2023/10/13 16:41, Jonathan Cameron wrote: > >>> >>>> + depends on (ARM64 && PCI) >>> >>> I don't see any actual ARM64 dependency in the code, so maybe omit >>> ARM64 (as PCIE_DW_PLAT_HOST does) or add "|| COMPILE_TEST"? >> >> I will remove the ARM64 dependency and add COMPILE_TEST. > don't do both. That makes no sense. either > > depends on PCI && (ARM64 || COMPILE_TEST) > or > depends on PCI Got it. Thank you. Best Regards, Shuai