Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <5258379d69957db51c5db6f3175898f41be67fc5.camel@kernel.org>
Subject: Re: [PATCH] NFS: Clean up errors in nfs_page.h
From:   Jeff Layton <jlayton@kernel.org>
To:     chenguohua@jari.cn, trond.myklebust@hammerspace.com,
        anna@kernel.org
Cc:     linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Fri, 13 Oct 2023 06:50:16 -0400
In-Reply-To: <2f52e71b.943.18b2705b8cb.Coremail.chenguohua@jari.cn>
References: <2f52e71b.943.18b2705b8cb.Coremail.chenguohua@jari.cn>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.module_f38+17164+63eeee4a) 
MIME-Version: 1.0
Precedence: bulk

On Fri, 2023-10-13 at 11:12 +0800, chenguohua@jari.cn wrote:
> Fix the following errors reported by checkpatch:
>=20
> ERROR: space required after that ',' (ctx:VxO)
>=20
> Signed-off-by: JiangHui Xu <xujianghui@cdjrlc.com>
> ---
>  include/linux/nfs_page.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/include/linux/nfs_page.h b/include/linux/nfs_page.h
> index 1c315f854ea8..6a3c54bd2c40 100644
> --- a/include/linux/nfs_page.h
> +++ b/include/linux/nfs_page.h
> @@ -122,7 +122,7 @@ struct nfs_pageio_descriptor {
>  /* arbitrarily selected limit to number of mirrors */
>  #define NFS_PAGEIO_DESCRIPTOR_MIRROR_MAX 16
> =20
> -#define NFS_WBACK_BUSY(req)	(test_bit(PG_BUSY,&(req)->wb_flags))
> +#define NFS_WBACK_BUSY(req)	(test_bit(PG_BUSY, &(req)->wb_flags))
> =20
>  extern struct nfs_page *nfs_page_create_from_page(struct nfs_open_contex=
t *ctx,
>  						  struct page *page,

In general, we don't usually take patches that just clean up whitespace
damage or stylistic problems. Doing so makes backporting harder as you
end up having to pull in extra patches to fix up minor differences
before bringing in substantive patches.

If you're fixing a real bug in the same area, then sure, go ahead and
fix up the style in the surrounding code, but if these patches don't
fix real bugs then I'd suggest not taking them.
--=20
Jeff Layton <jlayton@kernel.org>