Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <7b0a02ad-d23c-2c04-6672-58f16f2cca5a@ti.com>
Date:   Fri, 13 Oct 2023 16:40:56 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH net] net: ethernet: ti: Fix mixed module-builtin object
Content-Language: en-US
To:     Arnd Bergmann <arnd@arndb.de>, Andrew Lunn <andrew@lunn.ch>,
        Wolfram Sang <wsa+renesas@sang-engineering.com>,
        Simon Horman <horms@kernel.org>, Roger Quadros <rogerq@ti.com>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S . Miller" <davem@davemloft.net>
CC:     <linux-kernel@vger.kernel.org>, Netdev <netdev@vger.kernel.org>,
        <srk@ti.com>, <r-gunasekaran@ti.com>,
        Roger Quadros <rogerq@kernel.org>
References: <20231013100549.3198564-1-danishanwar@ti.com>
 <4a53722d-e31d-4598-a4a9-cf374c84bc44@app.fastmail.com>
From:   MD Danish Anwar <danishanwar@ti.com>
In-Reply-To: <4a53722d-e31d-4598-a4a9-cf374c84bc44@app.fastmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Arnd,

On 13/10/23 16:08, Arnd Bergmann wrote:
> On Fri, Oct 13, 2023, at 12:05, MD Danish Anwar wrote:
>> With CONFIG_TI_K3_AM65_CPSW_NUSS=y and CONFIG_TI_ICSSG_PRUETH=m,
>> k3-cppi-desc-pool.o is linked to a module and also to vmlinux even though
>> the expected CFLAGS are different between builtins and modules.
>>
>> The build system is complaining about the following:
>>
>> k3-cppi-desc-pool.o is added to multiple modules: icssg-prueth
>> ti-am65-cpsw-nuss
>>
>> Introduce the new module, k3-cppi-desc-pool, to provide the common
>> functions to ti-am65-cpsw-nuss and icssg-prueth.
>>
>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> 
> I submitted a different patch for this a while ago:
> https://lore.kernel.org/lkml/20230612124024.520720-3-arnd@kernel.org/
> 
> I think I never sent a v2 of that, but I still have a
> working version in my local tree. I've replaced my version
> with yours for testing now, to see if you still need something
> beyond that.
> 

I see your patch addresses different modules. My patch introduces a new
module for k3-cppi-desc-pool which is used by both am65-cpsw-nuss and
icssg-prueth driver. Where as your patch addresses modules common across
different cpsw drivers (davinci-emac, cpsw, cpsw-switchdev, netcp,
netcp_ethss and am65-cpsw-nuss). So I think that both these patches are
addressing differet warnings.

>     Arnd

-- 
Thanks and Regards,
Danish