Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp882233rdg; Fri, 13 Oct 2023 04:17:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFfWNbnwbMziOflwo/o1fva8a4nWHPOjLWqwUrqKbmITZr3NUWM3y1Oaj3DDkjK89gpt/T3 X-Received: by 2002:a05:6358:5908:b0:143:8c4e:283b with SMTP id g8-20020a056358590800b001438c4e283bmr32001946rwf.0.1697195821301; Fri, 13 Oct 2023 04:17:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697195821; cv=none; d=google.com; s=arc-20160816; b=rdJFy8Zh/vA1Mo7ReblZpODbmRDbwVLttjGAy48Of3txbrXyap5dNZyQClBm2icEo8 vsEaHnZ+IK2nVdBkzYYOALMZKZFs+ulqqWOfOv/CZkADw32bvbKjWyzZesnvDyeNOVMA vZguMg/5OWbpU1x27C7X+M55Wx9NVlP68L+lU7HgrbEGNbGetkn7n2g/jXmwFryeDiMb 3LsYC7PfhLQ7+zV2EoP/1xqWJcYdzBEbHRU+p0tO3xEdDja/pf9yz0azbdwSrcMXVmez pHN+AdpKNreqos/3YrI4slnOrO3A1h3LDN9UTtTBFDjZTdaeov9mPO10uglOckpgfHVg KKog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=jA46OFfZWE5nXbqzK1rBDGiSAqJladumXI0uqrd0S44=; fh=GyTSnN9PzTndE8CIRBGeGMEFE3LjiwkYtLZspqs0snE=; b=M5GVb4aJVW4FEXxyOEcHvlbViBR7h4INYX6dTflaH52qDMLo3MH4FsQeCPRTTjgiO/ 5nF+oqMnuaX07MGlNtfu1nQZEWTauC+MZsrCvqlatekFN6QaBgz4kX5gdU40A8Awf997 6zdeuMOO8zWiGSLSBU3rf95/YmXm4c6WdslIIeuIBAcd0gb0Au9Pm4NtXXThWfxWOJ8I 0NXRNc33j1rw3dSDqgjjSJr7ygWciQROSIsILCNvggtVKPOYAAZiTnX0JQ6eYX9E3C3Z Teug/6QQin4cON1zQfCx5BgKfGEwXUIR+Hy+mFw8PHAAc0aipt8I+dTVBOJPxYAL4PY6 Y4Zg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="UDPvni/A"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id f11-20020a056a00228b00b006b4d80642bbsi596249pfe.182.2023.10.13.04.17.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 04:17:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="UDPvni/A"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 58AF1807CED5; Fri, 13 Oct 2023 04:15:22 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230079AbjJMLPM (ORCPT + 99 others); Fri, 13 Oct 2023 07:15:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229721AbjJMLPM (ORCPT ); Fri, 13 Oct 2023 07:15:12 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31C55BE for ; Fri, 13 Oct 2023 04:15:11 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE638C433C7; Fri, 13 Oct 2023 11:15:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697195710; bh=jA46OFfZWE5nXbqzK1rBDGiSAqJladumXI0uqrd0S44=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UDPvni/AZVdMKTlO8s/IBEmavFAjqLDOaRcwMvA8tdAkQ8+fB/O3DzkNkzOtYMXpW dkx6vgxkMbpHPwbEL9x/F1yBPw8WqjJMOzQ9PH9OEmKrM+V42syJ83yeVeL+CAOdGe I6f+AihD+y26HPYtWFPdwnLhU8rR5OwxHmmE/R8cXqR3G0eEXY4paqAn+acP/PvlEp xsRzRqJNJ/Zb1y34jhlLM63lWMbVfhX9oOzVvlE3p/9ZFz2ZNsS0jf6oKVlVdxZEeA 5uwk6rorBxYU9JcTtdhchUVCixTShpqgJ68w+OQAU2jZeF0EiTBA6Vt3dcHJqgSxBL uWMXpoUjdmb5g== Date: Fri, 13 Oct 2023 13:15:05 +0200 From: Simon Horman To: Shinas Rasheed Cc: pabeni@redhat.com, linux-kernel@vger.kernel.org, davem@davemloft.net, edumazet@google.com, egallen@redhat.com, hgani@marvell.com, kuba@kernel.org, mschmidt@redhat.com, netdev@vger.kernel.org, sedara@marvell.com, vburru@marvell.com, vimleshk@marvell.com Subject: Re: [net-next PATCH v2] octeon_ep: pack hardware structures Message-ID: <20231013111505.GE29570@kernel.org> References: <20231010194026.2284786-1-srasheed@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231010194026.2284786-1-srasheed@marvell.com> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 13 Oct 2023 04:15:22 -0700 (PDT) On Tue, Oct 10, 2023 at 12:40:26PM -0700, Shinas Rasheed wrote: > Add packed attribute to structures correlating to hardware > data, as padding is not allowed by hardware. Hi Shinas, in the v1 you stated that this is bot a bugfix. So I am assuming, that by some happy coincidence, the layout of the structures is the same before and after this patch. And this patch is thus a cleanup. If so I think it would be worth noting in the patch description.