Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Message-ID: <840dab8f-f255-42b0-948b-cd740fb7d154@suse.com>
Date:   Fri, 13 Oct 2023 14:18:11 +0300
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5] x86/tdx: Dump TDX version During the TD Bootup
Content-Language: en-US
To:     Yi Sun <yi.sun@intel.com>, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, dave.hansen@linux.intel.com, peterz@infradead.org,
        x86@kernel.org
Cc:     kirill.shutemov@linux.intel.com,
        sathyanarayanan.kuppuswamy@linux.intel.com, kai.huang@intel.com,
        linux-kernel@vger.kernel.org, heng.su@intel.com,
        yi.sun@linux.intel.com, Dongcheng Yan <dongcheng.yan@intel.com>
References: <20231012134136.1310650-1-yi.sun@intel.com>
From:   Nikolay Borisov <nik.borisov@suse.com>
In-Reply-To: <20231012134136.1310650-1-yi.sun@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T2dsK3NnV1pQd1ZqV2VkQmpabE1yeTd6MHpGc1M1MW1JanR4YjF4aXJZQmI5?=
 =?utf-8?B?R1ZLTW1GeXIrRnJGMXZOWUM4MUMra1pYRitSU2NKTlFoaVBMTDBoa25XeGhO?=
 =?utf-8?B?OGJpdU5Qd2JidURtSXgvNTA1dTE3bWl2S3EzNEpXa3g0TWIrTzRkZ3U3Y3dV?=
 =?utf-8?B?akRkS3cxUzRpR2RVMFlkOWd0UTFKQ2tFb3BwdDVYOThRbk12d21hSjJudDhn?=
 =?utf-8?B?WFlYbVRaWVFZdVR0R0NaK0c2K2lRSDFlRHlMV1ZXcjkrazU0YW5WT0hOdlBG?=
 =?utf-8?B?TzQ5V05ETTBIVHRMcy96N1gyTW9LMW1kTWxwbG9wcDNQNnRrVHFDTjlGRFVF?=
 =?utf-8?B?SXU0ZVMxdkk3a1NLVUYvM0VkSmhoNUxZakh3QUVNMkRGb25TQVFESUU2Y3FX?=
 =?utf-8?B?TnpWRjY5c3JLdm9TVllFVWhQT0tCdlFzVi9yTlZWa2lFYXZ2dHJUbnVSelZv?=
 =?utf-8?B?QlpyM3JmbjBTNFEzbmVTV0Z6bTdtVklKRmp2ZXR0ZElCN1hRSWN5a0FlYjg3?=
 =?utf-8?B?ZlY0K0tSbEhaNmJHVDJEMytGVHNIN3FEVVBnWWhBUEd5ME9DdWVZRXlxWnVq?=
 =?utf-8?B?SWNZVVVHUFB6MjBzMTd6cjBmSTRhWit3bXZMczJyVWZDMXBqcnJYNUFoYzJm?=
 =?utf-8?B?cE1pcVJaOW9Wb1EyZ3BwT24rVkl4cGFnaHdpQ0VKOWVRbStQVDdMTXlWa0Y2?=
 =?utf-8?B?djJ2QW9FYjNxbktTalRpR0ZPNGRmeFRaaUdxZnZZSFp5VFZSdHFiOU1qM29F?=
 =?utf-8?B?YmFKcm93MUkyMGJnUmJxWUtKdlVlU2RFSm0vaGttY1RBZmgzZWw5UE42U3o0?=
 =?utf-8?B?Mk9OcWxaN0s5QnByWXc4YUdMK2NkaE1ucUtXREpLR2JkaCtkRU1rRVBzRmJh?=
 =?utf-8?B?VndXMnBYKzExUDNvWnJobmE5cjc0a1grbW9pQmx3T3ZtT0Nleno4WDh4Mi9u?=
 =?utf-8?B?K0w3Y0pOWXp1bkRyazNTeGVodG5MeGFKbE1NajMxYTQwNDRvRGdmdWN2SmlK?=
 =?utf-8?B?eitXOG1GYndmNnk5eGZlVEVYNkN3ZjFWSE5OOWpHTXpjN2NGMDVsQUthaUIw?=
 =?utf-8?B?VFhlT0ptQlhBWGJpY3V4S1VhNlNjUmxSQnh5dE9GK0pzYlRMbm1wSTVOYjhQ?=
 =?utf-8?B?ekxPemdxcFBUVkZJVU9Mb2FveWF3dzR6YTNwWVkybVAvQ0NHS0RITTVFeC9R?=
 =?utf-8?B?dXdhNXhaVkRGUlJ6aHpwa2dPekJpdUg0KzExSnZBb3hrcnhuQzJtT1pydzFs?=
 =?utf-8?B?NkNWa3dPdnlVdVZOWk1QalplSTJLeStheGo0eU9JT0xuK3BvVUQzeGN0Nncx?=
 =?utf-8?B?ZytianFUQVFWd3l2ZjhFdnhCeVRJUlJ3NkFnc2VmaUJNN3BvdUhzQklYajJF?=
 =?utf-8?B?ajhsdFBQbERGSk13ejA4NTZQRHVucXdySVFsU0xvdTVOZnhvNTRuQ0NZSVVF?=
 =?utf-8?B?VFZidDhZODdIODNBeEV6R2ZVOFJNeHNuempiM0xwR2REaFlqbWZGeE8zM0t3?=
 =?utf-8?B?NW5hWHd0TGtUa3FFTW5OVE8yS2Fyay84ckEwOENIN1E2alJpWXZSZW90V0Mx?=
 =?utf-8?B?cFhOelc4dk5vVmk4MTdXRFA4dDVvTm1EQjdWb3BzM0EyMEdFUndubVhnUUxE?=
 =?utf-8?B?YkJxWkhZYnlGekErZmNNcG1mR2h2ekUvemxrTjBoL1djQVdBSzdZR0NGQmd3?=
 =?utf-8?B?TXdFSEVtN0Y4cFMyN2pucVRhOHVUcmFraVNDN2xOQmswUVFoSFRjb0x1a0k4?=
 =?utf-8?B?bk1aeER5K0d3TEloRmVNb0JTWlJrb2hYOUdTQVhGYjlCYlpydXhYWDRnV3M1?=
 =?utf-8?B?ckFoNUk1U2xlQVljLzVtcmVEV2lzZE9nTVZYeHV1WHJhMmZEeUpLajMrRldQ?=
 =?utf-8?B?d1NBS1FzTC82KzdjeEdqZkUwWkxhbGZVL3VVOXBlclMvc2JmaFB3bkNWUHVF?=
 =?utf-8?B?SkZpdEZLb2dpczdFWUlVYXozWW9QdVRCTllnMlJXRlIrWXNjSDZwclczMGlW?=
 =?utf-8?B?Zk96VVoybGZka08yN1VNelI2eTRLZFM1bnZtSE9raWVnblgvODZFY0RjcUNC?=
 =?utf-8?B?ZkR2b3FRQWJ4N05XdDV3V3k5VUJJU0V1ZHJ3K3dvUU9NZkw2NWI2OG02MTdk?=
 =?utf-8?B?WGMvVWNkUWMvY2ovMzUydEcwK0dvWkZXaCtXOFp2Yi9ld3hWSmkrbDA4Y3NC?=
 =?utf-8?Q?x6zYTWM1up2EnoK5JEkb6UbInVUZuG6Up3OmD5N5dgCv?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ff806780-c3c1-4609-026d-08dbcbde1743
X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB7790.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2023 11:18:13.8822
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9KYXF+PpRdV5rEAnEK7f53RM7wfQyW1BFwnt8jjPUjqO7pvL8qpXHQ2YKwnAL/r45i6CrR/YRFSwcDF9U3ZwcA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS5PR04MB10058
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 13 Oct 2023 04:18:28 -0700 (PDT)


On 12.10.23 г. 16:41 ч., Yi Sun wrote:
> It is essential for TD users to be aware of the vendor and version of
> the current TDX. Additionally, they can reference the TDX version when
> reporting bugs or issues.
> 
> Furthermore, the applications or device drivers running in TD can achieve
> enhanced reliability and flexibility by following the TDX Module ABI
> specification, because there are significant differences between different
> versions of TDX, as mentioned in the "Intel® TDX Module Incompatibilities
> between v1.0 and v1.5" reference.
> 
> Add function detect_tdx_version to fetch and dump the version of the
> TDX, which is called during TD initialization. Obtain the info by calling
> TDG.SYS.RD, including the major and minor version numbers and vendor ID.
> 
> The TDCALL TDG.SYS.RD originates from TDX version 1.5. If the error
> TDCALL_INVALID_OPERAND occurs, it should be treated as TDX version 1.0.
> 
> Reviewed-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Co-developed-by: Dongcheng Yan <dongcheng.yan@intel.com>
> Signed-off-by: Dongcheng Yan <dongcheng.yan@intel.com>
> Signed-off-by: Yi Sun <yi.sun@intel.com>

Reviewed-by: Nikolay Borisov <nik.borisov@suse.com>


<rant>

Intel really outdid themselves in creating the most horrendous document 
to read/comprehend aka tdx's 1.5 ABI ...

</rant>