Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Date:   Fri, 13 Oct 2023 13:21:26 +0200
From:   Andi Shyti <andi.shyti@linux.intel.com>
To:     Calvince Otieno <calvncce@gmail.com>
Cc:     outreachy@lists.linux.dev, linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Luke Koch <lu.ale.koch@gmail.com>,
        Bagas Sanjaya <bagasdotme@gmail.com>,
        Simon Horman <horms@kernel.org>, linux-staging@lists.linux.dev
Subject: Re: [PATCH v2] staging: wlan-ng: remove helper function
 prism2sta_inf_handover()
Message-ID: <ZSkoNhWDxntTbGpm@ashyti-mobl2.lan>
References: <ZSkg7y2Y2T3midXB@lab-ubuntu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZSkg7y2Y2T3midXB@lab-ubuntu>
Precedence: bulk

Hi Calvince,

...

> @@ -1697,7 +1697,8 @@ void prism2sta_ev_info(struct wlandevice *wlandev,
>  	/* Dispatch */
>  	switch (inf->infotype) {
>  	case HFA384x_IT_HANDOVERADDR:
> -		pr_debug("received infoframe:HANDOVER (unhandled)\n");
> +		netdev_dbg(wlandev->netdev,
> +				"received infoframe:HANDOVER (unhandled)\n");

but then you generate this:

CHECK: Alignment should match open parenthesis
#240: FILE: drivers/staging/wlan-ng/prism2sta.c:1701:
+               netdev_dbg(wlandev->netdev,
+                               "received infoframe:HANDOVER (unhandled)\n");

total: 0 errors, 0 warnings, 1 checks, 9 lines checked

:-)

Make it a habit... before sending a patch check it with
checkpatch, in order to be sure you are not introducing other
checkpatch errors.

Don't rush... take your time, check your changes carefully; use
checkpatch, compile test, run sparse, etc. Give others time to
see your patch and comment.

Andi