Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Fri, 13 Oct 2023 13:41:14 +0200
From:   Maciej =?utf-8?Q?Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>
To:     Shuah Khan <skhan@linuxfoundation.org>
CC:     Shuah <shuah@kernel.org>, <ilpo.jarvinen@linux.intel.com>,
        Reinette Chatre <reinette.chatre@intel.com>,
        <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 1/8] selftests: Add printf attribute to kselftest
 prints
Message-ID: <wi5tm3bir2ht3geaaa544wem45x5gcl5qm7yqct7xsvnufk5fv@ujcvvbexvi5e>
References: <cover.1697012398.git.maciej.wieczor-retman@intel.com>
 <13a47130763d109aa40de153ecbee9ede22d8356.1697012398.git.maciej.wieczor-retman@intel.com>
 <a2a5cb05-8604-4303-9802-573359c68368@kernel.org>
 <4h2eu6yhodrujbvem24v7cwal5tnk2agsqulpxwi4myk7n35uq@phbxlajivrpq>
 <fafe90f3-5612-4dac-8ca7-4f0d0d6a05f7@linuxfoundation.org>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <fafe90f3-5612-4dac-8ca7-4f0d0d6a05f7@linuxfoundation.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?a9E+cOY7N6H6OHKxRlxz2LiEKP+Mat40/bY4MmLW6WqtXTpzTO0zKDsUW+?=
 =?iso-8859-1?Q?onmlnT2bPfekKpzqAX6iBo623U21SmUyiGs4ymEhxu9WnvFklC4gyxRZJd?=
 =?iso-8859-1?Q?eq5BKDCPU+5CbAgx2AVKegkc+hP1fBfuo+FxQNZpjKt1VWt/CCVIl4YXI2?=
 =?iso-8859-1?Q?fP5mW8O+qy14RiojlOovBQKWdXqBa+EvXo8YLT2DEQDjdBaiDKe1iy9oTV?=
 =?iso-8859-1?Q?VC6yyEdRtyT82BGcn4DgDBqHNajdVhY9An8510/LixrFMDcwPjlSaMKvkQ?=
 =?iso-8859-1?Q?DmimwNrC8DzFk67wC2Evq6JMHFcs1g+MCfZqmvrELGqbRz+HySJx9A37SB?=
 =?iso-8859-1?Q?Evok3XTBV5Sp/AKYOmAzR+MX2OjzjFQL6YGP5PhiZHeH+ZT8Hz3fYVfmE+?=
 =?iso-8859-1?Q?BFagTm2q8CdJgCwIfZv3TuGmNRCoW5rp/qUzliP3w33DLVWQQL4eDHANrG?=
 =?iso-8859-1?Q?L3Y8n/JFLy96QX7uQo1lucvi3ThL4TTgtpm1L4oWhXqQ9ON122hPSvw+tt?=
 =?iso-8859-1?Q?/GgIL1K4nM8XzJegeasgQOVOAJmCCAuOyzxwIhQ+evBWs8Dd6mOwcX9Wcc?=
 =?iso-8859-1?Q?kHDdU4JIoedzGbzwdNyDHh4yZR8YwaBAGz23nFdpHrV+XR34hWBDtGZVns?=
 =?iso-8859-1?Q?gtX7REIyaVL6kvAJxUziHeLBF9NLox3cmc6y6CqaFuZjrf/M03kkKsWhcb?=
 =?iso-8859-1?Q?bWS2/0mPj7wXirtb25YF8vi1cM7DSYIeRgBbd7PBQFA20XhjPrLcD2yzTF?=
 =?iso-8859-1?Q?ugQEKvTS8b/2H66VhQBOpx6ELOSP/hfGd5MiB7hKp3qJr+3bn5vnUM4DgC?=
 =?iso-8859-1?Q?3PwazUUkTgWzmwcwRhIF5B/QBo2Co812q44M8A8mps3uKyfopcjFHs7Ay2?=
 =?iso-8859-1?Q?Wds5PHWYonXtkaTIm3Ycvt8fIEghIVkIhtzH0HDuDR39zsxR+nWwyh8qk+?=
 =?iso-8859-1?Q?3RK4Bsaf/vcmfeXuIOyC2MqUwYeo6hyDjT5CbIHEjX/0ytfk7xz7G8nOHn?=
 =?iso-8859-1?Q?b/HNQvkKOmk0fSgcEl2NKdKhUVrxdOp3PSnkCN0svc+G9fgaHOr7AhKdNA?=
 =?iso-8859-1?Q?HVk2PZmZVbzZcIEu2naZcjakX3sAL1nRgHThwrsw0o7pvASupz3p4RIJui?=
 =?iso-8859-1?Q?+Zzw6EoRyC1Q7sPTTO6j3DqouiTR3Rfr0Bo1ZtnLssa3cYQQdgGVacneSO?=
 =?iso-8859-1?Q?DVnH6Kn/UfJIx+vT1F/c3jZfOWwvrwvly4hzulFcpiswBvZ0w+c8/StLQl?=
 =?iso-8859-1?Q?C1BhXEvVgTqoUNGgp2Z4J0EEUPGaSITxz/AKwcXOe1vWpfjCR1y5fUjgss?=
 =?iso-8859-1?Q?JQQyTZcuiuRLVrUDyF3K5bOJ6I9HZps+1fjitgxL0/eJkDOiwWQw7830b6?=
 =?iso-8859-1?Q?dPcWqZGfjck2nUGLK+2aYuVmCrBlKRCmJfgbLsHrRUVxFzONdaoc2GUcz6?=
 =?iso-8859-1?Q?A5aIsxoXzTyNucJwdSRKekUKLFzjVzl5DFR9/GpXPBcQOGOfcUoSqM7Xvy?=
 =?iso-8859-1?Q?mi4j6w60gFdeZv+7Zc//1Xkiznb9zJpfV0Um3z3YkWPzNbWg/DAA5rb2d+?=
 =?iso-8859-1?Q?7vo4YFnysw4FwXkssapdu8aprhNoFpWIoGVPGERVVJyIeyKTrNrogWcd00?=
 =?iso-8859-1?Q?Pk9uC3+j9LHLHVpP0s3z+uS9O1Sp6QFzYC+Zn1Sammf4svQO+9TogyMLip?=
 =?iso-8859-1?Q?lIexFY9ZUGYlZdQxU38=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fda36698-e4f5-4267-231c-08dbcbe152d4
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6231.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2023 11:41:22.2160
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5/PB+LafledHjt2v6xf5fFYWNo0xhY3q4OfBGwjTryWhU1/KDkmIBf2mdvDVbelSXN33lCNMzpxLV/CWzF2oGtEOZlRbEaxnhneV+SLmfmY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6218
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 13 Oct 2023 04:41:36 -0700 (PDT)

On 2023-10-12 at 08:30:37 -0600, Shuah Khan wrote:
>On 10/12/23 01:32, Maciej Wiecz?r-Retman wrote:
>> On 2023-10-11 at 13:40:48 -0600, Shuah wrote:
>> > On 10/11/23 02:23, Maciej Wieczor-Retman wrote:
>> > > Kselftest header defines multiple variadic functions that use printf
>> > > along with other logic.
>> > > 
>> > > There is no format checking for the variadic functions that use
>> > > printing inside kselftest.h. Because of this the compiler won't
>> > > be able to catch instances of mismatched printf formats and debugging
>> > > tests might be more difficult.
>> > > 
>> > > Add the common __printf attribute macro to kselftest.h.
>> > > 
>> > > Add __printf attribute to every function using formatted printing with
>> > > variadic arguments.
>> > > 
>> > > Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
>> > > Reviewed-by: Ilpo J?rvinen <ilpo.jarvinen@linux.intel.com>
>> > > Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
>> > > ---
>> > > Changelog v4:
>> > > - Fix typo in patch subject. (Reinette)
>> > > - Add Reinette's reviewed-by tag.
>> > > 
>> > 
>> > I still need information on how you found these problems. Please
>> > add it to change log for each of these patches.
>> 
>> Sure, I'll add notes on methodology to patches 2-8. I understand that
>> this patch (1/8) message doesn't need that addition since the problems
>> it exposes are in separate patches.
>> 
>
>Yes please. As mentioned a couple of times, I would like to see how
>the problem is found in each patch commit log.
>
>> Or would you like me to also note here more specifically what effect it
>> has in the rest of the series?
>> 
>
>Yes please.

Thanks for confirming. I went through all the patches, made corrections
and sent v6 of the series.

-- 
Kind regards
Maciej Wiecz?r-Retman