Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp897218rdg; Fri, 13 Oct 2023 04:48:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHS93KrI0d0/z8SCTTQ/og82DvnZ4q98kYAnj5aaLIFc6GLNHUfwg0r/rPo0ENLhGYpaSYo X-Received: by 2002:a05:6870:ab09:b0:1e9:f1cc:a415 with SMTP id gu9-20020a056870ab0900b001e9f1cca415mr404859oab.57.1697197681244; Fri, 13 Oct 2023 04:48:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697197681; cv=none; d=google.com; s=arc-20160816; b=udylMHfdj6zYFkuY4Y87OAiKhUYxcvHHgiqSe8JJ4y6f4Z2rYy8VXExxCVRSluWP5l cpNb/B20gXR54E17iObUo3aJjt25oY4RD0H9mwvWIjon7noFnNMnxbEcbaG/RzcY7Fqr JfGGWBbW+LUX5Nee+GxDYLQn5GQyzLJTKV8G6TTyK/1LXC/c4dojG4Hm2KqfesOx04Cg sneps4ahuLbiuUOSkHevf++z9BpOwmNJElAYBjelVSovqR+6ctEgAs8E3RbGhUb7QW/a f6yajzvEiKIRCtcdmPKdrhYSKgFby/CatDORmHbZX/g3Y09oH7KHJwoZXMPA32wkDRhU 0cRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ewEHSqQMWTRY8k1T3DhmSmlMCaDgGvUhjwLsPbhhbms=; fh=XwgmiuB4xar8mGTRgUuUv0pGAcucrVmSLji4unk9dA8=; b=iQWdqbMlhZzy5IH6gXcaiDI6hOCL7EGL/DxOa2WhTjaqoTdoLw8BC8xx7To+dhtkKH KwYW0NHMYqbC0YjnQo+i4bLeKxCoAx4Lc+J5ykNLkgHZUGFRyZg6hkzTwN6XA4mQt7Au aQnbsnl7ah5QZrSwRpGts9RaMC55MoRoLNUPXNwPJ/lzvnqlWGO+PLms/zBUUPm2XcYL ZR8IPYqN65o4kOStsnlpYv8TW5emKszzTBsF6tfJ0pNFdL1n0g2WY5tGfBA+rZsKtzv7 ptJaijrqgI80M5UPkXWejSenEG0iABwem78sRhkYY02cUVh893zcxYt/UB3MJ3JKm3If QeeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=JiQL9f4A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id e23-20020a630f17000000b00565eb0b2e66si4276424pgl.864.2023.10.13.04.48.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 04:48:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=JiQL9f4A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 5F41C80C280E; Fri, 13 Oct 2023 04:47:57 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231319AbjJMLrv (ORCPT + 99 others); Fri, 13 Oct 2023 07:47:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231161AbjJMLru (ORCPT ); Fri, 13 Oct 2023 07:47:50 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFC9FBD; Fri, 13 Oct 2023 04:47:48 -0700 (PDT) Received: from obbardc-t14.home (unknown [IPv6:2a00:23c8:b70a:ae01:c2e1:3bb7:ed5c:6a0d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: obbardc) by madras.collabora.co.uk (Postfix) with ESMTPSA id 2144A6607357; Fri, 13 Oct 2023 12:47:47 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1697197667; bh=qnEq8Sp9V5HwTo+4/aFGw2RoRPviwf6K6ml/tXqx2No=; h=From:To:Cc:Subject:Date:From; b=JiQL9f4Ayn30azENa7+igcoAIQ8NfZVhzBwjA7B8zBOpHkw9R8ycMAMRXIWUYryBg VRBJ0ZOJtlCJ6kUaCmoVLgZaQiSPluFz7xJ35xZRN2t75JRsHHxLl3s+mj0eIDhxfn emLlFw+8Jc08eZnnb4vLxWhAj7aPYPNrzL2m5ZPgTBgCcnWUgyco0iszgf5QKUCHOp 6+7l+LDfaaOlOZd5U5ZW3yI63AS2dTrvUi/BklPTjSL9QA/Jbx4NyawVidQlJs3GdG akgQJL1VjiHa35R+2KxAaeUUXUWRkht6v0K6M6GXzStP/+6gIwgpu+wbletEp4Pp8C TWiFjyZcNFl/w== From: Christopher Obbard To: linux-rockchip@lists.infradead.org Cc: kernel@collabora.com, Christopher Obbard , Arnaud Ferraris , Brian Norris , Caleb Connolly , Conor Dooley , Corentin Labbe , FUKAUMI Naoki , Heiko Stuebner , Jagan Teki , Johan Jonker , Judy Hsiao , Krzysztof Kozlowski , Rick Wertenbroek , Rob Herring , Yogesh Hegde , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 0/2] Fix i2s0 pin conflict on ROCK Pi 4 RK3399 boards Date: Fri, 13 Oct 2023 12:47:25 +0100 Message-ID: <20231013114737.494410-1-chris.obbard@collabora.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 13 Oct 2023 04:47:57 -0700 (PDT) i2s0 fails to probe on my Radxa ROCK 4SE and ROCK Pi 4B boards with: rockchip-pinctrl pinctrl: pin gpio3-29 already requested by leds; cannot claim for ff880000.i2s rockchip-pinctrl pinctrl: pin-125 (ff880000.i2s) status -22 rockchip-pinctrl pinctrl: could not request pin 125 (gpio3-29) from group i2s0-8ch-bus-bclk-off on device rockchip-pinctrl rockchip-i2s ff880000.i2s: Error applying setting, reverse things back rockchip-i2s ff880000.i2s: bclk disable failed -22 This is due to the pinctl attempting to request a GPIO which the boards use for a different function. The first patch adds a missing pinctl node i2s0_2ch_bus_bclk_off to the RK3399 devicetree. The second patch sets the i2s0 pinctrl to use the new node when idle and fixes the issue. Christopher Obbard (2): arm64: dts: rockchip: Add i2s0-2ch-bus-bclk-off pins to RK3399 arm64: dts: rockchip: Fix i2s0 pin conflict on ROCK Pi 4 boards arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi | 1 + arch/arm64/boot/dts/rockchip/rk3399.dtsi | 10 ++++++++++ 2 files changed, 11 insertions(+) -- 2.42.0