Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Fri, 13 Oct 2023 20:05:52 +0800
From:   Hongren Zheng <i@zenithal.me>
To:     Shuah Khan <shuah@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Valentina Manea <valentina.manea.m@gmail.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        sfr@canb.auug.org.au
Subject: Re: [PATCH -next] usb/usbip: fix wrong data added to platform device
Message-ID: <ZSkyoFkBKPavk6Jg@Sun>
References: <ZSkhWa5wmAGsAdCK@Sun>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZSkhWa5wmAGsAdCK@Sun>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zNK6bJDgXLTC/r9uPL3B0T9Zqjw2cQleTYkxZsGmyt/BKeJzYPX7wYeh+XNC?=
 =?us-ascii?Q?EYC3c0KdFZC+MHkzJO332RW6cpishrZ5s8IpXeocGTEDuA6MVTc/n8Ykw7pq?=
 =?us-ascii?Q?xWvvxepTV3lflNyLozqUa3MgZFga7GDSHpmcuxzXHR2jMWV8RXdVXTSPqlgd?=
 =?us-ascii?Q?qawMxfS3LXVEalPVXnP6uX3avp5vFzBCsAiM4yRNXvV2rLWQepnawWXV2e/q?=
 =?us-ascii?Q?UvzPXI9TmldKFH9ED9pOpGVxzs6MYAppqlFKTOJPZT7gAU5Li78HyPGzTLja?=
 =?us-ascii?Q?JqXL0IBSJO4oano1fOxs1uhpq6Y2fePpQI3buVuK6yOKc1K+36oNfLg4jXO9?=
 =?us-ascii?Q?sjDWeyPg4pPJON7EJITqH7JSz9L2sUxHO+lFEp/bmuTPtgIJEsMHVk+Wgbne?=
 =?us-ascii?Q?MM+80L3N0a+clWABkvNdjZcaCrmjHVpR+DnoudJVn5EGzxU6NtoJ81L3ScXD?=
 =?us-ascii?Q?nm5Iaz6uRwHfHxdrJmDFtVtrE6FSjoR/nsbV3OobXGrnNhp6b9jpuxER3WCc?=
 =?us-ascii?Q?GYkjsdjXDkkPQ7ENyOlbQ4M8sa0oGU8v7D+9gn0OUMwFd2N6zn0AfTE7SPoK?=
 =?us-ascii?Q?m344iQLLdOJnQmKEwrv7wSGaEXXur26vYwVEhw3zvffL9VvWl97wTfvGoPsR?=
 =?us-ascii?Q?C0G+lP3cH+wze222lQuBgJlEfw5epkvfx5NWrDu95rNi8VXi3CgPm63n4K5V?=
 =?us-ascii?Q?7bWHO8p6YfYIkFKEMXGBFQkMgWshmAn5JYMDWqJg7u0ixL6TKUSWSps1vqLx?=
 =?us-ascii?Q?ueLyBdTsjs8tFrhGaezwxLg/RhTWx4RKFBw6fc5kmWFEnj6vOoG52e68yOBA?=
 =?us-ascii?Q?QKUeb329C4To5/bikZ78pcFUEcUDiI4aYWChsrBPgclewJSo+1Y5Ev7K7/CN?=
 =?us-ascii?Q?5IG9sT7kduhwyf9WNuPZjcnZ+DnyM3++rdydtfyCUEbo5JZV9AedeCUcZFrM?=
 =?us-ascii?Q?eodKWw/mInWtgrcGKsKwXfvOO/6w3ZWkg3mVg4eJGYtqG1rHfBw3GfkdlP3q?=
 =?us-ascii?Q?B4Q2fTcop7DrpxanpBZarrg4+Haatja/vTQcqjB6wzo8cPpskHheRjup8WJO?=
 =?us-ascii?Q?V2ikN7Vxdb649gy0tv/ImE8SeinvZMwjZkOK1xSzgd0rqarMaFB3lxzmTLvd?=
 =?us-ascii?Q?atwkm9XPgwLfn3Ciu+nMcQUkqhzMmM61xjToTnPPvV/a4ON5yrx+lfZnRWEy?=
 =?us-ascii?Q?mJjFLYtpjoZiRzniISvysI4kEaAtT16nzwd7PVw4HL5jrRt3OLTpYqwLH7s1?=
 =?us-ascii?Q?W4wKu/zdw38SHfXGZAKpF+pP9tIIM2WfZB8nCgZpSdyCmuLO41/th+tRXhBl?=
 =?us-ascii?Q?Pn8x0dNscGMAup04oGhoBHgW1mWi5x8eNwiB3aLP0PplnXvgrXqEICnXvi3V?=
 =?us-ascii?Q?ITajRU2Ow/mzAPEx6BqwbLyd5T54g4lUqvqTy3ID21+BSeao4wHW0bfstTl8?=
 =?us-ascii?Q?hb0A+mL0tvd/8UT5xHS3E6phtVtUZrk440otownyIGAcbTlkLHj8UMFmviCV?=
 =?us-ascii?Q?XSgU7gBQxBVxeWFGiaf0cJ8eQZRLsez84KfIHxtlDJV7Veqe7yw8zj4bHmrZ?=
 =?us-ascii?Q?97JeoIQruizSZB14VePlp9fpwNIZkVMBpQmToBrK?=
X-OriginatorOrg: zenithal.me
X-MS-Exchange-CrossTenant-Network-Message-Id: 6a781a3d-b16f-4a7c-b951-08dbcbe4c376
X-MS-Exchange-CrossTenant-AuthSource: TYYP286MB1406.JPNP286.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2023 12:05:59.6538
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 436d481c-43b1-4418-8d7f-84c1e4887cf0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DxHkdybgvKDKwQ1QwJhX3BdZSkFDUA56DojRJWzMmjrcztt8fgDkiD+eIwL35Fjp
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWP286MB2601
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 13 Oct 2023 05:06:25 -0700 (PDT)

On Fri, Oct 13, 2023 at 06:52:09PM +0800, Hongren Zheng wrote:
> .data of platform_device_info will be copied into .platform_data of
> struct device via platform_device_add_data.
> 
> However, vhcis[i] contains a spinlock, is dynamically allocated and
> used by other code, so it is not meant to be copied. The workaround
> was to use void *vhci as an agent, but it was removed in the commit
> suggested below.
> 
> This patch adds back the workaround and changes the way of using
> platform_data accordingly.
> 
> Reported-by: syzbot+e0dbc33630a092ccf033@syzkaller.appspotmail.com
> Closes: https://lore.kernel.org/linux-usb/00000000000029242706077f3145@google.com/
> Reported-by: syzbot+6867a9777f4b8dc4e256@syzkaller.appspotmail.com
> Closes: https://lore.kernel.org/linux-usb/0000000000007634c1060793197c@google.com/
> Fixes: b8aaf639b403 ("usbip: Use platform_device_register_full()")
> Signed-off-by: Hongren Zheng <i@zenithal.me>
> ---

Tested-by: syzbot+6867a9777f4b8dc4e256@syzkaller.appspotmail.com
Link: https://lore.kernel.org/r/0000000000007ac87d0607979b6b@google.com/