Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
MIME-Version: 1.0
References: <20231011051117.2289518-1-hezhongkun.hzk@bytedance.com>
 <CAKEwX=OBYiH+G17YLRvEhx2Ode6q_hc0NgR6ZisBD_h0URcgSw@mail.gmail.com>
 <CACSyD1N6PPJCJ6TCTGijRKGEf2bGm+3mBLfr=DwCKgy+7-PBEw@mail.gmail.com> <20231012142203.GB470544@cmpxchg.org>
In-Reply-To: <20231012142203.GB470544@cmpxchg.org>
From:   =?UTF-8?B?6LS65Lit5Z2k?= <hezhongkun.hzk@bytedance.com>
Date:   Fri, 13 Oct 2023 20:59:16 +0800
Message-ID: <CACSyD1NYD+JvLSLj-y2c0qdjn2SrTTB3uuezoEjNOPzWkAW0qA@mail.gmail.com>
Subject: Re: [External] Re: [RFC PATCH] zswap: add writeback_time_threshold
 interface to shrink zswap pool
To:     Johannes Weiner <hannes@cmpxchg.org>
Cc:     Nhat Pham <nphamcs@gmail.com>, akpm@linux-foundation.org,
        yosryahmed@google.com, sjenning@redhat.com, ddstreet@ieee.org,
        vitaly.wool@konsulko.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

>
> Can you use memory.reclaim itself for that? With Nhat's shrinker, it
> should move the whole pipeline (LRU -> zswap -> swap).
>

Thanks,  I will backport it and have a try.

> In many instances, swapins already free the swap slot through the
> generic swap code (see should_try_to_free_swap()). It matters for
> shared pages, or for swapcaching read-only data when swap isn't full -
> it could be that isn't the case in your tests.

Got it. Thanks for your reply.