Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
From:   Niklas Cassel <Niklas.Cassel@wdc.com>
To:     Daniel Wagner <dwagner@suse.de>
CC:     "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] nvme: update firmware version after commit
Thread-Topic: [PATCH] nvme: update firmware version after commit
Thread-Index: AQHZ/dWF0dRhBN2aLEGNUx8fLCrV/A==
Date:   Fri, 13 Oct 2023 13:02:29 +0000
Message-ID: <ZSk/5Fubv+BYPQ3z@x1-carbon>
References: <20231013062623.6745-1-dwagner@suse.de>
In-Reply-To: <20231013062623.6745-1-dwagner@suse.de>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?p2CQKyqxAUriglKrm2vKTzaYYaxnT6NkHpnv+SNc1E/yha9D4WVdU2SYR4QE?=
 =?us-ascii?Q?1jHmdsGEXASeV1/byFlUxGPGWUImm+ZGsUZG36rx0f7ZCy6enPRcWsI5cp/W?=
 =?us-ascii?Q?v2ZgF31ig4Fe2qJQb/lj45D9rDTQJ93de7RO6ZnSCD6z5r2g6LnHs1dJN1Da?=
 =?us-ascii?Q?X742jgkfmaK8ZRj6GOQywMbhz6awuQgNvCckYNnumZ0pq9fq8yUWGerYVywO?=
 =?us-ascii?Q?ExaLUAwzQHZHSZQPiq3mK6zBoTn0jPBWpFbfmi0dOY15kti4xdskz2zFrdIo?=
 =?us-ascii?Q?Eob8DME7iMp95iZCK4dhTsG8Dqc7x07Ga1bVjjbRAqAU5ju9E0SCpMsyJDF+?=
 =?us-ascii?Q?8SHnNCD+i6+uzkPAkRv6bkHi+hZBeKYrPIUmUWvBq1KUnBo8RizTdTOpjCoM?=
 =?us-ascii?Q?VtkuKRanrzoeFPIJyft2m/YK1BfGQzIjjm9+O/2aBHqnbro2rvCa0gkNQyOk?=
 =?us-ascii?Q?MjX6zVY1NqHoTKgflagy5Mgsxh06W6PN7bN0gHOufC04lz1P1WbqKwOgKyVE?=
 =?us-ascii?Q?KGAHfJUUmJ8oifyGP1cPbAt8NknnDakw4ZuNpR0kt+Ga9RclHtuHJSb4G+uE?=
 =?us-ascii?Q?TVpYop0NNoBrMmPXR4K7vREYUteD8hfo4aDH+IyRwALTfeJl0s3BADUCYSm1?=
 =?us-ascii?Q?vSQYW8LNUDHHyld0AJUA0oFPUlPRl9PHp3Ciov33TzHMn2pwy9lY1Z0fZySw?=
 =?us-ascii?Q?mO+hwjnPqPZ50j/8cBfDvXQSEqi0CFgI9kpiOT1EZ9B/z3luh2Bg/krFIu4K?=
 =?us-ascii?Q?PcMTwiEP+NTl5mUuT6iGZSjq/ffqlm7t0pXpPoeZYWYCv3I6Zh/vJNHiZn91?=
 =?us-ascii?Q?KNthZvO3l79RIcQo6+hPq/2+awBYrUAt+qVdPVn6BLp5+DledqJWRS/qObr+?=
 =?us-ascii?Q?FRPGXlv12hacgrQIO+HBMA/WV6ck8fr4nfYgOonIVKHMXNCldgun+cPRUw1r?=
 =?us-ascii?Q?DmgimV9opgREzW4RXUHNE8r2qvyrkgEsVfc5m7EGi15zYh8s9xDeOmWUZG+W?=
 =?us-ascii?Q?ONUUScisWmVorSml70PaQcOqu7WsRfAdcovzWD4s+wmWl7ciA1WaWgIm1/W4?=
 =?us-ascii?Q?AOUkBwZ9PXhKzL1lhC5tqPwg3KP5FtqjTisfP7Lj51Oswt+0fnVtwRR3c0CG?=
 =?us-ascii?Q?s+vrdKk5hp0Eg97fz74vYvJRWUMc/2GZ1VwrgC9Kb63mhbrBiEU14xWsDdWq?=
 =?us-ascii?Q?iH8y8rN7R1KH4JYPciBKzM3VbalUm7A+FXPOweCxCElWhKhEbB5PCNZCZkcY?=
 =?us-ascii?Q?nvvi9ZQaNAwB8QHpEKs9/fmn/jR7TP7ugHIXc0k96IYaG+xDdZo8xB/dfDHh?=
 =?us-ascii?Q?T0w07n/OR0NVIOA0DqgRAPd1F3mgtCOOG1o0Yfh4jPfEYy7Phasx0WIw0iiE?=
 =?us-ascii?Q?yyRDfrTVtWWoql6+VzrPzdiuIFGHQXAhbQB0bA2pVmhUW9agOElFhI/jfBWm?=
 =?us-ascii?Q?3DNP7hOoPfwY9X3g5pSylIpvb7nw7FFO7RGcsdjGESC+rxyehCEdq5E35NXK?=
 =?us-ascii?Q?2joKBq3OENMFigvsDVsG7x17iTA+CWl8QCpslNusFTpsM7Hj7K06xMcn0eq2?=
 =?us-ascii?Q?hq7io2/G17A3bmYsqbuLiJAKn+3BJF5Jkx5VkmtHVp21U5iDsnp9piuXWva2?=
 =?us-ascii?Q?Og=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1482F93DE0DD924998543B56762120EE@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: LOFdtKRZ5LN4En4V5IdKsYePZJpZbfE/23eFAHKsbx3taQ02quqWBh2WoE2Y07i+HmKbjo9cgHlwDKDIxVOlrLYzd7c2jlCEP2cwNsMYzXRO35PK7NTjASHTGycjbCh5MdFf35P9bY5AFz6nwT3PmbYBAW5egWU03iWPzik8ttH59WVOhkV0ryy5s7Hbki3FFUJ0DGpuijSu6PTYE2Jpsa9bSzK4YzzHK+CYdorrzLnVoYoKG/oVnqZrnOzEh3qmpn5p6hd0HNhl30iR2S6WCoq8MV9EFyuk+ncx3VxzULOzsJmk2vrs3W0ugNdXrDC+3f94L+83X6IvF7blqi6fBw18vYqx4e1CUZGdz3xTHeKPNC2Wy8F9q/3azghybIBqGjWe1E/WWAeSpcSwtp9rmvlHHyVrOezKCnVdTc7ra2Mu2ihxFZmgR9UvH/KVPBfWqe9d3wgJPshIE5PDMlbuY4ssCelQbUxVC0LuhfMumAXUiEYJeSK2pQ3cRA9oM3WYRS0xMsTIJdNUft4Py6dmgmnV9gbPXXY/GSHqcINuMv7E5CZS9GaPcm+6oIC9wwQxgp44H1OdwTqdhHFWjTM2JvTx0nwlX9EvKCyKsDDFOrHrqy/cFTXkCg28szew5wXHdkbLFmgQBtWHbYaW0r96nFusM4FaxsvOe6DVJZD32QFZ2mJBJhvTJ+yLL/6fk/+rjAyFDN0Bo90llhkaqfCdqFXVRdWbVJKGTTw/ItqTDYbdImvlf6iaAbR2L+51r8BdPsHhnSoMl5JsUEk44fLxvgozTS9tpY/PIXqL/NWk2wV2nYDAcZUlirB2EdfKrrx0bDzd7YxtggdClqkk/tIKV1EPINTXsAiJyKmcPjdZ1YU3vAzZERtndbC3onXFTmlgAWRIqAVmkiH0cVcBU1n7Gw==
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR04MB6272.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f31e9a21-0a34-4234-b7c7-08dbcbeca7ff
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2023 13:02:29.3835
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vZUdYhfJhpJMh/pKzCX5hUGfAQbjIbh6yD1ZrbMnmqjfQgQmDsL9L6ARtOybCX/jl7q3jMHRWkcohhMrM1p13w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR04MB8654
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 13 Oct 2023 06:02:47 -0700 (PDT)

On Fri, Oct 13, 2023 at 08:26:23AM +0200, Daniel Wagner wrote:
> The firmware version sysfs entry needs to be updated after a successfully
> firmware activation.
>=20
> nvme-cli stopped issuing an Identify Controller command to list the
> current firmware information and relies on sysfs showing the current
> firmware version.
>=20
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
>  drivers/nvme/host/core.c | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>=20
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 62612f87aafa..bb15d878e8a2 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -4079,6 +4079,20 @@ static void nvme_get_fw_slot_info(struct nvme_ctrl=
 *ctrl)
>  	kfree(log);
>  }
> =20
> +static void nvme_update_firmware_rev(struct nvme_ctrl *ctrl)
> +{
> +	struct nvme_id_ctrl *id;
> +	int ret;
> +
> +	ret =3D nvme_identify_ctrl(ctrl, &id);

Hello Daniel,

I understand that nvme_fw_act_work() is called when
receiving a NVME_AER_NOTICE_FW_ACT_STARTING AEN.

This AEN is received when a Firmware Activate command was
issued with value 0x3 "The image specified by the Firmware Slot
field is requested to be activated immediately without reset."

However, when upgrading firmware (even without a reset),
can't more things other than FW version change?

Sure, I understand that there is no need to do a reset
(as in the cases there the firmware deems that a reset is
needed to do the FW activation without reset, the Firmware Activate
command with value 0x3 returns a failure), but it just seems like
more fields than FW version needs to be re-read.

Theoretically, can't a FW upgrade go from NVMe 1.4 to NVMe 2.0,
and that firmware can return success for the Firmware Activate
command with value 0x3?


Kind regards,
Niklas=