Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
MIME-Version: 1.0
References: <20231012192149.1546368-1-robh@kernel.org> <ZSkPjRp/xPfVQ/NB@yilunxu-OptiPlex-7050>
In-Reply-To: <ZSkPjRp/xPfVQ/NB@yilunxu-OptiPlex-7050>
From:   Rob Herring <robh@kernel.org>
Date:   Fri, 13 Oct 2023 08:15:51 -0500
Message-ID: <CAL_JsqLHKTQi0i-V4C5UA6WJjnMeen0WR4jjcA4YSRXOYZOrZA@mail.gmail.com>
Subject: Re: [PATCH] fpga: xilinx-pr-decoupler: Fix unused xlnx_pr_decoupler_of_match
 warning for !CONFIG_OF
To:     Xu Yilun <yilun.xu@linux.intel.com>
Cc:     Moritz Fischer <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
        Xu Yilun <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>,
        Michal Simek <michal.simek@amd.com>,
        kernel test robot <lkp@intel.com>,
        linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Oct 13, 2023 at 4:37=E2=80=AFAM Xu Yilun <yilun.xu@linux.intel.com>=
 wrote:
>
> On Thu, Oct 12, 2023 at 02:21:48PM -0500, Rob Herring wrote:
> > Commit 8c966aadcc02 ("fpga: Use device_get_match_data()") dropped the
>
> Hi rob:
>
> Unfortunately I re-applied Commit 8c966aadcc02 and the previous commit
> id is lost.
>
> Since the 2 patches are not upstreamed yet, could I just merge them into
> one?

Yes, that's fine.

Rob

>
> Thanks,
> Yilun
>
> > unconditional use of xlnx_pr_decoupler_of_match resulting in this
> > warning:
> >
> > drivers/fpga/xilinx-pr-decoupler.c:94:34: warning: unused variable 'xln=
x_pr_decoupler_of_match' [-Wunused-const-variable]
> >
> > The fix is to drop of_match_ptr() which is not necessary because DT is
> > always used for this driver.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202310100247.Y7BFcalX-lkp=
@intel.com/
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> >  drivers/fpga/xilinx-pr-decoupler.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-p=
r-decoupler.c
> > index 0c012d0f616d..68835896f180 100644
> > --- a/drivers/fpga/xilinx-pr-decoupler.c
> > +++ b/drivers/fpga/xilinx-pr-decoupler.c
> > @@ -167,7 +167,7 @@ static struct platform_driver xlnx_pr_decoupler_dri=
ver =3D {
> >       .remove =3D xlnx_pr_decoupler_remove,
> >       .driver =3D {
> >               .name =3D "xlnx_pr_decoupler",
> > -             .of_match_table =3D of_match_ptr(xlnx_pr_decoupler_of_mat=
ch),
> > +             .of_match_table =3D xlnx_pr_decoupler_of_match,
> >       },
> >  };
> >
> > --
> > 2.42.0
> >