Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Message-ID: <05a668db-118c-4568-b2cf-49febb04a6d2@gmail.com>
Date:   Fri, 13 Oct 2023 20:28:30 +0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v6] staging: wlan-ng: replace strncpy() with strscpy()
To:     Dan Carpenter <dan.carpenter@linaro.org>,
        Calvince Otieno <calvncce@gmail.com>
Cc:     outreachy@lists.linux.dev, linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Luke Koch <lu.ale.koch@gmail.com>,
        Simon Horman <horms@kernel.org>, linux-staging@lists.linux.dev
References: <ZSkm34Sy/n2yxBqi@lab-ubuntu>
 <ce6c3d81-d75d-40e7-a6df-7abd4e8250a5@kadam.mountain>
Content-Language: en-US
From:   Bagas Sanjaya <bagasdotme@gmail.com>
In-Reply-To: <ce6c3d81-d75d-40e7-a6df-7abd4e8250a5@kadam.mountain>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 13/10/2023 18:19, Dan Carpenter wrote:
> On Fri, Oct 13, 2023 at 02:15:43PM +0300, Calvince Otieno wrote:
>> Checkpatch suggests the use of strscpy() instead of strncpy().
>> The advantages are that it always adds a NUL terminator and it prevents
>> a read overflow if the src string is not properly terminated. One
>> potential disadvantage is that it doesn't zero pad the string like
>> strncpy() does.
>> In this code, strscpy() and strncpy() are equivalent and it does not
>> affect runtime behavior. The string is zeroed on the line before
>> using memset(). The resulting string was always NUL terminated and
>> PRISM2_USB_FWFILE is string literal "prism2_ru.fw" so it's NUL
>> terminated.
>> However, even though using strscpy() does not fix any bugs, it's
>> still nicer and makes checkpatch happy.
>>
>> Signed-off-by: Calvince Otieno <calvncce@gmail.com>
>> ---
> 
> It's still white space damaged and can't apply.  :/  Try save the email
> and do `cat raw_email.txt | patch -p1`.
> 

And better yet, use git-send-email(1) to send patches. But don't rush,
as you have sent five versions of this patch today. Please wait for a day
to a week and then reroll.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara