Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Date:   Fri, 13 Oct 2023 11:04:56 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Yi Liu <yi.l.liu@intel.com>
Cc:     joro@8bytes.org, alex.williamson@redhat.com, kevin.tian@intel.com,
        robin.murphy@arm.com, baolu.lu@linux.intel.com, cohuck@redhat.com,
        eric.auger@redhat.com, nicolinc@nvidia.com, kvm@vger.kernel.org,
        mjrosato@linux.ibm.com, chao.p.peng@linux.intel.com,
        yi.y.sun@linux.intel.com, peterx@redhat.com, jasowang@redhat.com,
        shameerali.kolothum.thodi@huawei.com, lulu@redhat.com,
        suravee.suthikulpanit@amd.com, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        zhenzhong.duan@intel.com, joao.m.martins@oracle.com
Subject: Re: [PATCH v4 01/17] iommu: Add hwpt_type with user_data for
 domain_alloc_user op
Message-ID: <20231013140456.GR3952@nvidia.com>
References: <20230921075138.124099-1-yi.l.liu@intel.com>
 <20230921075138.124099-2-yi.l.liu@intel.com>
 <20231010165844.GQ3952@nvidia.com>
 <03ba68e9-33ef-35c1-5720-8f559f94f8a1@intel.com>
 <20231012133917.GL3952@nvidia.com>
 <3659d9a7-d9e9-bb73-daf5-41c765e99c8c@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3659d9a7-d9e9-bb73-daf5-41c765e99c8c@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3LMJjyplS90qCfS9AOSd/RXHZUKRJfOG9ST0P4ZogozCBKFJq2p9UvE5UMqI?=
 =?us-ascii?Q?aSbuWK0t5eDYKw2Cvz5qHCF7fdBuaMfZ5nk8jp16ii+X0seU8Cqs8V1GOgmG?=
 =?us-ascii?Q?zNxI/Mrtl0BjkFR/JhEwidbNnnGfvfIRUXh6YKfY/NyLWapRVCMis7w5RCBi?=
 =?us-ascii?Q?D2SAyHM+pE5PT5/VwFzNJ656FqPz03XzQqKSFJ+sO6NYUsCti1hixKuCSRT3?=
 =?us-ascii?Q?WicpksfNna36get0xcS0ulYwGIbYD5b1eB5zTB5BoFqOGklMZi0Vl1G1xZR+?=
 =?us-ascii?Q?ZTwytPwXZVckEig1uJaLMUIsyP8907X3pX0YZilxcMsxrIqKoPw8EHqRQUt+?=
 =?us-ascii?Q?qusygaDp3lqy02CIdfpF0oV/pUkk2v3zIpDxx4zm7GmWhEIPPonEwROUu5N4?=
 =?us-ascii?Q?thVzqoBJwZz/xUGLyXwJ9nKh5XhZuSHtSSBXbu/NZlw2Lt+cy6r+m+FXbvlX?=
 =?us-ascii?Q?GNTqz3eJNB/TIaELDgWKJFq1FIljJc7H9NmNlw8/8kJyL8g9IEkFMz7LQ5Yx?=
 =?us-ascii?Q?X5Qzsy5cZ9mg8x83FCsIFtFLFrkt9c0OEG+tpcTD++isWegXZmk0aRI5WzQt?=
 =?us-ascii?Q?bwwGPLpRQ+ccBUvl9Z0zm701CZ9SJzmnUZZNcqM/iF8s/3hZ05WfFvH2joAd?=
 =?us-ascii?Q?5/U0vyH2jF5q9woKGY97NUsmz17vC2XFlbmv28Lcr9/AdIh5jwwILGrWAKKA?=
 =?us-ascii?Q?Ltrf/I8u9jtQlhKLckA3kqY8/gdAvC9eEP7gggZWq7T5NKe/oQ8FJUByqEO0?=
 =?us-ascii?Q?PJBFIKdqKtB8tskFVA2YTVEgYVKkEM2EnFg8Qz+nGDihMBBHHX5Fi1OaFgEX?=
 =?us-ascii?Q?4e1jKR4q2w7st9qN6OGqY8q9BO36+Awv6lZZEXl3Hqo4use2eFsyN5BhGMkD?=
 =?us-ascii?Q?gTem/cHflZEh0a3qIjh8RY9AQDLeNVbAyAFpfJk3hYPNfuovsbJko4Gkqlya?=
 =?us-ascii?Q?GqQ+tSiY/aGX3+tO4Tw/6PdHL4OPF7qY3RiZILsI21nB5PqHjOWaV5WWfTUc?=
 =?us-ascii?Q?3dVfLEO+7/F9v7Jnr9MKGmPGAAwF3/XdJyGRgsCe5dhb5loDtdEu6zLWP6O0?=
 =?us-ascii?Q?bcDROSFz2dW4K68V/cxqk0QXpWftsewm0nVdY26reOv5Am7o2msaL70rQwQl?=
 =?us-ascii?Q?CLG3P53TBM+fV9jki+b5T091ZqwobqwAL7WCFaV3VfZ9Swn0h6Z3nyivy0SM?=
 =?us-ascii?Q?zla+9e+pUr/VaUyBUUSO7lYRlFfCeENKTNteTTiRMndh4PuVFxP4CVEl4u7D?=
 =?us-ascii?Q?h4O7eTMxQfDzM0hxYDOeQow6zwvS5BaHEifv+10xqE9k4p+dnMFniIbNQDpE?=
 =?us-ascii?Q?Gd5A+eiccQqWi21ypQiPWk8ST8RJOKMoNbw9S8EGiCGxTBiCwqG54g5WBs1u?=
 =?us-ascii?Q?Zzp+m9jmcgnq/cNqEdpLja/43kAUaThLVeij2xziC0Umym2k6z5WAJNj/WBk?=
 =?us-ascii?Q?gOD9M7AVMAlm/24R3AwFIJiETw9PbObEczpud1pMQhpcvnFt3ED62NWlmAG0?=
 =?us-ascii?Q?xX8p4FwwX2NRfxm403KHvfGoKW3EZ5Nvl6KzsbLbXv/6IRhra9D5Ll4RGtA5?=
 =?us-ascii?Q?63JNKAhneI2ItQwQ/yg=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 13bdd1cb-f6aa-4121-f1d1-08dbcbf561e0
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2023 14:04:57.3738
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ex9R1VbdO/S2o5H15OcXa7ClM2pnR5Hc7bV7ACFAo2KuUFjNExhQbIDBW5BhPVma
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4538
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 13 Oct 2023 07:05:26 -0700 (PDT)

On Fri, Oct 13, 2023 at 12:33:13PM +0800, Yi Liu wrote:

> not really. Below the users of the struct iommu_user_data in my current
> iommufd_nesting branch. Only the domain_alloc_user op has type as there
> can be multiple vendor specific alloc data types. Basically, I'm ok to
> make the change you suggested, just not sure if it is good to add type
> as it is only needed by one path.

I don't think we should ever have an opaque data blob without a type
tag..

Jason