Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp990024rdg; Fri, 13 Oct 2023 07:14:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEQz6gUnIybGwrtxWbEMQLCIr4hb4Nv9aKjtsKg5OXPzYA5jQbaG/Qy5X+54DmBGnrEpW0b X-Received: by 2002:a05:6a00:c85:b0:6b6:e147:717 with SMTP id a5-20020a056a000c8500b006b6e1470717mr659311pfv.23.1697206464023; Fri, 13 Oct 2023 07:14:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697206464; cv=none; d=google.com; s=arc-20160816; b=cr0YscuShcn3pfUdxv/X8zYeRFod1Yat8tB4QQ2wLLEmfDB9NhOeBQCiodWKjj9vKR nUyD/Rlx6L9O90U6WHb96+iVZgl/mdOqAyetAgIY1rUEexeMVqPIs3bz8hXV1L7QJsIK +U5c3/Jjq3eTBBGFWYyzklqZeClkrRZZpukC5hskVGV6TU5gfqZ0VphMDP+AEpV2b5Uv lmZ7OZFdLDF89r5lXBLeSMuOHXOxuc5rxR6o1+0Bf+FjsC2UdCPuk2kriLUV11LmWVqm kM/1RCtbK/nuJScb13jAqSArkLCmkd9QcZ1nv6A9WH81Bv3fhQEmp7L3y+cV1IOXW8jp YHZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ieTrE5jw4pRFikuUAaWYRNQij/LpYF8Nnz7aawYTeSM=; fh=vvRIDYsN0eFnvPagY5OIuxpl7WiguoFFIevVqmQXWLk=; b=tVflB1eYS3zZwqTlbQCKMuQBJmJVHS0QO/XoM9CZwki00IGsHTItcnYziaSGOSuczC aKIZBBKMBPXueAG8yU2ls+hFhm9IVDbWhTEFAhpG4NznXVmWZYu2oYdP4DB+MrMlRfeM q9Ouv0qPU18Dlhfa6gOot5Nug4Wy0TDnUIuhExOmWHDpsFv09hcSv9y6GDrW1gOEw6PK C3RegiPF19Kxz7m+kcKQZr+iOOhdLcCYDVa6RwvhvvTiemdH+sulXgrAGa1JVYWgEBdy pRL8DH0XIlKZ3QrRmKiE7kyXnjj9ysVKCAjoYGcUI7hPO0szhr9hyObpBbKqjFGxiqHq 7xvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="eie1oeb/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id cr7-20020a056a000f0700b0068fc2f7cef3si15866097pfb.358.2023.10.13.07.14.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 07:14:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="eie1oeb/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id D6FE081C36EA; Fri, 13 Oct 2023 07:14:21 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232054AbjJMOOP (ORCPT + 99 others); Fri, 13 Oct 2023 10:14:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232107AbjJMOON (ORCPT ); Fri, 13 Oct 2023 10:14:13 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 846A3BD for ; Fri, 13 Oct 2023 07:14:12 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97711C433C7; Fri, 13 Oct 2023 14:14:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697206452; bh=xiakfY2yzTf4fr07QKBhbaZia1Xj2Zm55HyF6h2uAk8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eie1oeb/SCDdqnrwYuRPCFdXKakAcbC4fy0M9ybafZEXiNV3IeqYb1gvNpDVkEE3j Www067T/upZIUOG9A+eM9To7syVYOSs6IcdGRvfc3pKtEc+j59snOOmCI0aXOfNwKw ZyRFGRH2Z8mb5jpMOW6oJzHZleZmD+fm4o+YkilcRholE/pm/IaGdRlhdQHoR/QSGh 4myH/6Swbjp/PL20e8IlsuI7TyX+d5aF2KwlopT/Ue3kCUFTPznyoj544KT6s34ZM3 2ekxKjK+RXQ+xVdq5kSQPHxNAe7g+iiZT13j0YJ3iFWj2WkcArLg8Jlx4Xgw2TGh+X lrjqV830Nn2IA== Date: Fri, 13 Oct 2023 15:14:08 +0100 From: Mark Brown To: Krzysztof Kozlowski Cc: wangweidong.a@awinic.com, lgirdwood@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, perex@perex.cz, tiwai@suse.com, herve.codina@bootlin.com, shumingf@realtek.com, rf@opensource.cirrus.com, arnd@arndb.de, 13916275206@139.com, ryans.lee@analog.com, linus.walleij@linaro.org, ckeepax@opensource.cirrus.com, fido_max@inbox.ru, sebastian.reichel@collabora.com, colin.i.king@gmail.com, liweilei@awinic.com, trix@redhat.com, dan.carpenter@linaro.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V1 3/3] ASoC: codecs: Add aw88399 amplifier driver Message-ID: References: <20231013104220.279953-1-wangweidong.a@awinic.com> <20231013104220.279953-4-wangweidong.a@awinic.com> <37a2d2d1-5ede-4f88-b4e7-d9750336465d@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/Bt6tNOD8qhkOtxB" Content-Disposition: inline In-Reply-To: <37a2d2d1-5ede-4f88-b4e7-d9750336465d@linaro.org> X-Cookie: Save energy: Drive a smaller shell. X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 13 Oct 2023 07:14:22 -0700 (PDT) --/Bt6tNOD8qhkOtxB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Oct 13, 2023 at 01:50:41PM +0200, Krzysztof Kozlowski wrote: > On 13/10/2023 12:42, wangweidong.a@awinic.com wrote: > > +static void aw88399_hw_reset(struct aw88399 *aw88399) > > +{ > > + if (aw88399->reset_gpio) { > > + gpiod_set_value_cansleep(aw88399->reset_gpio, 0); > > + usleep_range(AW88399_1000_US, AW88399_1000_US + 10); > > + gpiod_set_value_cansleep(aw88399->reset_gpio, 1); > Why do you leave the device in reset state? I think you wanted these > reverted. I imagine practical systems aren't using the inversion that gpiolib can do via the bindings, this is already the case for the other drivers sharing the binding. TBH the use for things like reset lines has always seemed like it causes more confusion and error than it solves. --/Bt6tNOD8qhkOtxB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmUpULAACgkQJNaLcl1U h9D31wf+LSw0mI4Eah0LGJWQfl5PpXcpkbD6bVg/ql2yS7Exi2pm5cMxMf5Thmhw 7Js/Io7XmJ+vFRJsDXRuEWdoLwvhpR/Tnaokvf6XEyEh5FA/vbvkMQae1aA0s9xy 1muspCbfG18y4N+lkzSzBL34kfuMZvUimK8e8VxCQqUdQK9hwvPeEkcA+Ujij+Mn yhjBAuyHcR7/Mz8SM9Y+CU0rmca4QEtZQfHZvU9jKoRnEYJvX9c1LVdGjXrABPIi cTY7xj33xVXMn496S2fG1eBwZUm38r1FWKzLW4dT8Yv1ncwETMkTJPPgEATFqvEh 5kWjYdboiDHre3ELXVH43f/6tiRpfQ== =POXu -----END PGP SIGNATURE----- --/Bt6tNOD8qhkOtxB--