Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp991648rdg; Fri, 13 Oct 2023 07:16:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEraR9CVM44hQflta/hpnpziHO7KamIGrjTwj1AV9djqwGloNqaw+nU2ILEO+7tgtQTJLfU X-Received: by 2002:aa7:8889:0:b0:691:1eb:7dda with SMTP id z9-20020aa78889000000b0069101eb7ddamr28193362pfe.7.1697206588717; Fri, 13 Oct 2023 07:16:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697206588; cv=none; d=google.com; s=arc-20160816; b=lspEFRYlWXPZvg8t/dXCwhoydw71CsXMRhzod/1rUEsMlCkft9w6dny2mxqmg6uai1 LtE6MYyfVmtXjkoZmxmRZt5k6+XVGPnC/3ICp7X+liTCu68zkVQFCpfPNVZRzTIwXYPy eCq0DJNOZCXpbVbFBa3/KNeqrEXN/t1plxPldDo6N6/npdP2VbRRMT1+mEbGsyGsdxkE UPrrg+N1fU25uZ9WO4p5MXDLPIDdRar0hzWLitpBZXkOaw4ByD5qnoTNUK/H4OgWYPaq X7CeowZkUstDMgLi0P1bbuWlehUV5EJqqhhqhpsZqtIkxBISw23rKYdtVpfUQPje4SIU q3Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=JWktuGQwxmwZJubko50gUdVMFbWvuig15BInW1UTJYk=; fh=2buEcg5c3S58BvcJ6+rCIwnSBwfHiiV4u0IlZjL8eMU=; b=XZUnsaMGYyt2xelJInrVN3NfLxwFPwBbhkhGqg9isnKoa/JbxfLOJTqIZiONjPrjGL Z8y3yHEUmUz1fhMdUHxhn7ORwgizxgRVjcnxJIRUAGnRlh4HWWOGzAqwKxG8uVms8YJL 65oqqh/A14f6qJcUpD9qDuxg5QO/yQaWAfyfIFM9bK3tuE9gjR2s56Tv2NmAaqrcf0SF jAjD5QdFDrxkt+zXJj0nak7sdF84cyV1KRFoGTxJZVL03/7X8JijBp5H86SjrYwHoi2E LGpocBSWe1GXYRTGubz9JSjOzskuEUuk5z3piFnP3MR9cVrPK0m26ciJTLgp+r14I3pF aJQw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id bw12-20020a056a02048c00b00578e6358053si90455pgb.269.2023.10.13.07.16.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 07:16:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 0892E8029231; Fri, 13 Oct 2023 07:16:07 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232037AbjJMOP5 (ORCPT + 99 others); Fri, 13 Oct 2023 10:15:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232047AbjJMOPz (ORCPT ); Fri, 13 Oct 2023 10:15:55 -0400 Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33460BE; Fri, 13 Oct 2023 07:15:54 -0700 (PDT) Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-1e9b6f39f9eso1197150fac.2; Fri, 13 Oct 2023 07:15:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697206553; x=1697811353; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JWktuGQwxmwZJubko50gUdVMFbWvuig15BInW1UTJYk=; b=Bfh83ISr0+vdfdUm1gysBcNS6BUYsq20//N/glC+KXUDpJPt4B9ifUjcX/tPsJMacp LCo3fZTiQOW8MFMHU/C3C8Ac7I6lNYU82LCjHMc0+82R8oipTUj4cUkxa33sWJnz+1JR Vhw1DBZXS9f6gP9H0mcOnWKZFezT0xzGJHXNj9KIM7qxB+JqvA1naQY4eFzGVklXwZ5V lV/RDhkxIDWUGuSJB6fCufFAAMWI4pRCN/qW8XlinH9PuITwlNF+Yl6AmIVT9x73lB9/ 3Y5bghFScxVwG0jaUThx9Sqe5rqoUDprKdoSZw1kg3APSaiE/7oLzxQ/MXrwd0mX1yVq HnLA== X-Gm-Message-State: AOJu0Yzl28DAVTxKE1EXTEFwaskdb8fP4RPuPmObzguh5ZfVhDyslKlI 8gOV0WdDcLPjChOK2Zhqsw== X-Received: by 2002:a05:6870:898c:b0:1d7:1533:6869 with SMTP id f12-20020a056870898c00b001d715336869mr31544207oaq.31.1697206553415; Fri, 13 Oct 2023 07:15:53 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id dt1-20020a0568705a8100b001e12bb81363sm785920oab.35.2023.10.13.07.15.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 07:15:52 -0700 (PDT) Received: (nullmailer pid 3800246 invoked by uid 1000); Fri, 13 Oct 2023 14:15:50 -0000 Date: Fri, 13 Oct 2023 09:15:50 -0500 From: Rob Herring To: Linus Walleij Cc: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Krzysztof Kozlowski , Conor Dooley , Russell King , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Christian Marangi , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 3/3] RFC: net: dsa: mv88e6xxx: Register mdio-external Message-ID: <20231013141550.GA3793553-robh@kernel.org> References: <20231013-marvell-88e6152-wan-led-v1-0-0712ba99857c@linaro.org> <20231013-marvell-88e6152-wan-led-v1-3-0712ba99857c@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231013-marvell-88e6152-wan-led-v1-3-0712ba99857c@linaro.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 13 Oct 2023 07:16:08 -0700 (PDT) On Fri, Oct 13, 2023 at 12:35:16AM +0200, Linus Walleij wrote: > Make it legal to have a subnode just named "mdio-external" > and have that be recognized immediately as the external > MDIO bus, register it and return. Only fallback to the > old method with a compatible in the external bus node > if this doesn't work. > > This is the result of deprecating the old DT method > of providing a node "mdio1" with a compatible string. I think this is the wrong direction. Using compatible is much better than relying on node names. We've been "fixing" node names precisely because they are usually not ABI. Rob