Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Content-Type: multipart/signed;
 boundary=0377e7501be3d79d6faabf808a2de3b62744369f17e3be7eb4f7324fb286;
 micalg=pgp-sha256; protocol="application/pgp-signature"
Date:   Fri, 13 Oct 2023 14:11:13 +0000
Message-Id: <CW7DEUEAKEXO.KE3YKH135Y3C@folker-schwesinger.de>
Subject: Re: [PATCH v1 0/2] Fix i2s0 pin conflict on ROCK Pi 4 RK3399 boards
Cc:     <kernel@collabora.com>,
        "Arnaud Ferraris" <arnaud.ferraris@collabora.com>,
        "Brian Norris" <briannorris@chromium.org>,
        "Caleb Connolly" <kc@postmarketos.org>,
        "Conor Dooley" <conor+dt@kernel.org>,
        "Corentin Labbe" <clabbe@baylibre.com>,
        "FUKAUMI Naoki" <naoki@radxa.com>,
        "Heiko Stuebner" <heiko@sntech.de>,
        "Jagan Teki" <jagan@amarulasolutions.com>,
        "Johan Jonker" <jbx6244@gmail.com>,
        "Judy Hsiao" <judyhsiao@chromium.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
        "Rick Wertenbroek" <rick.wertenbroek@gmail.com>,
        "Rob Herring" <robh+dt@kernel.org>,
        "Yogesh Hegde" <yogi.kernel@gmail.com>,
        <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
From:   "Folker Schwesinger" <dev@folker-schwesinger.de>
To:     "Christopher Obbard" <chris.obbard@collabora.com>,
        <linux-rockchip@lists.infradead.org>
Content-Transfer-Encoding: quoted-printable
References: <20231013114737.494410-1-chris.obbard@collabora.com>
In-Reply-To: <20231013114737.494410-1-chris.obbard@collabora.com>
Precedence: bulk

--0377e7501be3d79d6faabf808a2de3b62744369f17e3be7eb4f7324fb286
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8


On Fri Oct 13, 2023 at 1:47 PM CEST, Christopher Obbard wrote:
> i2s0 fails to probe on my Radxa ROCK 4SE and ROCK Pi 4B boards with:
>
>     rockchip-pinctrl pinctrl: pin gpio3-29 already requested by leds; can=
not claim for ff880000.i2s
>     rockchip-pinctrl pinctrl: pin-125 (ff880000.i2s) status -22
>     rockchip-pinctrl pinctrl: could not request pin 125 (gpio3-29) from g=
roup i2s0-8ch-bus-bclk-off  on device rockchip-pinctrl
>     rockchip-i2s ff880000.i2s: Error applying setting, reverse things bac=
k
>     rockchip-i2s ff880000.i2s: bclk disable failed -22
>
> This is due to the pinctl attempting to request a GPIO which the boards
> use for a different function.
>
> The first patch adds a missing pinctl node i2s0_2ch_bus_bclk_off to the
> RK3399 devicetree.
>
> The second patch sets the i2s0 pinctrl to use the new node when idle and
> fixes the issue.
>
>
> Christopher Obbard (2):
>   arm64: dts: rockchip: Add i2s0-2ch-bus-bclk-off pins to RK3399
>   arm64: dts: rockchip: Fix i2s0 pin conflict on ROCK Pi 4 boards
>
>  arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi |  1 +
>  arch/arm64/boot/dts/rockchip/rk3399.dtsi           | 10 ++++++++++
>  2 files changed, 11 insertions(+)

Thanks, works as advertised on my Rock 4SE!

So for the entire series:

Tested-By: Folker Schwesinger <dev@folker-schwesinger.de>

Kind regards,
Folker

--0377e7501be3d79d6faabf808a2de3b62744369f17e3be7eb4f7324fb286
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iJAEABYIADgWIQQFbmi0A2l3pTuK+esCQHEyPYq7fQUCZSlQAhocZGV2QGZvbGtl
ci1zY2h3ZXNpbmdlci5kZQAKCRACQHEyPYq7fcaaAPsFBvjaD6faGXW/mZLedAE8
Oio8383iwlnrrWOmoshgcAEAxShIZ4xIjPkCTtOnd8Z/OI4flfytkRBns2asy9ei
9AE=
=n0fE
-----END PGP SIGNATURE-----

--0377e7501be3d79d6faabf808a2de3b62744369f17e3be7eb4f7324fb286--