Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Fri, 13 Oct 2023 16:12:17 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Chen-Yu Tsai <wenst@chromium.org>
Cc:     Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/9] dt-bindings: arm: mediatek: Add MT8186 Steelix
 Chromebook
Message-ID: <20231013-playoff-unsmooth-2d3c8b30790e@spud>
References: <20231012230237.2676469-1-wenst@chromium.org>
 <20231012230237.2676469-4-wenst@chromium.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="HPmS7nFTK45JskTw"
Content-Disposition: inline
In-Reply-To: <20231012230237.2676469-4-wenst@chromium.org>
Precedence: bulk


--HPmS7nFTK45JskTw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Oct 13, 2023 at 07:02:29AM +0800, Chen-Yu Tsai wrote:
> Add an entry for the MT8186 based Steelix Chromebook, also known as the
> Lenovo 300e Yoga Chromebook Gen 4.
>=20
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> ---
>  Documentation/devicetree/bindings/arm/mediatek.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
>=20
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Docume=
ntation/devicetree/bindings/arm/mediatek.yaml
> index aa7e6734b336..fafd5e18f640 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -206,6 +206,13 @@ properties:
>            - enum:
>                - mediatek,mt8183-pumpkin
>            - const: mediatek,mt8183
> +      - description: Google Steelix (Lenovo 300e Yoga Chromebook Gen 4)
> +        items:
> +          - enum:
> +              - google,steelix-sku131072
> +              - google,steelix-sku131073

This one makes sense though, because both of the SKUs are in an enum.

> +          - const: google,steelix
> +          - const: mediatek,mt8186
>        - description: Google Tentacruel (ASUS Chromebook CM14 Flip CM1402=
F)
>          items:
>            - const: google,tentacruel-sku262144
> --=20
> 2.42.0.655.g421f12c284-goog
>=20

--HPmS7nFTK45JskTw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZSleUQAKCRB4tDGHoIJi
0v6CAQCmJE4kCmgE2JDh5U5bt3i9neQPQ4ZHWoVy6VSjohWS5AD/QfDDtg1Oc4Ft
FZpadGnpde7ftxx7TPCKzl7RQjgdOQw=
=ZIPt
-----END PGP SIGNATURE-----

--HPmS7nFTK45JskTw--