Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Fri, 13 Oct 2023 16:19:05 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Kefeng Wang <wangkefeng.wang@huawei.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, ying.huang@intel.com,
        david@redhat.com, Zi Yan <ziy@nvidia.com>,
        Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH -next v2 18/19] mm: use folio_xchg_last_cpupid() in
 wp_page_reuse()
Message-ID: <ZSlf6fPfuOo4QmDt@casper.infradead.org>
References: <20231013085603.1227349-1-wangkefeng.wang@huawei.com>
 <20231013085603.1227349-19-wangkefeng.wang@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231013085603.1227349-19-wangkefeng.wang@huawei.com>
Precedence: bulk

On Fri, Oct 13, 2023 at 04:56:02PM +0800, Kefeng Wang wrote:
> Convert to use folio_xchg_last_cpupid() in wp_page_reuse(), and remove
> page variable.

... another case where we're changing behaviour and need to argue it's
desirable.

> -	/*
> -	 * Clear the pages cpupid information as the existing
> -	 * information potentially belongs to a now completely
> -	 * unrelated process.
> -	 */
> -	if (page)
> -		page_cpupid_xchg_last(page, (1 << LAST_CPUPID_SHIFT) - 1);
> +	if (folio) {
> +		VM_BUG_ON(folio_test_anon(folio) &&
> +			  !PageAnonExclusive(vmf->page));
> +		/*
> +		 * Clear the pages cpupid information as the existing

s/pages/folio's/

> +		 * information potentially belongs to a now completely
> +		 * unrelated process.
> +		 */
> +		folio_xchg_last_cpupid(folio, (1 << LAST_CPUPID_SHIFT) - 1);
> +	}