Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <eb626b3e-21f5-4548-8674-3bf049e6cf9a@intel.com>
Date:   Fri, 13 Oct 2023 17:27:12 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net] net: ethernet: ti: Fix mixed module-builtin object
To:     MD Danish Anwar <danishanwar@ti.com>, Andrew Lunn <andrew@lunn.ch>,
        "Arnd Bergmann" <arnd@arndb.de>,
        Wolfram Sang <wsa+renesas@sang-engineering.com>,
        Simon Horman <horms@kernel.org>, Roger Quadros <rogerq@ti.com>,
        "Vignesh Raghavendra" <vigneshr@ti.com>,
        Paolo Abeni <pabeni@redhat.com>,
        "Jakub Kicinski" <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>
CC:     <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
        <srk@ti.com>, <r-gunasekaran@ti.com>,
        Roger Quadros <rogerq@kernel.org>
References: <20231013100549.3198564-1-danishanwar@ti.com>
Content-Language: en-US
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20231013100549.3198564-1-danishanwar@ti.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SEFRYlYza2ticjZ4cXV1TE55N253bUJHQVR5ZFFpSDNUM25MZ2toYmJjek44?=
 =?utf-8?B?eTZ6RmdBRk9pQmgxNVlOZU9ET3R5cjJaWG9nMGliN2ZEZzhjMHh1cVRUd3ND?=
 =?utf-8?B?YjRuR1pWYXUvNHhQK1d4MVRJb3J6aW9xVXRNSXVSejJraHFTQjdyZTNRMDVP?=
 =?utf-8?B?UHBnMGVjek9MU0FiaXBYdVAvUFlQaEJMUHFOVmNCbFUxUzJiSGtsclVqeEFr?=
 =?utf-8?B?SWV0NnVLL0RxVHd6VnFYVktVY0VtOXBSU0crRDhOWjlScEtPamtrbk90ckpu?=
 =?utf-8?B?dWUzU2hWTGRLV0hhTkZSN0hzbzl5aDcweHVKdlFPdFR2eU11Z3pNWkdWc2Rm?=
 =?utf-8?B?Tm4rZDJkZGR5a1U4cEc1YVJJZ3VFa0dhVWdrZHl6QU1DZmt2VnRCV2JqSCtp?=
 =?utf-8?B?SmNUWU5tVjNIMEl0dk1YcW55REV2SVc2ZXdCd3JsUVhOeW9MeWo2aCtXMTM2?=
 =?utf-8?B?RVRxZm1DSzNjVVFZZWs0L1NmQmxiZnNXM3JXUEdTSzh0aFpWanV3WDhDWktG?=
 =?utf-8?B?aTAzWERqSmdSdlV6QXVqeU4xOHVXTHhEbnc2UDZRTGw0S21YWG1lQ2dySFVi?=
 =?utf-8?B?aWpJb1dPeStEZkxwLzFPQzcrT211UDBxNERkL3VNLzRpZXFHTEphaFRzYVdI?=
 =?utf-8?B?Q0t1SDlqb0xKYWgzbGh4ZXltTjlGbEtGN0p2T0FOU0o0M0ZsRTc1bVVvZ0xU?=
 =?utf-8?B?TGJTQUo1U0FXVERPOU9pYkVDOUxkRHBJOGdid2N5d00rUE9sRWpjRUhCbFAx?=
 =?utf-8?B?R01zUjhmVWFRazRpb1ZwWi9yYlh2MmNzSnNPM1JtS0hZakdTVFBDakN3Q0hU?=
 =?utf-8?B?eDVoZE50bXJ5TWFPK1dvTCtFME93eS96ZHhGb1l3bVFsMng1RjMwdHd1TFNw?=
 =?utf-8?B?Q2VjVEt5RFZYVVpIaWZLOGRhZnVtRUNrQm1BekZ5QzJCUlY4MEh0UkZ2NXFk?=
 =?utf-8?B?K0NWQkQ2bkxMTUZzTEc0VjZvRll0VE5CM3JucG4wRndkcW42K2I0cSt0R29r?=
 =?utf-8?B?aVFIdGpWWkpSdWgzdHZGQ0xLOE1rNWpTcVlCR3orSitwMW16TEE4Zkp5bFhY?=
 =?utf-8?B?YngwTERmd1IvbHRwa1N1YXpMcGJHU3RoT3ZxcU50dFBSci9KZzdPYndVWk1L?=
 =?utf-8?B?UFdzRit2cGhtK2d6NkJHV2FadnhyWVhiTkdvZjJyZXFGcis0WEkwdVIrai9o?=
 =?utf-8?B?V3VOajNoN1hoaVpBNmlpdnV1TWl1aC9ZbUI2eWJjTW5qcGdvaG12bVQ3YWxP?=
 =?utf-8?B?TVdtcjhIODJCSFdWRG9vNk4xNmpGWWxtYWU0UjExa3NZaW5UV0EwNWZZVFRW?=
 =?utf-8?B?YjliL2FUZklpNG1SY05ORTFtOVRxWXhsQjBJR04rYmE1RG9tRlJEZVA0ZFpZ?=
 =?utf-8?B?NlZiU0sxQ2RPc0lib0YvU1o4bjc5Y0VEdGVHazdjNHYzR0YrMFdWWGtPTTVP?=
 =?utf-8?B?Z09xaXF1SlBOK0tNdWowb1ppOHdyS2cvZkIxVUN0bTFLVTZSdlJYMHBIQVcr?=
 =?utf-8?B?MzhuQ01wSmZYc0VYYlpGdlQ1Nzh5bkJHOU1RSHpLeHA2NHc3MC85YzFoOUlR?=
 =?utf-8?B?QUNmaUY3T2JBcEpYQVBNM3hQLzdTUFJQQXpCRjk4VG5HcCtPRDdPNGMzdjNo?=
 =?utf-8?B?SDlqUnM4L2RXbTBXYUZnVWYzMEZISzh3eHMxRXVraXpTMHlUaW55bm9BQzRK?=
 =?utf-8?B?RCt0UFFidXM5UmcyeW1FSUhwVmNvNFQvMzZ6ODJ4R3kzcUw4bVJMRTJTNVV4?=
 =?utf-8?B?RXlleStyZ0tMU0huVXZSQlNTc1NDVFl0cU9UTEZuRjNydVV5UmNKS1Z6Q1Ns?=
 =?utf-8?B?S1BnQmFGbElrNUc3VXprbkNVcy9DSXNBSzRpSnhnbzVnRmZEbi9rL0g0SlVO?=
 =?utf-8?B?Zmpwc09IOE5OR0M1d04zRHNuTWlNRUpJS2lOZmcyUlE1UnNScTg3cWllTWcy?=
 =?utf-8?B?ZHg3SXdsMm1JV2pvZWJlemYxZTdSa1RzU0R0cWJxZmkrREtER044WjE3SGp6?=
 =?utf-8?B?NXNmak1Ed1VXa2NnOXRnd0JYZUdMOFBTNm15OFhoeW84bVZwWGdUakk1aXRI?=
 =?utf-8?B?anFBQ29SdjZaY2c3YWsrZ2psckRIUlYyOTlLQUhuWTNwQml6S016eEdnU2pP?=
 =?utf-8?B?Z01aNVZSaUd0RU5ISG1HRmdGQjMwL0ZLMHArb3BncTZBRzNNV052Z3dlSVBR?=
 =?utf-8?B?UlE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f9da27b6-4c1e-44e0-3312-08dbcc0117ed
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2023 15:28:47.3757
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /AYl6YjqsGbQK7uCjaYhcmQ1Pvg24SfI2c42jkwJTZeFM/Subv7gsRlEeiahLy9O7GDqsDyTEjZ9mqYjJGza2mflFfsWJ0gEyzh8pEyaPBE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6216
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 13 Oct 2023 08:28:58 -0700 (PDT)

From: Md Danish Anwar <danishanwar@ti.com>
Date: Fri, 13 Oct 2023 15:35:49 +0530

> With CONFIG_TI_K3_AM65_CPSW_NUSS=y and CONFIG_TI_ICSSG_PRUETH=m,
> k3-cppi-desc-pool.o is linked to a module and also to vmlinux even though
> the expected CFLAGS are different between builtins and modules.
> 
> The build system is complaining about the following:
> 
> k3-cppi-desc-pool.o is added to multiple modules: icssg-prueth
> ti-am65-cpsw-nuss

I also fixed a bunch of these in the ethernet/ti/ folder a year ago[0],
you can take a look. I never made it to the upstream branches since I
took a rest from my home Linux projects and never got back to them yet :P

> 
> Introduce the new module, k3-cppi-desc-pool, to provide the common
> functions to ti-am65-cpsw-nuss and icssg-prueth.

[...]

[0] https://lore.kernel.org/all/20221119225650.1044591-19-alobakin@pm.me

Thanks,
Olek