Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Fri, 13 Oct 2023 16:38:28 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     "zhaoyang.huang" <zhaoyang.huang@unisoc.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Suren Baghdasaryan <surenb@google.com>,
        Michal Hocko <mhocko@kernel.org>, Yu Zhao <yuzhao@google.com>,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Zhaoyang Huang <huangzhaoyang@gmail.com>, steve.kang@unisoc.com
Subject: Re: [RFC PATCH 1/1] mm: only use old generation and stable tier for
 madv_pageout
Message-ID: <ZSlkdGk2KG+zHAkg@casper.infradead.org>
References: <20231013113028.2720996-1-zhaoyang.huang@unisoc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231013113028.2720996-1-zhaoyang.huang@unisoc.com>
Precedence: bulk

On Fri, Oct 13, 2023 at 07:30:28PM +0800, zhaoyang.huang wrote:
> From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
> 
> Dropping pages of young generation or unstable tier via madvise could
> make the system experience heavy page thrashing and IO pressure.

... then userspace should not do that?

> @@ -5091,6 +5091,7 @@ static int get_tier_idx(struct lruvec *lruvec, int type)
>  
>  	return tier - 1;
>  }
> +EXPORT_SYMBOL_GPL(get_tier_idx);

Why would this need to be exported to modules in order to be used by
madvise?  Is this patch just a trojan horse so you can use get_tier_idx
in your own module?  NAK.