Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp1047984rdg; Fri, 13 Oct 2023 08:45:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFBPqEyc9PGOcU0XfRnx8NnbHEQo3CBDF4OhKls/8OFS5gFUtechaDbLRYYLJdmsE4UGOKj X-Received: by 2002:a05:6a00:218a:b0:693:3e7d:cb4c with SMTP id h10-20020a056a00218a00b006933e7dcb4cmr25699812pfi.16.1697211900183; Fri, 13 Oct 2023 08:45:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697211900; cv=none; d=google.com; s=arc-20160816; b=sUn16P65FeoLPzA2PGGAOJSlV1IjHrJhlESuiK0MBcHcjtagGyVeSaf7Gp6k8eIbZR gKCidiJIarbc7fODUUHv2nR16FMbU2hRn3wfDhGKBQ2aMamGohXF589mrha6kj8AjZhf xHvmERnnlw5nqOl9Svm35FAiNI2ZZRXmxxfejPz1TzrmONWfuvXqOfQUEzskEyqA6bCu YCPk1MmiiTZSQruGSc59Lox3sL4gJNJiQGLg6/v8FleJRnEacw3XFv0zckuUqcVKJJyK hyaqX6+aHcL45Xf10cjKOcLbrF7r9jCQz8wT6XphbijZaW1nJzyejAAE0WZrMBdFkDyr 0BdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=tMhjMlowKGjUkPnAh+hFFoE0oxgN/c+xofkiKByASAw=; fh=YSXErvu5BHRNGAbig4GwXkqGlGROhi6jayhJIiMIlas=; b=asa87eGC907Dt/xQzWu7h5x0N6BeTqv3ICDi5opR7wVJVZ1WHn0sLtF85Ije1KKry9 D+KnmWUAdv5w5L1nieR+I+9pfVVv4QDvMWZ59a8hnBrzA5rS016Mk8EbEEY/RQswLm0S bbM/CYTiknBZJQ+H5g1j3At7ivUgxCKSonYE2jDRql3ZpRWfVyA9R5QDPVLj6RGPUAgN 08nOTt+ubMPl0C95bpH18Kd5wm3JTcVuxa6IPiUd4JMWTyNk/cv0MEtAo7Rumr5oUonP UeBfSNM8Y6Sf86Oq0TbMEOhJ2D8KoF7L1JSnAl62fAa18PRN6IYLz75WbOfO6J/LU5v3 dZLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ah9ZcLKa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id b1-20020a056a000cc100b0068c7033a5f5si17600319pfv.74.2023.10.13.08.44.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 08:45:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ah9ZcLKa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id A39ED833CE24; Fri, 13 Oct 2023 08:44:56 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232441AbjJMPos (ORCPT + 99 others); Fri, 13 Oct 2023 11:44:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232410AbjJMPor (ORCPT ); Fri, 13 Oct 2023 11:44:47 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E532BBE; Fri, 13 Oct 2023 08:44:45 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4950CC433C8; Fri, 13 Oct 2023 15:44:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697211885; bh=gNiufPYZ0hqW339nlkZ0KShCby3GmH/4QjkDOxAMhRo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ah9ZcLKa5+3a5lw/2RUpzEBlv25I7NYXUvEM4cIdlEAA/57SWHHmYXgZEhi+corK2 sanaGiSfMiwMzlMD/ChiTUodBJ13U5rMtECK0R5fJivcc0o/VAo2QzbhyfJ2j+hblG 3i3lO7CmuteU+0Cd5rJ6nVMbbTJztOZnFXy7nS/8H1WkxGeZAumrGnvOLwIvL44wZI 42siTjyIoIzvBxCDvL3SRA71bmYwRWvKcnevi3x67vZIMt+nMm2SEcaIL7BMfnb1st 6CQx1DQcrgJZkU9x8xaLwfPAEC1jkpEyyPjveVJNkazRClwPtM6q7sdg719PlEpXmq IQkqy1seFCYpA== From: Christian Brauner To: Dan Clash Cc: Christian Brauner , linux-kernel@vger.kernel.org, paul@paul-moore.com, axboe@kernel.dk, linux-fsdevel@vger.kernel.org, dan.clash@microsoft.com, audit@vger.kernel.org, io-uring@vger.kernel.org Subject: Re: [PATCH] audit,io_uring: io_uring openat triggers audit reference count underflow Date: Fri, 13 Oct 2023 17:44:36 +0200 Message-Id: <20231013-karierte-mehrzahl-6a938035609e@brauner> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231012215518.GA4048@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20231012215518.GA4048@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1203; i=brauner@kernel.org; h=from:subject:message-id; bh=d37zo00rWfqEWvqv9CBNgrxFEsB2MVrLwwB/cAPjv9o=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaRqph5iehkbnpXoJ8qwaq/PM76TkusybaW+xVyfkfFFWKne 02ljRykLgxgXg6yYIotDu0m43HKeis1GmRowc1iZQIYwcHEKwEReNjMy9Nbt395ZrxhXcHbWoXc9Xa /1TP4cMM+48/GFREPiuqusvxj+iulVvZu9q4D57deIjKcvNYPL70caLdq4e33AfJvYr14L2AE= X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 13 Oct 2023 08:44:56 -0700 (PDT) On Thu, 12 Oct 2023 14:55:18 -0700, Dan Clash wrote: > An io_uring openat operation can update an audit reference count > from multiple threads resulting in the call trace below. > > A call to io_uring_submit() with a single openat op with a flag of > IOSQE_ASYNC results in the following reference count updates. > > These first part of the system call performs two increments that do not race. > > [...] Picking this up as is. Let me know if this needs another tree. --- Applied to the vfs.misc branch of the vfs/vfs.git tree. Patches in the vfs.misc branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.misc [1/1] audit,io_uring: io_uring openat triggers audit reference count underflow https://git.kernel.org/vfs/vfs/c/c6f4350ced79