Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
From:   Emil Kronborg Andersen <emkan@prevas.dk>
To:     linux@armlinux.org.uk
Cc:     emkan@prevas.dk, gregkh@linuxfoundation.org, jirislaby@kernel.org,
        linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
        saravanak@google.com
Subject: [PATCH] serial: amba-pl011: set fwnode from parent device
Date:   Fri, 13 Oct 2023 17:47:42 +0200
Message-ID: <20231013154742.76836-1-emkan@prevas.dk>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?47517WfhkOPd1/QXheaMyuy8iw++ioWtuaC+Sgv8o1xrun+LhTn1+UxgIXmw?=
 =?us-ascii?Q?fjRPR/iV88IRAUGUAivZay5tBw6V0ZhalIBZF1C5c+f0iCJMdQpGlgVhvMgV?=
 =?us-ascii?Q?IvgW4RMb4n93Z24vnMDw5ZPRack/17NW4ZXPk9KOA6RhHl1o/JJ3XATKy6Df?=
 =?us-ascii?Q?pnTF1EIXeEd6NXnyQ556GmPgE2w0S8MsJFzVkpkGcKEu+ohHVp8f47e7pUtQ?=
 =?us-ascii?Q?wfAitJqLqvxuwwR0P/+zXJa97Jkf5lbtnIRIO5b3dsrNOii+m2kEmCrSO7xq?=
 =?us-ascii?Q?xsR8F8BrdZI15/F53Ys9tmiA32G+PKIgiP/SP2a5JURp3D+dKdz9jZ+Mm0HG?=
 =?us-ascii?Q?O2Q9c/CuB1BFZW3bomLpPRv6AF4wm3s1vM9DYNfjzF/vSWy3D63VGhoEAgek?=
 =?us-ascii?Q?b78/gKtPX2NYyCkmBEoSDbbuVxuv2DOyvXOGb3HSNszkSwqfO+AkoThk9W5W?=
 =?us-ascii?Q?yeEzzUiRAPCKvsocmao1sZUfYoLvfFS83fJgqmaRQsQIMUCTELAcFmaYc9qe?=
 =?us-ascii?Q?rDY56Ma8jqMD5/VFwfs7ksRZYxmY64kBTAMqo7CcnKqHCGzKJA4h9i/as0s0?=
 =?us-ascii?Q?uKRs5ja4463/mjdChz3EaWStIU+ZulahZAZIjvx9HjqlqqU+olLilk5LcUp2?=
 =?us-ascii?Q?AXVCzcwI+vLja12Wpv+ugCl7XflCdiVaxI5PhZJv27hT1uiX6hL67iDjPKJg?=
 =?us-ascii?Q?Dz6Y9f+wPPR0OCCIl+PIFTyfd90OmdDq+L8TzEOCJZqwv0OHqDRhXknglodB?=
 =?us-ascii?Q?0nMBdbEPjkLbFhOcGOJt1YZEaUquPfduzQSCLwflZikuepZRU1ABLF4VX4fo?=
 =?us-ascii?Q?iOpCRhCRHmTpc+x/o3wpbKim0/BqHNPRGHhwiQ96PEaDcfeWTTHjhJ3gCx24?=
 =?us-ascii?Q?nXP8/ibz8CCW4RwPYQjVBu+LHNHgi9EJ1vsawTFZbZLxPE7TZSNDQFDa+2gx?=
 =?us-ascii?Q?D2i+h9vztJoZii63Qo4AB1bF8jvVauzlfI4Nw63ZY0qR1uFeLwaefSXFrQnT?=
 =?us-ascii?Q?FzlhdDgKZTxHWPaPoad5g2Nd3jfgqznS7MDZsuYObfYIlBgKx9Jnz+SqcJbq?=
 =?us-ascii?Q?QOjWVqZQ9Tx3m9y8E4MdWTSIl7iJPpL8wvJiIonG22XADKbnLVSPqO6qPjUG?=
 =?us-ascii?Q?ha0eV6RBSbMGpGWzVrNA+ahu370vfm06ZbbdHxpDXcYzI6IXBsvXOIuYV8lR?=
 =?us-ascii?Q?t8ZFkt3aLsKv6ZT7bCcstt47xLkKGEMuERXJW4OHjmVClrzZnYNfSX9W7vTi?=
 =?us-ascii?Q?Ql9OjU+PcLdJ+9Yixo3k98xfACTkcg5mLSSFEpIs6LikQXiTxKTiUVj0lOsm?=
 =?us-ascii?Q?lP0AZ53WrTYkxeCj4pvq9/TpNTZlA4EldVbvHDeuMps0L1Rs2WhdVWw5xceg?=
 =?us-ascii?Q?ZJdIDcrgC2m6YSvSWMczZQ6NBOxpxRNFA9aGR4WlhNq8nn+PMrPnJly4jMc9?=
 =?us-ascii?Q?IDuJ/+qOtF4qIYGxxH/pnnpLbNQGyL1b/mLbw+FBhGF7d/YJ5XrzV2o7m+cD?=
 =?us-ascii?Q?P1Hy7QFDteqmzPsoGj7IMhvNuoa/Giomi29IJizGNg5xK1G9SuLBUA2MdyFq?=
 =?us-ascii?Q?y2ZqHclFSOd9aQtMR2ZmG4HppJs9gOTFHpoAd/efpkRogoY/46qTXc6/rJKC?=
 =?us-ascii?Q?Sw=3D=3D?=
X-OriginatorOrg: prevas.dk
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ea52308-7569-4826-8667-08dbcc03c8e0
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB4576.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2023 15:48:03.1724
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d350cf71-778d-4780-88f5-071a4cb1ed61
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A0GE7TUgncHU6cCW4GVrLlRYjaAHaeez0lpT2mviqPKRSkqo904ngwlJNcQ6AzEdI2IHRGDbJNatV/GzrFupAA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR10MB3153
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 13 Oct 2023 08:48:15 -0700 (PDT)

After commit 3fb16866b51d ("driver core: fw_devlink: Make cycle
detection more robust"), consumer devices without their fwnode set
printed errors like the one below:

[    0.261887] uart-pl011 3f201000.serial: Failed to create device link (0x180) with soc:firmware:gpio

To fix this, set the fwnode so fw_devlink can find and handle it
properly.

Fixes: 3fb16866b51d ("driver core: fw_devlink: Make cycle detection more robust")
Signed-off-by: Emil Kronborg Andersen <emkan@prevas.dk>
---
 drivers/tty/serial/amba-pl011.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c
index 3dc9b0fcab1c..29cef84b71c0 100644
--- a/drivers/tty/serial/amba-pl011.c
+++ b/drivers/tty/serial/amba-pl011.c
@@ -2798,6 +2798,8 @@ static int pl011_probe(struct amba_device *dev, const struct amba_id *id)
 	int portnr, ret;
 	u32 val;
 
+	device_set_node(&dev->dev, dev_fwnode(dev->dev.parent));
+
 	portnr = pl011_find_free_port();
 	if (portnr < 0)
 		return portnr;
-- 
2.41.0