Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp1057062rdg; Fri, 13 Oct 2023 09:01:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH7KtqVQXvtKbJGRcON5u72e5isMC54r0ri9o+COiDHuN4L8Vmnk4JpXvVPlHMwNODcfwft X-Received: by 2002:a05:6a20:3ca8:b0:15e:b763:2422 with SMTP id b40-20020a056a203ca800b0015eb7632422mr774473pzj.9.1697212871742; Fri, 13 Oct 2023 09:01:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697212871; cv=none; d=google.com; s=arc-20160816; b=CXPsR9Cbg0DIYh0qAP7yxwl/FUJ3ADZPFHsd2cejvYipHr87COhs6L9iiK/6UCI3Dr by9r/zSXtHFLZPLLWMjoEARew5L+FaMLQdK0mTHCPiF40hgLzLq8XDHSjBcXx1NOSjcK twxUhUNQ+PeBy7PMMHW9rmmFP20S+CCOBRdI/fuMZfVslg88dHEr6De8bMr9K51/fJEr BxAFZWLvdWn1vWUOfHwYpq+XFgPqC+2wlCklCHyTnwurBM3vSf0VeWZwNW6/3CSgJL46 3oaJ7QFBQOInUseEXxgFs+CpysN7yOl591jQ/OG3fzZpk9f5uGGCF0RjhM8IeFCmcYt9 NmkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=YJ2WmwaOdUeneIw/Q5PT7IiBFVxA19ldRBu/8pCiZi8=; fh=V1y4LQvauSwHNOQC2xSg1adedKURMKsvVl0OvLLU6lQ=; b=bIBw9MiWvol0x5ae9zupfSE4SYud/4HujKzysW2NYU/AJf/RfCcUjb2qKb5+g+QwUI WxtsQUG4+mzMJem+dwLO0oLL+bYTZt/Mb1V0ZyzCnBHpxgDmoBmw1tqL0+hzLvWjNgGY ANIm1MQ/YmbZ4GWtXy+FAK77Ur82LhgvaXsazOPL5sZPOSo1uWLstpOcB/sCDAvmdAht sTzyJIP9DE4q3/nXlTjaACxEI0MxMzO9g9WjaS49FX0A8oB1kiMN1aeqQ5wnBGeQhy7q 8DzQXKDRnUxpEIuJu27n6MKrbcRi3SOzB0dycd742cXac22NGD5xs+UmbdtcO34PdjX4 HGbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=LeitdU9u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id ct27-20020a056a000f9b00b006933c9f9f20si17340039pfb.225.2023.10.13.09.01.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 09:01:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=LeitdU9u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id EF6AF80612B3; Fri, 13 Oct 2023 09:01:08 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232589AbjJMQAl (ORCPT + 99 others); Fri, 13 Oct 2023 12:00:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232597AbjJMQAf (ORCPT ); Fri, 13 Oct 2023 12:00:35 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85263B7; Fri, 13 Oct 2023 09:00:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=YJ2WmwaOdUeneIw/Q5PT7IiBFVxA19ldRBu/8pCiZi8=; b=LeitdU9uKWU/vjLbeLWfeyUChM UszrF5X7zGTSXEN5Txtu9dHjLRvvODPJqFRG+lWOqa5SXQzUamGNgZGspOCQV6N5uXiL2ekAnGD0P 3WUGhLFOO0LqABXgBKeEIJ6p4V6KiDGJI+0M+Ea9WCnnidSXwNeKCC8tqitoRvPm6pL8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qrKaQ-0026mP-EM; Fri, 13 Oct 2023 18:00:26 +0200 Date: Fri, 13 Oct 2023 18:00:26 +0200 From: Andrew Lunn To: MD Danish Anwar Cc: Grygorii Strashko , Roger Quadros , Simon Horman , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, srk@ti.com, Vignesh Raghavendra , r-gunasekaran@ti.com Subject: Re: [PATCH net] net: ti: icssg-prueth: Fix r30 CMDs bitmasks Message-ID: <8b11140d-6d91-48aa-be66-9c4a117366af@lunn.ch> References: <20231013111758.213769-1-danishanwar@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231013111758.213769-1-danishanwar@ti.com> X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 13 Oct 2023 09:01:09 -0700 (PDT) On Fri, Oct 13, 2023 at 04:47:58PM +0530, MD Danish Anwar wrote: > The bitmask for EMAC_PORT_DISABLE and EMAC_PORT_FORWARD has been changed > in the latest ICSSG firmware. > > The current bitmasks are wrong and as a result EMAC_PORT_DISABLE and > EMAC_PORT_FORWARD commands do not work. > Update r30 commands to use the same bitmask as used by the latest ICSSG > firmware. Please indicate in the commit message this is backwards compatible with old firmware. I assume it is actually backwards compatible. Andrew --- pw-bot: cr