Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Fri, 13 Oct 2023 10:05:34 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     "Wilczynski, Michal" <michal.wilczynski@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        <nvdimm@lists.linux.dev>, <linux-acpi@vger.kernel.org>
CC:     <rafael@kernel.org>, <vishal.l.verma@intel.com>, <lenb@kernel.org>,
        <dave.jiang@intel.com>, <ira.weiny@intel.com>,
        <linux-kernel@vger.kernel.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v2] ACPI: NFIT: Fix local use of devm_*()
Message-ID: <652978deafdf8_f8792944c@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <20231013085722.3031537-1-michal.wilczynski@intel.com>
 <6529727e18964_f879294ea@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <f7441bb4-c2c9-4eee-9fed-ad8b28de4788@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <f7441bb4-c2c9-4eee-9fed-ad8b28de4788@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bBBB+gdvpEV+HVxFcdseb3YpfWn3PBee8u+lmgzKGd6Ghnj4hA1c3IgydGjn?=
 =?us-ascii?Q?iW0CidEBuudADqns8fBVPpkUuP2v1gwuezAJvAZnImDYZKDMlmIiE9gNftP7?=
 =?us-ascii?Q?hypHYzRHH/REOwmyTjxXmJeHfZPhI8abCK3dLTQjU7bQB6YInNBf0MxUcHZe?=
 =?us-ascii?Q?Ce/vNTLRWuMuF1wDVQ8hZ9M4f1FAK1lG4SRQpvduay5B6u3+fUZayoM0TlIB?=
 =?us-ascii?Q?MhyJ6cRgLH4xbf0ksstFg3XsO4VmD6rXUyTe1VPvPbMoxn5J5xnQAqZhAge3?=
 =?us-ascii?Q?pAwByZWt4gJa96eKg+Zh4MikOGMiwr8zuNPSQYIx4NQG89OIlIYxfwm67Xrz?=
 =?us-ascii?Q?1Wk2SCSad8szWBVlfd4FzI5ycbQpupSg8fheUQrKLcpiuYmZ+6ea7sTCGKHY?=
 =?us-ascii?Q?ywXSMH2ONUzX/MltxxdedaCXfz27u5AJwQamuoHZU6ldSitRKDKfBEB1Fsdy?=
 =?us-ascii?Q?2vFu5yzg1XN1jcUDogrS6i9fEwtnC4Xzcg/fEp1dYcmDGptO+ptnN4tp7nn5?=
 =?us-ascii?Q?ts748nY2Z4ReMKN8MFvFrih8CrnkT4vloNjllzy8i+A94tpm9eapd5woCAfO?=
 =?us-ascii?Q?U0y/EBk88BAUoQdfvKdZlmh/Wzi1/q2traAmdH4qQd0XYI6111Ripz+KroS+?=
 =?us-ascii?Q?oVg+qJqFysjyfdCOleVmX/yFgnlvhNyuBjtwj/QiJTQsoEbkt1pmCSn+5PwP?=
 =?us-ascii?Q?3/xi8XcIUK/B/Kb3LIL+pHRjAMbJZ6cOBLy/bQZEJSscCJyNUS1HUdNFGtMH?=
 =?us-ascii?Q?v90QcTCOyCLI/MUG/J7wroeZvaik99KV7e7O04g07n5jJL4d4Gn2eFXK7C8o?=
 =?us-ascii?Q?ukNvhz1YoTF8Vf7ey2wIvtJx79ksq/PCWPEGdgRTxmMS8eygco9we8zEbMp8?=
 =?us-ascii?Q?vNWqJt97ONLanKsY9bY1Kh9paundXgkNvXhb1Eit9Bj9GweMJMdb6NFRFQCS?=
 =?us-ascii?Q?D7E0+YExx3fO53C4OKYC5LQ+SejkYd9SMRTeG0mHSRuhQhLpNTNCUAXu0MA2?=
 =?us-ascii?Q?dBdkR8fF630v+ErR2dsbRKw5p1mMBGr4vbx4IIs3ZRWrWIK2NKZymLd0/AwO?=
 =?us-ascii?Q?zmkDMgKqc4KLa7Ou6iOSNhYDSn0qFJcQVB5fzjnWalF/injakeSfH5aQ770k?=
 =?us-ascii?Q?zOdyArOiXKJS/DrYYA4vgrO/2GSudlhoxfTxFfl4s/j+vHt6yfCDeHOp2zzn?=
 =?us-ascii?Q?WhGrY97WPYx5ZcU7xDOimBZQ4IqoqZtCvhKZV3AKSl7vZ4Vu26JtLDQFZe7S?=
 =?us-ascii?Q?RRijtDMZKWf4zUqv0J8KcRV83PeQz9/K096ECUTDAkrDqibm+QYs11qGErDL?=
 =?us-ascii?Q?uz2lJNbpQVNXkkfvwPX/dAua9kUyWxYmd7gDWfUnQrd5Wol1kQ10Gt/r7vEC?=
 =?us-ascii?Q?iCdljXfSrNpRolwrDUOjf8YUl5Szq3I8xA3CbmV42MYjGNdFab+uxM5J4Vcy?=
 =?us-ascii?Q?qmZqO/Rzs616tPzM6SwGObmu+GG4bqAC42vJEQrs0n5jIMXV3Ptij0il+toD?=
 =?us-ascii?Q?8kbPFLGrNQmyQSwhlw47KfxWSYZaVAVwx1CqH9jwI0xKtCfMWSI1BG/mae87?=
 =?us-ascii?Q?5GKYrxAM2TsTMojoCwwE7uR2ZxBjtJKdevu4zDq9NULh/pnv37H7w7cjfwJq?=
 =?us-ascii?Q?UA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4d48b6b8-0ff8-4ca7-ed05-08dbcc0e9ee0
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2023 17:05:37.1938
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UoFOwTDjvxHm18pfjGJUKOaL++zyxk4n1MQbCqydvq0Fkrzr86l64ba+4ILtqckEyzPzPSHdxrUIuiC4ZEye4OmG1kHY30/P/oMI3KJSUcE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6851
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 13 Oct 2023 10:06:07 -0700 (PDT)

Wilczynski, Michal wrote:
> On 10/13/2023 6:38 PM, Dan Williams wrote:
> > Michal Wilczynski wrote:
> >> devm_*() family of functions purpose is managing memory attached to a
> >> device. So in general it should only be used for allocations that should
> >> last for the whole lifecycle of the device. 
> > No, this assertion is not accurate, if it were strictly true then
> > devm_kfree() should be deleted. This patch is only a cleanup to switch
> > the automatic cleanup pattern from devm to the new cleanup.h helpers.
> 
> The memory in question is only used locally in a function, so there is no reason
> to use devm_*() family of functions. I think devm_kfree() is more for special
> cases where the memory is meant to be used for the whole lifecycle of device,
> but some special case occurs and it's not and it needs to be freed.
> 
> This is an incorrect API usage. Would you propose to change all memory
> allocations currently being done to devm_*() family simply because devm_kfree()
> exists ?

Michal, please work with someone else to get these cleanups upstream, I
am done with this thread.